Apply consistent font size to TahS' footer
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Sarai-WMDE
	Jun 23 2022, 6:29 PM

Description

Background

Codex's TahS' footer currently consumes the variable @font-size-search-result-title, which causes its font-size to be larger than that of MenuItems (it translates to around 18.2px instead of 16px in the demo site).

Screenshot 2022-06-23 at 20.22.06.png (544×970 px, 124 KB)

Goal

This should be corrected: the footer should display a font-size that's consistent with that of the rest of the menu options.

AC:

The Menu's footer text displays the same font-size as the rest of the items in the menu

Details

	Subject	Repo	Branch	Lines +/-
	styles, TypeaheadSearch: Reduce footer font size	design/codex	main	+0 -5

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Duplicate		None	T299666 Add TypeaheadSearch component to Codex
Resolved		Sarai-WMDE	T297025 Add TypeaheadSearch to Codex
Resolved	BUG REPORT	• EUdoh-WMF	T311265 Apply consistent font size to TahS' footer

Event Timeline

Sarai-WMDE created this task.Jun 23 2022, 6:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2022, 6:29 PM

Sarai-WMDE added a project: Codex.Jun 23 2022, 6:29 PM

Sarai-WMDE updated the task description. (Show Details)

Sarai-WMDE added a parent task: T297025: Add TypeaheadSearch to Codex.Jun 23 2022, 6:32 PM

Change 808082 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] styles, TypeaheadSearch: Reduce footer font size

https://gerrit.wikimedia.org/r/808082

gerritbot added a project: Patch-For-Review.Jun 23 2022, 9:40 PM

AnneT edited projects, added Design-System-Team (Design-System-Sprint); removed Design-System-Team.Jun 23 2022, 9:40 PM

AnneT moved this task from Committed to Code Review on the Design-System-Team (Design-System-Sprint) board.

Change 808082 merged by jenkins-bot:

[design/codex@main] styles, TypeaheadSearch: Reduce footer font size

https://gerrit.wikimedia.org/r/808082

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2022, 10:30 PM

AnneT moved this task from Code Review to Design Sign-Off on the Design-System-Team (Design-System-Sprint) board.Jun 27 2022, 4:39 PM

Thanks for the patch, @AnneT! Changes are looking great in, as always, Safari v15.5, Firefox v101 and Chrome v103 on MacOS Monterey. The task can be signed-off.

Sarai-WMDE moved this task from Design Sign-Off to QTE Sign-off on the Design-System-Team (Design-System-Sprint) board.Jun 27 2022, 5:15 PM

Setting Owner to Ezekiel for QTE Sign-off

Looks good from my end as well!

Tested on Safari 15.1, Chrome 103 and Firefox 101.

Part of Codex alpha 8 release

Signing off.

ldelench_wmf closed this task as Resolved.Aug 14 2022, 11:12 PM

	F35268773: Screenshot 2022-06-23 at 20.22.06.png
	Jun 23 2022, 6:29 PM

Apply consistent font size to TahS' footerClosed, ResolvedPublicBUG REPORTActions