Page MenuHomePhabricator

Apply consistent font size to TahS' footer
Open, Needs TriagePublic

Description

Background

Codex's TahS' footer currently consumes the variable @font-size-search-result-title, which causes its font-size to be larger than that of MenuItems (it translates to around 18.2px instead of 16px in the demo site).

Screenshot 2022-06-23 at 20.22.06.png (544×970 px, 124 KB)

Goal

This should be corrected: the footer should display a font-size that's consistent with that of the rest of the menu options.

AC:

  • The Menu's footer text displays the same font-size as the rest of the items in the menu

Event Timeline

Change 808082 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] styles, TypeaheadSearch: Reduce footer font size

https://gerrit.wikimedia.org/r/808082

Change 808082 merged by jenkins-bot:

[design/codex@main] styles, TypeaheadSearch: Reduce footer font size

https://gerrit.wikimedia.org/r/808082

Thanks for the patch, @AnneT! Changes are looking great in, as always, Safari v15.5, Firefox v101 and Chrome v103 on MacOS Monterey. The task can be signed-off.

NHillard-WMF added a subscriber: NHillard-WMF.

Setting Owner to Ezekiel for QTE Sign-off

Looks good from my end as well!

Tested on Safari 15.1, Chrome 103 and Firefox 101.

Sarai-WMDE added a subscriber: DAbad.

Part of Codex alpha 8 release