New rule: `catch` should not be on its own line
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Jun 23 2022, 10:28 PM

Description

catch should go on the same line as the preceding } from either try or an earlier catch
See https://gerrit.wikimedia.org/r/q/topic:start-catch for manual fixes

	Subject	Repo	Branch	Lines +/-
	Enable Squiz.ControlStructures.ControlSignature	mediawiki/tools/codesniffer	master	+461 -720
	New sniff: MediaWiki.WhiteSpace.SameLineCatch	mediawiki/tools/codesniffer	master	+175 -0

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 840632 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/tools/codesniffer@master] New sniff: MediaWiki.WhiteSpace.SameLineCatch

Change 840632 merged by jenkins-bot:

[mediawiki/tools/codesniffer@master] New sniff: MediaWiki.WhiteSpace.SameLineCatch

finally can be used in the same way, but it is not part of the sniff (and its name), same for try

try
{
   // do something
}
finally
{
   // do something other
}

Change 910038 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/tools/codesniffer@master] Enable Squiz.ControlStructures.ControlSignature

Change 910038 merged by jenkins-bot:

[mediawiki/tools/codesniffer@master] Enable Squiz.ControlStructures.ControlSignature

Daimona closed this task as Resolved.Jun 24 2023, 3:56 PM