Page MenuHomePhabricator
Create Task
Maniphest T311296

Decouple forked OutlineControlsWidget from OutlineSelectWidget and merge in our customizations
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

  • Delete onOutlineChange and usages.
  • New function in two-pane layout to refreshControls which calculates whether we can move the current selection up and down, and whether it can be deleted.
  • Replace all outlineSelectWidget selectItemByData and selectItem calls with refreshControls.

Optional:

Details

Other Assignee
awight
Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.Jun 24 2022, 10:11 AM
awight added a parent task: T311223: Fork OutlineControlsWidget.
awight updated the task description. (Show Details)Jun 24 2022, 10:14 AM
awight removed a parent task: T311223: Fork OutlineControlsWidget.Jun 27 2022, 1:22 PM
awight added a subtask: T311223: Fork OutlineControlsWidget.
awight updated the task description. (Show Details)Jun 27 2022, 1:39 PM
awight updated the task description. (Show Details)Jun 27 2022, 1:51 PM
awight updated the task description. (Show Details)Jun 27 2022, 1:53 PM
awight updated the task description. (Show Details)
awight updated the task description. (Show Details)Jun 27 2022, 2:08 PM
lilients_WMDE claimed this task.Jun 27 2022, 2:45 PM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-06-22 board.
lilients_WMDE updated Other Assignee, added: awight.
gerritbot added a comment.Jun 27 2022, 2:46 PM

Change 808915 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/VisualEditor@master] Create new refreshControls function in TwoPane

https://gerrit.wikimedia.org/r/808915

gerritbot added a project: Patch-For-Review.Jun 27 2022, 2:46 PM
WMDE-Fisch moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Jun 28 2022, 7:48 AM
lilients_WMDE updated the task description. (Show Details)Jun 28 2022, 1:29 PM
lilients_WMDE set the point value for this task to 5.
gerritbot added a comment.Jun 28 2022, 2:11 PM

Change 809174 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Move custom buttons into outline controls

https://gerrit.wikimedia.org/r/809174

lilients_WMDE moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-06-22 board.Jun 28 2022, 2:20 PM
gerritbot added a comment.Jun 28 2022, 3:17 PM

Change 809200 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove unused code and properties from forked ControlsWidget

https://gerrit.wikimedia.org/r/809200

gerritbot added a comment.Jun 29 2022, 9:52 AM

Change 809566 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Remove unused config parameter

https://gerrit.wikimedia.org/r/809566

gerritbot added a comment.Jun 29 2022, 10:06 AM

Change 808915 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Create new refreshControls function in TwoPane

https://gerrit.wikimedia.org/r/808915

gerritbot added a comment.Jun 29 2022, 10:28 AM

Change 809174 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Move custom buttons into outline controls

https://gerrit.wikimedia.org/r/809174

gerritbot added a comment.Jun 29 2022, 10:45 AM

Change 809200 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove unused code and properties from forked ControlsWidget

https://gerrit.wikimedia.org/r/809200

gerritbot added a comment.Jun 29 2022, 10:59 AM

Change 809576 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Disable controls when nothing is selected

https://gerrit.wikimedia.org/r/809576

lilients_WMDE updated the task description. (Show Details)Jun 29 2022, 1:11 PM
lilients_WMDE removed lilients_WMDE as the assignee of this task.Jun 29 2022, 1:41 PM
lilients_WMDE subscribed.
gerritbot added a comment.Jun 29 2022, 3:13 PM

Change 809622 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/VisualEditor@master] Refresh controls after removing a template

https://gerrit.wikimedia.org/r/809622

gerritbot added a comment.Jun 30 2022, 6:16 AM

Change 809877 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Detect parameter placeholder

https://gerrit.wikimedia.org/r/809877

gerritbot added a comment.Jun 30 2022, 6:49 AM

Change 809880 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Calculate controls using sidebar selection

https://gerrit.wikimedia.org/r/809880

gerritbot added a comment.Jun 30 2022, 6:53 AM

Change 809877 abandoned by Awight:

[mediawiki/extensions/VisualEditor@master] Detect parameter placeholder

Reason:

Yeah irrelevant if the other patch is merged.

https://gerrit.wikimedia.org/r/809877

gerritbot added a comment.Jun 30 2022, 6:56 AM

Change 809881 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Rely on selection changed event for updating controls

https://gerrit.wikimedia.org/r/809881

gerritbot added a comment.Jun 30 2022, 8:00 AM

Change 809880 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Calculate controls using sidebar selection

https://gerrit.wikimedia.org/r/809880

gerritbot added a comment.Jun 30 2022, 8:18 AM

Change 809881 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Rely on selection changed event for updating controls

https://gerrit.wikimedia.org/r/809881

gerritbot added a comment.Jun 30 2022, 9:15 AM

Change 809576 abandoned by WMDE-Fisch:

[mediawiki/extensions/VisualEditor@master] Disable controls when nothing is selected

Reason:

Seems like this is not needed anymore due to I684a9edf04b6615cc840bbb89e8c1d03a0ab8e94

https://gerrit.wikimedia.org/r/809576

gerritbot added a comment.Jun 30 2022, 12:32 PM

Change 809972 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/VisualEditor@master] Re-add refreshControls to TwoPaneDialog

https://gerrit.wikimedia.org/r/809972

gerritbot added a comment.Jun 30 2022, 1:26 PM

Change 809972 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Re-add refreshControls to TwoPaneDialog

https://gerrit.wikimedia.org/r/809972

gerritbot added a comment.Jun 30 2022, 2:33 PM

Change 810002 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Reconnect "soft select" event

https://gerrit.wikimedia.org/r/810002

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jun 30 2022, 3:26 PM
WMDE-Fisch moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2022-06-22 board.Jul 1 2022, 10:31 AM
WMDE-Fisch subscribed.

Looks like the main work is done. We should deal with regressions separately.

gerritbot added a comment.Jul 1 2022, 12:50 PM

Change 810002 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Reconnect "soft select" event

https://gerrit.wikimedia.org/r/810002

awight closed this task as Resolved.Jul 4 2022, 1:57 PM
awight claimed this task.
awight closed subtask T311223: Fork OutlineControlsWidget as Resolved.
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 11 2022, 9:02 PM
gerritbot added a comment.Aug 4 2022, 6:11 PM

Change 809622 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/VisualEditor@master] Refresh controls after removing a template

Reason:

Most probably obsolete by now. T311296 is done.

https://gerrit.wikimedia.org/r/809622

gerritbot added a comment.Aug 4 2022, 6:33 PM

Change 809566 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove unused config parameter from forked ControlsWidget

https://gerrit.wikimedia.org/r/809566

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.25; 2022-08-15); removed MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Aug 4 2022, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits