Page MenuHomePhabricator

Visual refinements to page toolbar & VE toolbar
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

In T310197 we moved the VE toolbar below the article toolbar. In T309398#8003719 @Esanders pointed out that the border between the toolbar and VE does not match the border below VE. The purpose of this task is to visually refine those borders so that they feel more harmonious with each other.

To do

  • darken the border below the article toolbar to match the border below VE (#c8ccd1)
read modeedit mode
Screen Shot 2022-07-13 at 11.35.27 AM.png (836×1 px, 505 KB)
image.png (1×2 px, 508 KB)
  • remove the faint blue border underneath the "Article" tab (appears when in Edit mode)
Screen Shot 2022-08-10 at 12.01.11 PM.png (633×602 px, 31 KB)
seems to be coming from:
Screen Shot 2022-07-27 at 4.06.59 PM.png (92×257 px, 9 KB)
  • remove the faint gray border to the left of the VE toolbar

Appendix

We could wait until the VE toolbar switches to fixed positioning in order to apply the box-shadow, however the editing team would not like to change this at this time.

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ovasileva triaged this task as Medium priority.Jun 27 2022, 10:23 AM

To start off with here are two possibilities:

Which do we want to go with?

@Esanders @ppelberg do you have a preference and/or concerns given the options above? I am slightly partial to the darker borders.

I prefer the darker borders too. I don't think we need to remove the drop shadow while not floating yet. It is set upstream and is used in situations where the toolbar doesn't float (in dialogs) where I think it still helps:

image.png (179×476 px, 18 KB)

I prefer the darker borders too. I don't think we need to remove the drop shadow while not floating yet. It is set upstream and is used in situations where the toolbar doesn't float (in dialogs) where I think it still helps:

image.png (179×476 px, 18 KB)

ok, i've updated the task description to reflect the plan here. re: box-shadow, understood. (for the top-of-page VE experience i still think it looks better without the box-shadow initially, but leave that up to y'all)

@Esanders @nayoub noticed two other things today:

Screen Shot 2022-07-27 at 4.05.02 PM.png (1×1 px, 405 KB)

  1. when in edit mode the "Article" tab has a faint blue border underneath it. seems to be coming from:
    Screen Shot 2022-07-27 at 4.06.59 PM.png (92×257 px, 9 KB)
  1. the box-shadow on the VE toolbar causes a sort of faint gray left border — not sure whether this is intended or not

moving this to blocked on others until we hear back from the editing team regarding the two additional points in my comment above (cc @ppelberg)

  1. That should be removed in Vector 2022. I think in classic Vector it is to make the toolbar top border a continuous line.
  2. Not really, but I don't think there's a good way to prevent it. Setting overflow:hidden on the toolbar would probably cause many other problems.

Change 822107 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Limit toolbar top border fix to vector-legacy

https://gerrit.wikimedia.org/r/822107

I found a decent way to fix #2 as well.

Change 822140 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Tweak main toolbar shadow to not leak out from the sides on vector-2022

https://gerrit.wikimedia.org/r/822140

@ppelberg @Esanders are you all taking care of the engineering work here? if so, can you put this in design review on our board when you're done with it so I can look at it before it goes out?

Change 822107 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Limit toolbar top border fix to vector-legacy

https://gerrit.wikimedia.org/r/822107

Change 822140 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Tweak main toolbar shadow to not leak out from the sides on vector-2022

https://gerrit.wikimedia.org/r/822140

@ppelberg @Esanders are you all taking care of the engineering work here? if so, can you put this in design review on our board when you're done with it so I can look at it before it goes out?

Done

thanks @matmarex. On the beta cluster I am seeing:

  • there is no longer a faint blue border beneath the Article tab ✅
  • the box-shadow on the VE toolbar is no longer a resulting in a sort of faint gray left border ✅
  • the border below the article toolbar is still #eaecf0 (should be #c8ccd1) ❌

is that last item something you/your team can do, or should our team do it?

Change 830700 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Change article toolbar bottom border color

https://gerrit.wikimedia.org/r/830700

bwang removed bwang as the assignee of this task.Sep 8 2022, 4:22 PM
bwang subscribed.

Please move to needs more work or sign off.

Change 830700 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Change article toolbar bottom border color

https://gerrit.wikimedia.org/r/830700

Looks good to me, @ppelberg - would you like to sign this one off?

Looks good to me, @ppelberg - would you like to sign this one off?

Thank you for the ping, @ovalieva. Yep, I'll take care of closing this one out.

@ovasileva @Jdlrobson @Esanders it seems like something changed here after I design reviewed it. The article toolbar (.mw-article-toolbar-container), in production, has: box-shadow: 0 1px #a2a9b1;

This means the border no longer matches the border beneath the VE toolbar, which was the main goal of this task. This also results in the tab underlines being difficult to see, which several community members have commented about. Compare:

design reviewed in betacurrently on production
Screen Shot 2022-09-23 at 8.58.32 AM.png (364×854 px, 54 KB)
Screen Shot 2022-09-23 at 8.58.51 AM.png (244×674 px, 18 KB)

Also, maybe related, when in editing mode there is no border beneath the toolbar:

Screen Shot 2022-09-23 at 8.24.50 AM.png (602×2 px, 237 KB)

This is likely a side effect of T317930 which had conflicting goals.

In Thursday standup we agreed to pull this out into a separate ticket: T318952