@Esanders @ppelberg do you have a preference and/or concerns given the options above? I am slightly partial to the darker borders.

I prefer the darker borders too. I don't think we need to remove the drop shadow while not floating yet. It is set upstream and is used in situations where the toolbar doesn't float (in dialogs) where I think it still helps:

In T311311#8084272, @Esanders wrote:

I prefer the darker borders too. I don't think we need to remove the drop shadow while not floating yet. It is set upstream and is used in situations where the toolbar doesn't float (in dialogs) where I think it still helps:

ok, i've updated the task description to reflect the plan here. re: box-shadow, understood. (for the top-of-page VE experience i still think it looks better without the box-shadow initially, but leave that up to y'all)

@Esanders @nayoub noticed two other things today:

1. when in edit mode the "Article" tab has a faint blue border underneath it. seems to be coming from:
   

2. the box-shadow on the VE toolbar causes a sort of faint gray left border — not sure whether this is intended or not

1. That should be removed in Vector 2022. I think in classic Vector it is to make the toolbar top border a continuous line.
2. Not really, but I don't think there's a good way to prevent it. Setting overflow:hidden on the toolbar would probably cause many other problems.

Change 822107 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Limit toolbar top border fix to vector-legacy

https://gerrit.wikimedia.org/r/822107

I found a decent way to fix #2 as well.

Change 822140 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Tweak main toolbar shadow to not leak out from the sides on vector-2022

https://gerrit.wikimedia.org/r/822140

@ppelberg @Esanders are you all taking care of the engineering work here? if so, can you put this in design review on our board when you're done with it so I can look at it before it goes out?

Change 822107 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Limit toolbar top border fix to vector-legacy

https://gerrit.wikimedia.org/r/822107

Change 822140 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Tweak main toolbar shadow to not leak out from the sides on vector-2022

https://gerrit.wikimedia.org/r/822140

In T311311#8146419, @alexhollender_WMF wrote:

@ppelberg @Esanders are you all taking care of the engineering work here? if so, can you put this in design review on our board when you're done with it so I can look at it before it goes out?

Done

thanks @matmarex. On the beta cluster I am seeing:

• there is no longer a faint blue border beneath the Article tab ✅
• the box-shadow on the VE toolbar is no longer a resulting in a sort of faint gray left border ✅
• the border below the article toolbar is still #eaecf0 (should be #c8ccd1) ❌

is that last item something you/your team can do, or should our team do it?

It looks like this color is defined in Vector, so I guess it's up to you:

https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/81fced891e34b353aa97cc12d8678f9c77efd7ad/resources/skins.vector.styles/components/ArticleToolbar.less#8
https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/81fced891e34b353aa97cc12d8678f9c77efd7ad/resources/common/variables.less#85

Moving to TODO. See T311311#8195578 for required web team change.

Change 830700 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Change article toolbar bottom border color

https://gerrit.wikimedia.org/r/830700

Change 830700 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Change article toolbar bottom border color

https://gerrit.wikimedia.org/r/830700

Looks good to me, @ppelberg - would you like to sign this one off?

In T311311#8228026, @ovasileva wrote:

Looks good to me, @ppelberg - would you like to sign this one off?

Thank you for the ping, @ovalieva. Yep, I'll take care of closing this one out.

@ovasileva @Jdlrobson @Esanders it seems like something changed here after I design reviewed it. The article toolbar (.mw-article-toolbar-container), in production, has: box-shadow: 0 1px #a2a9b1;

This means the border no longer matches the border beneath the VE toolbar, which was the main goal of this task. This also results in the tab underlines being difficult to see, which several community members have commented about. Compare:

design reviewed in beta	currently on production

Also, maybe related, when in editing mode there is no border beneath the toolbar:

This is likely a side effect of T317930 which had conflicting goals.