Page MenuHomePhabricator

[Tech debt] Consolidate vector-toc-visible and vector-sidebar-container-no-toc
Closed, ResolvedPublicBUG REPORT

Description

These two classes are used in Vector as of https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/805232 and have similar meanings. While one (vector-sidebar-container-no-toc) is associated with the sidebar, the class .vector-toc is not.

We should give this more thought so we understand it a little better.

Question:

  • IS this a class that belongs on the body tag? If so, how can we do that given table of contents state is not computed until Skin::getTemplateData
  • Do they do the same thing or do they serve different purposes? Do these relate to modified versions of components (see http://getbem.com/naming/) or a state for the page?
  • If we renamed the classes what would more meaningful classes be?

What happens?:

What should have happened instead?:

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.: