Page MenuHomePhabricator

Button to reset filters in Special:NewPagesFeed
Closed, ResolvedPublicFeature

Description

Feature summary
In [[Special:NewPagesFeed]] -> Set filters, suggest placing a green "Reset" button next to the green "Set filters" button. This would reset the filters to default.

Use case(s)

Benefits
[[Special:NewPagesFeed]] remembers your old settings and sometimes the user just wants to go back to default settings or less customized settings. Could be especially useful for clearing date ranges with less clicks (e.g. not having to pop open the calendar widget and click "clear")

image.png (818×1 px, 92 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 848170 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] NewPagesFeed: Adding a "Reset Filters" button for NPP

https://gerrit.wikimedia.org/r/848170

MPGuy2824 changed the task status from Open to In Progress.Oct 24 2022, 7:49 AM
MPGuy2824 claimed this task.
MPGuy2824 moved this task from Backlog to Code Review on the PageTriage board.

Change 848170 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] NewPagesFeed: Adding a "Reset Filters" button for NPP

https://gerrit.wikimedia.org/r/848170

Hi @kostajh,

The Reset filter button works just fine when clicked.

  1. Just to confirm - the buttons are not green as stated in the feature summary. Is this intentional? I checked this on Chrome v106, Safari v16 and Firefox v107.

image.png (1×1 px, 546 KB)

  1. My thoughts - there is an existing Set Filters button which when clicked, takes an action and filters the page. For the new Reset filters button, the user clicks it and it resets the filters but I instinctively expected it to take an action and load the NewPageField with all results, since it is a button. However, I had to click the Set Filters again to see the results or go to the news feed page and click on Refresh List to see the unfiltered results. The complete experience does not seem so smooth and I think it may be due to what I was expecting from a button.

Can I suggest - what if this Reset Filter was another type of CTA (for example, like a link rather than a button)? Or what if clicking the Reset Filter button immediately loads the news feed with all results? I would like to hear your thoughts about this.

The button appears red to me on vector 2010. The light gray buttons in your screenshot appear to be a quirk of vector-2022. I'll create a ticket: T323673

  • Red is a bit bright. Dark gray might be a better choice, but I'd also be OK with leaving as is.
  • Leaning towards keeping it a button, but making it a link would be acceptable.
  • Disinclined to make clicking "Reset filters" close the filter dialog and reload the feed.

@MPGuy2824, thoughts?

image.png (860×1 px, 125 KB)

Red is a bit bright. Dark gray might be a better choice, but I'd also be OK with leaving as is.

I'm fine with any color, except green. It needs to be differentiated from the "Set filters" button. There's a lot of overlap with the text of that button already.
I chose red here, as it is the color choice for destructive events (you are undoing the filter choices that you've already made). Unless someone thinks this is a big issue, we could leave it as-is until this screen has to rewritten to comply with the mediawiki codex guidelines.

Leaning towards keeping it a button, but making it a link would be acceptable.

The old-school resets of html forms used to be buttons, but if the current trend is for a link-like object, then fine.

Disinclined to make clicking "Reset filters" close the filter dialog and reload the feed.

I agree. I don't think a new user would expect that outcome.

Thanks for your thoughts. I'd be fine with leaving everything as-is for now.

MPGuy2824 moved this task from Waiting for enwiki deploy to Done on the PageTriage board.