Page MenuHomePhabricator
Create Task
Maniphest T311366

MobileFrontend PHP 8.1 support
Closed, ResolvedPublic
Actions

Description

Deprecated: Return type of MobileFrontend\Features\UserModes::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/wiki/mediawiki/extensions/MobileFrontend/includes/Features/UserModes.php on line 45

Details

SubjectRepoBranchLines +/-
Add return type to UserModes::getIterator()mediawiki/extensions/MobileFrontendREL1_35+2 -1
Add return type to UserModes::getIterator()mediawiki/extensions/MobileFrontendREL1_37+2 -1
MobileCollection: Add return types for inbuild Interfacesmediawiki/extensions/MobileFrontendmaster+2 -2
Add return type to UserModes::getIterator()mediawiki/extensions/MobileFrontendREL1_38+2 -1
Add return type to UserModes::getIterator()mediawiki/extensions/MobileFrontendmaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Jun 26 2022, 8:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2022, 8:11 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.Jun 26 2022, 8:11 PM
gerritbot added a comment.Jun 26 2022, 8:17 PM

Change 808532 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/MobileFrontend@master] Add return type to UserModes::getIterator()

https://gerrit.wikimedia.org/r/808532

gerritbot added a project: Patch-For-Review.Jun 26 2022, 8:17 PM
Reedy added a comment.Jun 26 2022, 10:00 PM

I note fixing this bug probably doesn't make all of MF work with PHP 8.1; but it's the only error I've found so far (this and some others in Remex mean MW mostly doesn't work without a lot of logspam ;))

polishdeveloper added subscribers: Jdlrobson, polishdeveloper.Jun 27 2022, 10:13 AM

Reviewed and merged, @Jdlrobson can you take over?

gerritbot added a comment.Jun 27 2022, 10:28 AM

Change 808532 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Add return type to UserModes::getIterator()

https://gerrit.wikimedia.org/r/808532

Maintenance_bot removed a project: Patch-For-Review.Jun 27 2022, 10:30 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 27 2022, 11:00 AM
Reedy added a comment.Jun 27 2022, 11:53 AM

Thanks!

PHP 8.1 issues seem to be a long tail, and I suspect there'll be a few other fixes needed. Currently waiting on T311367: Implicit conversion from float 11.139 to int loses precision in APCUBagOStuff.php on line 91/T307630: mediawiki/libs/RemexHtml phan issues under 8.1/T308406: RemexHtml should support PHP 8.1 for various more prolific logspam on my dev wiki :)

gerritbot added a comment.Jun 27 2022, 11:54 AM

Change 808441 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/MobileFrontend@REL1_38] Add return type to UserModes::getIterator()

https://gerrit.wikimedia.org/r/808441

gerritbot added a project: Patch-For-Review.Jun 27 2022, 11:54 AM

Change 808442 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/MobileFrontend@REL1_37] Add return type to UserModes::getIterator()

https://gerrit.wikimedia.org/r/808442

gerritbot added a comment.Jun 27 2022, 11:54 AM

Change 808443 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/MobileFrontend@REL1_35] Add return type to UserModes::getIterator()

https://gerrit.wikimedia.org/r/808443

gerritbot added a comment.Jun 27 2022, 12:00 PM

Change 808441 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@REL1_38] Add return type to UserModes::getIterator()

https://gerrit.wikimedia.org/r/808441

Reedy mentioned this in T311400: mwgate-node14-docker failure in MF 1.37/1.35.Jun 27 2022, 12:05 PM
Jdlrobson added a project: Web-Team-Backlog (Needs Prioritization (Tech)).Jun 27 2022, 2:56 PM
Jdlrobson moved this task from Backlog to Future Unplanned on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jun 30 2022, 3:26 PM
gerritbot added a comment.Jul 2 2022, 4:31 PM

Change 810475 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/MobileFrontend@master] MobileCollection: Add return types for inbuild Interfaces

https://gerrit.wikimedia.org/r/810475

gerritbot added a comment.Jul 2 2022, 5:24 PM

Change 810475 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] MobileCollection: Add return types for inbuild Interfaces

https://gerrit.wikimedia.org/r/810475

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.21; 2022-07-18); removed MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jul 12 2022, 12:02 AM
gerritbot added a comment.Aug 31 2022, 8:08 PM

Change 808442 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@REL1_37] Add return type to UserModes::getIterator()

https://gerrit.wikimedia.org/r/808442

gerritbot added a comment.Aug 31 2022, 8:22 PM

Change 808443 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@REL1_35] Add return type to UserModes::getIterator()

https://gerrit.wikimedia.org/r/808443

Jdlrobson closed this task as Resolved.Aug 31 2022, 8:25 PM
Jdlrobson claimed this task.
Jdlrobson closed subtask T312706: Update 1.35 and 1.37 branches for node version update on CI as Resolved.

Unblocked with T312706

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL