Positive test reports by Cindy-the-browser-test-bot should not result in setting Attention to the patch owner
Closed, ResolvedPublic
Actions

Description

Since the last Gerrit release there is a feature[1] to get a attention set on gerrit patch set. In that case the user name is bold and it shows up in the personal dashboard at the top.

jenkins-bot negative reports (-1) are showing up there, but Cindy-the-browser-test-bot positive reports (+1) are also showing there, see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/808538

It is possible to avoid that like jenkins-bot, just giving attention for -1?

May not longer needed, when T185462: Run CirrusSearch integration tests from jenkins gets fixed

[1] https://gerrit-review.googlesource.com/Documentation/user-attention-set.html

Related Objects

Mentioned In: T326995: Request Verified -1/+1 rights for "AW GitLab Bot"
Mentioned Here: T185462: Run CirrusSearch integration tests from jenkins

Event Timeline

Umherirrender created this task.Jun 26 2022, 9:28 PM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptJun 26 2022, 9:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Umherirrender updated the task description. (Show Details)Jun 26 2022, 9:28 PM

After reading the help page, it seems the bot must be part of the "Service Users" group,

it is not at the moment https://gerrit.wikimedia.org/r/admin/groups/d39fe9cefd40ca1a07e372c0d7bd7e72ce2e4a2f,members

I cannot edit that member list, would be nice if someone can add the user there. Thanks.

Gehel triaged this task as Medium priority.Jun 27 2022, 3:30 PM

Gehel added a project: Release-Engineering-Team.

Gehel moved this task from needs triage to Current work on the Discovery-Search board.

Gehel edited projects, added Discovery-Search (Current work); removed Discovery-Search.

bking claimed this task.Jun 27 2022, 3:42 PM

Gehel moved this task from Incoming to Blocked/Waiting on the Discovery-Search (Current work) board.Jun 27 2022, 3:42 PM

Mentioned in SAL (#wikimedia-releng) [2022-06-28T13:39:50Z] <hashar> gerrit: added Cindy-the-browser-test-bot to the Service Users group https://gerrit.wikimedia.org/r/admin/groups/d39fe9cefd40ca1a07e372c0d7bd7e72ce2e4a2f,members | T311370

In T311370#8027846, @Umherirrender wrote:

After reading the help page, it seems the bot must be part of the "Service Users" group,

it is not at the moment https://gerrit.wikimedia.org/r/admin/groups/d39fe9cefd40ca1a07e372c0d7bd7e72ce2e4a2f,members

I cannot edit that member list, would be nice if someone can add the user there. Thanks.

What a great finding! The feature is documented at https://gerrit.wikimedia.org/r/Documentation/user-attention-set.html#bots

Bots

The attention set is meant for human reviews only. Triggering bots and reacting to their results is a different workflow and not in scope of the attention set. Thus members of the Service Users group will never be added to the attention set. And replies by such users will only add the change owner (and uploader) to the attention set, if it comes along with a negative vote.

The Service Users group in Gerrit is owned by Administrators, I have thus made the change (sorry @bking !)

I am assumed that is fixed.

Peachey88 moved this task from Backlog to Resolved on the Gerrit-Privilege-Requests board.Aug 20 2022, 1:11 AM

Umherirrender mentioned this in T326995: Request Verified -1/+1 rights for "AW GitLab Bot".Jan 14 2023, 12:34 PM

Positive test reports by Cindy-the-browser-test-bot should not result in setting Attention to the patch ownerClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Positive test reports by Cindy-the-browser-test-bot should not result in setting Attention to the patch owner
Closed, ResolvedPublic
Actions