Page MenuHomePhabricator
Create Task
Maniphest T311388

Allow assigning each user to a specific php engine by setting a PHP_ENGINE cookie
Closed, ResolvedPublic
Actions

Description

We will do the same thing we did in the past:

  • Extract a seed for each user, store it in a cookie we persist for 60 days
  • Based on that and sampling configuration, decide if we need to set the PHP_ENGINE cookie to a specific value and store it for a week,
  • Check with every request if the PHP_ENGINE cookie should be reset

See a past implementation here https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/508172/5/modules/all/ext.wikimediaEvents.php7.js

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikimediaEventsmaster+6 -3phpEngine: Actually include the phpEngine.js file
mediawiki/extensions/WikimediaEventsmaster+23 -11phpEngine: Add sticky option
mediawiki/extensions/WikimediaEventsmaster+1 -0ext.wikimediaEvents: require() phpEngine module
mediawiki/extensions/WikimediaEventsmaster+51 -6phpEngine: Add the ability to sample users to use php 7.4
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT248925 Make MediaWiki release tarball compatible with PHP 8.0
 ResolvedJdforrester-WMFT300463 Make PHP 8.0 voting on MW master
 ResolvedJdforrester-WMFT313563 Bump lcobucci/jwt & league/uri-components for php8
 ResolvedJdforrester-WMFT313564 Bump onoi/message-reporter in vendor.git to 1.4.2 for php 8 support
 ResolvedJdforrester-WMFT247658 Make Wikimedia Production MediaWiki compatible with PHP 7.4
 Resolved• toanT243590 Fix WikibaseDataModel CI for php 7.4
 ResolvedLucas_Werkmeister_WMDET316923 Restore skipped test in ReferenceListTest.php
 ResolvedJoeT318918 Undeploy patch to use old PHP serialization in PHP 7.4
 ResolvedJdforrester-WMFT264168 Drop PHP 7.2 support from Wikibase master branch, once Wikimedia production is on 7.4
 ResolvedLadsgroupT270740 Drop hacky support for doctrine/dbal class renaming
 InvalidNoneT303505 [S] Remove Deprecated methods "serialize" and "unserialize" after php production upgrade to PHP 7.4
 ResolvedReedyT251043 Cleanup css-sanitizer when it only requires PHP >= 7.4
 OpenNoneT166010 The Great Namespaceization and Reorg
 ResolvedtstarlingT277618 var_dump() on various objects writes gigabytes of data and takes minutes to run
 ResolvedJdforrester-WMFT261872 Drop PHP 7.2 & 7.3 support from MediaWiki master branch, once Wikimedia production is on 7.4
 ResolvedPRODUCTION ERRORLegoktmT293568 PHP Notice: Undefined offset in wikimedia/remex-html when rendering rest.php error page
 ResolvedtstarlingT297667 mysqli/mysqlnd memory leak
 ResolvedJoeT271736 Migrate WMF production from PHP 7.2 to PHP 7.4
 ResolvedKrinkleT311388 Allow assigning each user to a specific php engine by setting a PHP_ENGINE cookie

Event Timeline

Joe created this task.Jun 27 2022, 8:53 AM
Joe added a comment.Jun 27 2022, 9:09 AM

Important detail: we can either split the caches at the varnish layer as we did in the past, or just don't bother and just live with the small amount of breakages we might encounter. I'm open to both options of course.

Joe triaged this task as High priority.Jun 27 2022, 9:09 AM
gerritbot added a comment.Jul 29 2022, 3:17 PM

Change 818481 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[mediawiki/extensions/WikimediaEvents@master] Add the ability to sample users to use php 7.4

https://gerrit.wikimedia.org/r/818481

gerritbot added a project: Patch-For-Review.Jul 29 2022, 3:17 PM
gerritbot added a comment.Aug 12 2022, 11:00 AM

Change 818481 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] phpEngine: Add the ability to sample users to use php 7.4

https://gerrit.wikimedia.org/r/818481

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 12 2022, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 12 2022, 11:29 AM
gerritbot added a comment.Aug 12 2022, 8:30 PM

Change 822682 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/WikimediaEvents@master] phpEngine: Add sticky option

https://gerrit.wikimedia.org/r/822682

gerritbot added a project: Patch-For-Review.Aug 12 2022, 8:30 PM
gerritbot added a comment.Aug 17 2022, 11:44 AM

Change 822682 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] phpEngine: Add sticky option

https://gerrit.wikimedia.org/r/822682

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.26; 2022-08-22); removed MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 17 2022, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 17 2022, 12:30 PM
gerritbot added a comment.Aug 17 2022, 1:22 PM

Change 824204 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/WikimediaEvents@master] phpEngine: Actually include the phpEngine.js file

https://gerrit.wikimedia.org/r/824204

gerritbot added a project: Patch-For-Review.Aug 17 2022, 1:22 PM
gerritbot added a comment.Aug 17 2022, 1:37 PM

Change 824213 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/WikimediaEvents@master] ext.wikimediaEvents: require() phpEngine module

https://gerrit.wikimedia.org/r/824213

gerritbot added a comment.Aug 17 2022, 1:39 PM

Change 824213 abandoned by Phuedx:

[mediawiki/extensions/WikimediaEvents@master] ext.wikimediaEvents: require() phpEngine module

Reason:

See I953140817c7939f8fdc68f7fad70946dd5bf930e

https://gerrit.wikimedia.org/r/824213

gerritbot added a comment.Aug 17 2022, 1:47 PM

Change 824204 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] phpEngine: Actually include the phpEngine.js file

https://gerrit.wikimedia.org/r/824204

Maintenance_bot removed a project: Patch-For-Review.Aug 17 2022, 2:30 PM
Krinkle mentioned this in T271736: Migrate WMF production from PHP 7.2 to PHP 7.4.Aug 19 2022, 12:40 PM
Krinkle closed this task as Resolved.Sep 26 2022, 8:22 PM
Krinkle claimed this task.
Krinkle edited projects, added MediaWiki-extensions-WikimediaEvents, Performance-Team; removed Performance-Team (Radar).
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL