It seems that when we switched the position of these elements we unintentionally lost some of the styling of the siteSub (aka the "From Wikipedia..." tagline):
|margin above tagline (should be 8px)|
|font-size (should be 12.8px)|
This only impacts pages which have article indicators.
- Clear the float of the indicators
- Restore font-size of message to 14px
- Reduce margin-top on .mw-body-subheader to 8px
We should test this change across various namespaces and special/administrative pages to make sure the change doesn't cause any overlapping text.
- There should always be an 8px space between the top of the tagline (#siteSub) element ( e.g. "From Wikipedia, the free encyclopedia") and the toolbar
- Notices such as redirects or breadcrumbs (on subpages) do no overlap with the content, toolbar, or tagline.
- The text of the #contentSub element does not overlap the content or toolbar on history, talk or diff pages.
- Check Wikivoyage, the image banners used widely on that project are inside the #contentSub element. The breadcrumb navigation or image should not overlap the toolbar.
- The top of the VisualEditor toolbar is still flush with the bottom of the article toolbar.
Sign off steps
- When the fix is in the latest train, merge https://github.com/wikimedia/pixel/pull/60 so that future regressions get caught.