Page MenuHomePhabricator

Echo PHP 8.1 support
Closed, ResolvedPublic

Description

Deprecated: Return type of EchoFilteredSequentialIterator::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/wiki/mediawiki/extensions/Echo/includes/iterator/FilteredSequentialIterator.php on line 78

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 808996 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Echo@master] Add return type to EchoFilteredSequentialIterator::getIterator()

https://gerrit.wikimedia.org/r/808996

Change 810135 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Echo@REL1_38] Add return type to EchoFilteredSequentialIterator::getIterator()

https://gerrit.wikimedia.org/r/810135

Change 810136 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Echo@REL1_37] Add return type to EchoFilteredSequentialIterator::getIterator()

https://gerrit.wikimedia.org/r/810136

Change 810137 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Echo@REL1_35] Add return type to EchoFilteredSequentialIterator::getIterator()

https://gerrit.wikimedia.org/r/810137

Change 808996 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Add return type to EchoFilteredSequentialIterator::getIterator()

https://gerrit.wikimedia.org/r/808996

Change 810135 merged by jenkins-bot:

[mediawiki/extensions/Echo@REL1_38] Add return type to EchoFilteredSequentialIterator::getIterator()

https://gerrit.wikimedia.org/r/810135

Change 810136 merged by jenkins-bot:

[mediawiki/extensions/Echo@REL1_37] Add return type to EchoFilteredSequentialIterator::getIterator()

https://gerrit.wikimedia.org/r/810136

Change 810137 merged by jenkins-bot:

[mediawiki/extensions/Echo@REL1_35] Add return type to EchoFilteredSequentialIterator::getIterator()

https://gerrit.wikimedia.org/r/810137

Jdforrester-WMF assigned this task to Reedy.
Jdforrester-WMF subscribed.

Appears fixed.

Change 854583 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Echo@master] Fix PHP 8.1 compatibility issue in ForeignNotifications

https://gerrit.wikimedia.org/r/854583

Change 854583 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Fix PHP 8.1 compatibility issue in ForeignNotifications

https://gerrit.wikimedia.org/r/854583

Change 854596 had a related patch set uploaded (by Reedy; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Echo@REL1_39] Fix PHP 8.1 compatibility issue in ForeignNotifications

https://gerrit.wikimedia.org/r/854596

Change 854596 merged by jenkins-bot:

[mediawiki/extensions/Echo@REL1_39] Fix PHP 8.1 compatibility issue in ForeignNotifications

https://gerrit.wikimedia.org/r/854596