Page MenuHomePhabricator

TypeError: Argument 3 passed to MediaWiki\Page\PageCommandFactory::newRollbackPage() with rollbackEdits.php
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • php /srv/mediawiki/w/maintenance/rollbackEdits.php --wiki=webkinzguidewiki --user=[User] --bot

What happens?:

Processing None...[7ebd169b5791656d124488ab] [no req]   TypeError: Argument 3 passed to MediaWiki\Page\PageCommandFactory::newRollbackPage() must implement interface MediaWiki\User\UserIdentity, string given, called in /srv/mediawiki/w/maintenance/rollbackEdits.php on line 90
Backtrace:
from /srv/mediawiki/w/includes/page/PageCommandFactory.php(319)
#0 /srv/mediawiki/w/maintenance/rollbackEdits.php(90): MediaWiki\Page\PageCommandFactory->newRollbackPage(WikiPage, User, string)
#1 /srv/mediawiki/w/maintenance/doMaintenance.php(114): RollbackEdits->execute()
#2 /srv/mediawiki/w/maintenance/rollbackEdits.php(129): require_once(string)
#3 {main}

What should have happened instead?:
Edits should have been rolled back.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
MediaWiki1.38.1 (2a9470c)
PHP 7.4.28 (fpm-fcgi)
MariaDB 10.5.16-MariaDB

Event Timeline

Change 809090 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] rollbackEdits: Pass user identity to RollbackPage

https://gerrit.wikimedia.org/r/809090

Change 809090 merged by jenkins-bot:

[mediawiki/core@master] rollbackEdits: Pass user identity to RollbackPage

https://gerrit.wikimedia.org/r/809090

Change 809111 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@REL1_38] rollbackEdits: Pass user identity to RollbackPage

https://gerrit.wikimedia.org/r/809111

Change 809112 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@REL1_37] rollbackEdits: Pass user identity to RollbackPage

https://gerrit.wikimedia.org/r/809112

Change 809112 merged by jenkins-bot:

[mediawiki/core@REL1_37] rollbackEdits: Pass user identity to RollbackPage

https://gerrit.wikimedia.org/r/809112

Change 809111 merged by jenkins-bot:

[mediawiki/core@REL1_38] rollbackEdits: Pass user identity to RollbackPage

https://gerrit.wikimedia.org/r/809111

Umherirrender assigned this task to Zabe.