Page MenuHomePhabricator
Create Task
Maniphest T311496

Linter highlight is removed when realtime preview loads
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • enable realtime preview
  • follow an edit link with a valid lintid (e.g. by clicking one of the edit links on Special:LintErrors)

What happens?:
The wikitext editor area loads with the appropriate part of the wikitext pre-selected; then the highlighting disappears when the preview shows up.

What should have happened instead?:
Loading the preview should not affect text selection.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Seen on a Wikimedia wiki in Chrome 102.

Details

SubjectRepoBranchLines +/-
Realtime Preview: track focus via events rather than jQuerymediawiki/extensions/WikiEditormaster+9 -3
Realtime Preview: prevent lose of textarea selection when togglingmediawiki/extensions/WikiEditormaster+11 -0
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Jun 28 2022, 10:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2022, 10:48 AM
gerritbot added a comment.Jun 28 2022, 12:17 PM

Change 809147 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Realtime Preview: prevent lose of textarea selection when toggling

https://gerrit.wikimedia.org/r/809147

gerritbot added a project: Patch-For-Review.Jun 28 2022, 12:17 PM
Samwilson subscribed.Jun 28 2022, 12:17 PM

Good find!

This happens whenever any text is selected in the textarea and the preview pane is toggled on or off.

Samwilson claimed this task.Jun 28 2022, 12:26 PM
Samwilson added a project: Community-Tech (CommTech-Sprint-27).
• NRodriguez subscribed.Jun 28 2022, 2:30 PM

Thanks for acting so quick on this Sam, definitely the right call to move it into sprint

gerritbot added a comment.Jun 29 2022, 12:56 PM

Change 809147 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime Preview: prevent lose of textarea selection when toggling

https://gerrit.wikimedia.org/r/809147

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2022, 1:30 PM
• NRodriguez moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-27) board.Jun 29 2022, 7:16 PM
Samwilson moved this task from In Development 💻 to QA 🐛 on the Community-Tech (CommTech-Sprint-27) board.Jun 30 2022, 3:33 AM
dom_walden subscribed.Jun 30 2022, 6:45 AM

@Samwilson I guess you will also need to fix this bug in CodeMirror? The highlighting still gets removed there when opening/closing RTP.

Samwilson moved this task from QA 🐛 to In Development 💻 on the Community-Tech (CommTech-Sprint-27) board.Jun 30 2022, 6:48 AM

Yes, good point. Moving this back to in-development.

• NRodriguez moved this task from Backlog to 🌟Top Priority on the Realtime Preview board.Jun 30 2022, 5:11 PM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-28); removed Community-Tech (CommTech-Sprint-27).Jul 6 2022, 1:20 PM
• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-28) board.Jul 6 2022, 1:25 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 11 2022, 9:02 PM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-29); removed Community-Tech (CommTech-Sprint-28).Jul 18 2022, 5:34 PM
• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-29) board.Jul 18 2022, 5:38 PM
gerritbot added a comment.Jul 19 2022, 6:51 AM

Change 815203 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Realtime Preview: track focus via events rather than jQuery

https://gerrit.wikimedia.org/r/815203

gerritbot added a project: Patch-For-Review.Jul 19 2022, 6:51 AM
gerritbot added a comment.Jul 20 2022, 6:29 AM

Change 815203 abandoned by Samwilson:

[mediawiki/extensions/WikiEditor@master] Realtime Preview: track focus via events rather than jQuery

Reason:

This is done much more cleanly by MusikAnimal in I377fb3a122cda360e016716e3beb9c34983b8e10

https://gerrit.wikimedia.org/r/815203

Maintenance_bot removed a project: Patch-For-Review.Jul 20 2022, 6:30 AM
Samwilson moved this task from In Development 💻 to QA 🐛 on the Community-Tech (CommTech-Sprint-29) board.Jul 20 2022, 6:31 AM

The fix for T311684 fixes things for CodeMirror with this bug as well.

dom_walden moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-29) board.Jul 22 2022, 2:30 PM

The highlighting is now preserved when the editing page is first opened, and when you open and close the RTP pane.

The editing pane does not always scroll to the highlighted text on Chrome or Safari when opening/closing RTP. Further discussion of this can happen in T311684#8097126.

I tested with and without CodeMirror turned on.

Test environment: https://en.wikipedia.beta.wmflabs.org WikiEditor 0.5.3 (8ae9eff) 16:31, 21 July 2022.
Skins: Vector 2022, Vector 2010, Minerva, Timeless, MonoBook.
Browsers: Firefox 91, Chromium 87, Safari 15.

• NRodriguez closed this task as Resolved.Jul 28 2022, 2:59 PM
• JMcLeod_WMF moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-29) board.Aug 2 2022, 2:55 PM
happy5214 moved this task from Backlog to Closed on the WikiEditor board.Jul 31 2023, 9:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL