Page MenuHomePhabricator

Respect isReadOnly in new template dialog sidebar
Open, LowPublic

Description

Many of the changes we've made don't respect visual editor's read-only handling. Most editable features in VE should be disabled, but some of what we've added doesn't respect this setting:

image.png (475×935 px, 46 KB)

The main use cases for read-only visual editing look slightly funny at the moment, but we aren't causing any security issues, purely a user experience, visual thing.

  • Original language pane in the content translation workflow.
  • Protected pages.
  • Checkboxes must be visible, but disabled.
  • The entire toolbar at the bottom should be hidden, or at least the buttons be disabled.
  • All keyboard shortcuts must be disabled.
  • Unused parameters should all be hidden, with no way to show them.
  • Filters for parameters (search input as well as "hide unused") should never be shown.

Event Timeline

Change 810299 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Add basic support for read-only mode to new remplate dialog

https://gerrit.wikimedia.org/r/810299