Page MenuHomePhabricator

Move code which depends on wfMessage out to core
Closed, ResolvedPublic

Description

Parsoid/SiteConfig.php#L466-475

ImageMap.php#L149-L154

Event Timeline

Arlolra renamed this task from Move code which depends on wfMessage out of core to Move code which depends on wfMessage out to core.Jun 28 2022, 2:56 PM

Change 809299 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@master] Fix a gap in Parsoid SiteConfig

https://gerrit.wikimedia.org/r/809299

Arlolra triaged this task as Medium priority.Jun 30 2022, 6:52 PM
Arlolra moved this task from Needs Triage to Missing Functionality on the Parsoid board.

Change 809299 abandoned by Subramanya Sastry:

[mediawiki/core@master] Fix a gap in Parsoid SiteConfig

Reason:

https://gerrit.wikimedia.org/r/809299

At this point, the only reference to wfMessage is in ImageMap which tries to translate description types in the page content language. So, this doesn't need Parsoid's i18n support. This is best resolved by moving the Parsoid ImageMap implementation into the ImageMap extension repo and directly using wfMessage there.

Sounds right to me. If possible you should use Parser::msg() to ensure that the page context language is set correctly. (This will be part of the Parser base class so you can use it on ParsoidParser as well sooner or later.) See T202481.

Change 959063 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/ImageMap@master] ParsoidImageMap: use wfMessage to localize description types

https://gerrit.wikimedia.org/r/959063

Change 959063 merged by jenkins-bot:

[mediawiki/extensions/ImageMap@master] ParsoidImageMap: use wfMessage to localize description types

https://gerrit.wikimedia.org/r/959063

ssastry moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.