Page MenuHomePhabricator
Create Task
Maniphest T311535

Display error on Special:SimilarEditors when the database is being refreshed
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

This task is spun out from T308649#8010691

Sometimes the service returns the error: "Database refresh in progress" (403)

When this happens, display the message: Something has gone wrong, please try again in a few minutes.

Mockup (don't use the text from the mockup):

Screen Shot 2022-06-03 at 10.36.54 AM.png (850×1 px, 67 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Handle database refresh errormediawiki/extensions/SimilarEditorsmaster+17 -8
Return error type when database refresh error is encounteredmediawiki/services/similar-usersmain+4 -1
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Jun 28 2022, 5:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2022, 5:11 PM
Tchanders attached a referenced file: F35202270: Screen Shot 2022-06-03 at 10.36.54 AM.png. (Show Details)Jun 30 2022, 2:19 PM
Tchanders mentioned this in T311724: Display generic error message on Special:SimilarEditors.Jun 30 2022, 2:22 PM
Tchanders mentioned this in T308649: Investigate: How to implement error handling for similar users api call [8H].
• Prtksxna subscribed.Jul 1 2022, 3:37 AM
Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.Jul 18 2022, 3:40 PM
Tchanders set the point value for this task to 3.Jul 18 2022, 5:18 PM
Tchanders moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.Jul 18 2022, 5:35 PM
Tchanders moved this task from Cards ready for development to AHaT Sprint 12: The Dutch Cap on the Anti-Harassment-Team board.Jul 19 2022, 1:29 PM
Tchanders edited projects, added Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap); removed Anti-Harassment-Team.
Tchanders claimed this task.Jul 27 2022, 12:44 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap) board.
gerritbot added a comment.Jul 27 2022, 2:16 PM

Change 817786 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/services/similar-users@main] Return error key when database refresh error is encountered

https://gerrit.wikimedia.org/r/817786

gerritbot added a project: Patch-For-Review.Jul 27 2022, 2:16 PM
gerritbot added a comment.Jul 27 2022, 2:18 PM

Change 817787 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/SimilarEditors@master] Handle database refresh error

https://gerrit.wikimedia.org/r/817787

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap) board.Jul 27 2022, 2:30 PM
• TThoabala moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap) board.Aug 2 2022, 4:37 PM
gerritbot added a comment.Aug 2 2022, 4:39 PM

Change 817786 merged by jenkins-bot:

[mediawiki/services/similar-users@main] Return error type when database refresh error is encountered

https://gerrit.wikimedia.org/r/817786

Tchanders mentioned this in rMSSU99460bea6d0e: Return error type when database refresh error is encountered.Aug 2 2022, 4:40 PM
ARamirez_WMF edited projects, added Anti-Harassment-Team (AHaT Sprint 13: The Magikarp Hat); removed Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap).Aug 2 2022, 4:59 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment-Team (AHaT Sprint 13: The Magikarp Hat) board.
dom_walden added subscribers: • TThoabala, STran, dom_walden.Aug 5 2022, 11:00 AM
In T311535#8108423, @gerritbot wrote:

Change 817787 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/SimilarEditors@master] Handle database refresh error

https://gerrit.wikimedia.org/r/817787

This one still needs to be merged, @TThoabala @STran?

• TThoabala added a comment.Aug 5 2022, 11:14 AM

This one still needs to be merged, @TThoabala @STran?

@dom_walden sorry I didn't see that it didn't get merged, I have pinged @Tchanders for help. I +2ed it but it looks like it had a jenkins error...

gerritbot added a comment.Aug 5 2022, 2:39 PM

Change 817787 merged by jenkins-bot:

[mediawiki/extensions/SimilarEditors@master] Handle database refresh error

https://gerrit.wikimedia.org/r/817787

Tchanders mentioned this in rESIE7895bfec3776: Handle database refresh error.Aug 5 2022, 2:42 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 5 2022, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 5 2022, 3:30 PM
dom_walden moved this task from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment-Team (AHaT Sprint 13: The Magikarp Hat) board.Aug 8 2022, 8:27 AM

Here is the error when the database is locked:

database_refresh_error.png (432×1 px, 24 KB)

The error is Something has gone wrong, please try again in a few minutes.

I wonder, as we know the database is locked, whether the error message can be more specific?

Niharika closed this task as Resolved.Sep 2 2022, 8:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits