Page MenuHomePhabricator
Create Task
Maniphest T311536

Display some errors returned from Similarusers on Special:SimilarEditors
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Tchanders
Authored By
Tchanders
Jun 28 2022, 5:17 PM
Tags
Referenced Files
F35413047: user-no-edits.png
Aug 9 2022, 10:38 AM
F35413045: user-bot.png
Aug 9 2022, 10:38 AM
F35413042: user-no-account.png
Aug 9 2022, 10:38 AM
F35202270: Screen Shot 2022-06-03 at 10.36.54 AM.png
Jun 28 2022, 5:17 PM
Subscribers
Aklapper
dom_walden
• Prtksxna
Tchanders

Description

This task is spun out from T308649#8010691

Sometimes the service returns the following errors:

  • "User <username> does not appear to have an account in English Wikipedia."
  • "User <username> is a bot and therefore out of scope."
  • "User <username> does not appear to have an account (or edits in scope) in English Wikipedia."

When this happens, display the message to the user.

Mockup (don't use the text from the mockup):

Screen Shot 2022-06-03 at 10.36.54 AM.png (850×1 px, 67 KB)

Details

SubjectRepoBranchLines +/-
Display error messages when a bad target user is enteredmediawiki/extensions/SimilarEditorsmaster+15 -0
Return error types for errors encountered by check_user_textmediawiki/services/similar-usersmain+23 -12
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Jun 28 2022, 5:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2022, 5:17 PM
Tchanders attached a referenced file: F35202270: Screen Shot 2022-06-03 at 10.36.54 AM.png. (Show Details)Jun 30 2022, 2:19 PM
Tchanders mentioned this in T311724: Display generic error message on Special:SimilarEditors.Jun 30 2022, 2:22 PM
Tchanders mentioned this in T308649: Investigate: How to implement error handling for similar users api call [8H].
• Prtksxna subscribed.Jul 1 2022, 3:37 AM
Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Jul 18 2022, 3:39 PM
Tchanders set the point value for this task to 3.Jul 18 2022, 5:20 PM
Tchanders moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.Jul 18 2022, 5:35 PM
Tchanders moved this task from Cards ready for development to AHaT Sprint 12: The Dutch Cap on the Anti-Harassment board.Jul 19 2022, 1:29 PM
Tchanders edited projects, added Anti-Harassment (AHaT Sprint 12: The Dutch Cap); removed Anti-Harassment.
Tchanders claimed this task.Jul 27 2022, 12:41 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 12: The Dutch Cap) board.
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 13: The Magikarp Hat); removed Anti-Harassment (AHaT Sprint 12: The Dutch Cap).Aug 2 2022, 4:58 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 13: The Magikarp Hat) board.
gerritbot added a comment.Aug 2 2022, 5:38 PM

Change 819651 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/services/similar-users@main] Return error types for errors encountered by check_user_text

https://gerrit.wikimedia.org/r/819651

gerritbot added a project: Patch-For-Review.Aug 2 2022, 5:38 PM
gerritbot added a comment.Aug 2 2022, 5:42 PM

Change 819652 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/SimilarEditors@master] Display error messages when a bad target user is entered

https://gerrit.wikimedia.org/r/819652

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 13: The Magikarp Hat) board.Aug 3 2022, 11:55 AM
gerritbot added a comment.Aug 9 2022, 9:00 AM

Change 819651 merged by jenkins-bot:

[mediawiki/services/similar-users@main] Return error types for errors encountered by check_user_text

https://gerrit.wikimedia.org/r/819651

• TThoabala moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 13: The Magikarp Hat) board.Aug 9 2022, 9:01 AM
gerritbot added a comment.Aug 9 2022, 9:18 AM

Change 819652 merged by jenkins-bot:

[mediawiki/extensions/SimilarEditors@master] Display error messages when a bad target user is entered

https://gerrit.wikimedia.org/r/819652

Tchanders mentioned this in rESIE4e543eaa6128: Display error messages when a bad target user is entered.Aug 9 2022, 9:19 AM
Tchanders mentioned this in rMSSU5ea51d3c9f9c: Return error types for errors encountered by check_user_text.Aug 9 2022, 9:24 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 9 2022, 9:30 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 9 2022, 10:00 AM
dom_walden moved this task from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 13: The Magikarp Hat) board.EditedAug 9 2022, 10:38 AM
dom_walden subscribed.

I used mitmproxy (and setting $wgHTTPProxy in LocalSettings.php) to simulate different error conditions being returned by the similar-users service.

  • "User <username> does not appear to have an account in English Wikipedia."

user-no-account.png (291×792 px, 19 KB)

  • "User <username> is a bot and therefore out of scope."

user-bot.png (285×774 px, 17 KB)

  • "User <username> does not appear to have an account (or edits in scope) in English Wikipedia."

user-no-edits.png (294×788 px, 20 KB)

I also retested other error conditions (no results, timeouts, etc.) and successful requests in case of regression.

Test environment:

• Niharika closed this task as Resolved.Sep 2 2022, 8:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL