ApiBase::dieWithError() signature is not directly compatible with ApiUsageException::newWithMessage()
Closed, ResolvedPublicBUG REPORT
Actions

Description

phpunit test failures are happening because the dieWithSignature() defaults to null for the $httpCode argument.

The failure is because null is passed directly to newWithMessage()'s $httpCode is an (not strictly typed) int whose default is 0 and is ultimately passed to the Exception's $code argument which is typed as int.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Pass int to ApiUsageException::newWithMessage()'s $httpCode param	mediawiki/core	REL1_37	+2 -2
Pass int to ApiUsageException::newWithMessage()'s $httpCode param	mediawiki/core	REL1_35	+2 -2
Pass int to ApiUsageException::newWithMessage()'s $httpCode param	mediawiki/core	REL1_38	+2 -2
Pass int to ApiUsageException::newWithMessage()'s $httpCode param	mediawiki/core	master	+2 -2

Customize query in gerrit

Event Timeline

MarkAHershberger created this task.Jun 28 2022, 6:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2022, 6:35 PM

Change 809235 had a related patch set uploaded (by MarkAHershberger; author: MarkAHershberger):

[mediawiki/core@master] Pass int to ApiUsageException::newWithMessage()'s $httpCode param

https://gerrit.wikimedia.org/r/809235

gerritbot added a project: Patch-For-Review.Jun 28 2022, 6:38 PM

Umherirrender added a project: PHP 8.1 support.Jun 28 2022, 7:16 PM

Umherirrender updated the task description. (Show Details)

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.1 support board.Jun 28 2022, 9:47 PM

Reedy added projects: MW-1.38-release, MW-1.37-release, MW-1.35-release.Jun 29 2022, 9:03 AM

Change 809235 merged by jenkins-bot:

[mediawiki/core@master] Pass int to ApiUsageException::newWithMessage()'s $httpCode param

https://gerrit.wikimedia.org/r/809235

Change 809546 had a related patch set uploaded (by Reedy; author: MarkAHershberger):

[mediawiki/core@REL1_38] Pass int to ApiUsageException::newWithMessage()'s $httpCode param

https://gerrit.wikimedia.org/r/809546

Change 809547 had a related patch set uploaded (by Reedy; author: MarkAHershberger):

[mediawiki/core@REL1_37] Pass int to ApiUsageException::newWithMessage()'s $httpCode param

https://gerrit.wikimedia.org/r/809547

Change 809548 had a related patch set uploaded (by Reedy; author: MarkAHershberger):

[mediawiki/core@REL1_35] Pass int to ApiUsageException::newWithMessage()'s $httpCode param

https://gerrit.wikimedia.org/r/809548

Reedy closed this task as Resolved.Jun 29 2022, 9:25 AM

Reedy assigned this task to MarkAHershberger.

Change 809548 merged by jenkins-bot:

[mediawiki/core@REL1_35] Pass int to ApiUsageException::newWithMessage()'s $httpCode param

https://gerrit.wikimedia.org/r/809548

Change 809546 merged by jenkins-bot:

[mediawiki/core@REL1_38] Pass int to ApiUsageException::newWithMessage()'s $httpCode param

https://gerrit.wikimedia.org/r/809546

Change 809547 merged by jenkins-bot:

[mediawiki/core@REL1_37] Pass int to ApiUsageException::newWithMessage()'s $httpCode param

https://gerrit.wikimedia.org/r/809547

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2022, 10:30 AM

ReleaseTaggerBot added projects: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), MW-1.38-notes, MW-1.35-notes, MW-1.37-notes.Jul 11 2022, 9:02 PM

ApiBase::dieWithError() signature is not directly compatible with ApiUsageException::newWithMessage()Closed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

ApiBase::dieWithError() signature is not directly compatible with ApiUsageException::newWithMessage()
Closed, ResolvedPublicBUG REPORT
Actions