| Krinkle | |
| Jun 28 2022, 10:31 PM |
| F35315896: Screen Shot 2022-07-13 at 10.42.07 AM.png | |
| Jul 13 2022, 8:42 AM |
| F35285241: Screenshot 2022-06-28 at 15.34.21.png | |
| Jun 28 2022, 10:34 PM |
| F35285238: Screenshot 2022-06-28 at 15.30.28.png | |
| Jun 28 2022, 10:31 PM |
Example at https://en.wikipedia.beta.wmflabs.org/wiki/User:ESanders_(WMF)/sandbox/data-attr
And in prod at https://test.wikipedia.org/wiki/User:Krinkle/X?useskin=vector-2022
Captured in latest stable Firefox on macOS. The contentSub is overlapping the siteSub.
The sub is hardcoded to 2px height for some reason, so this seems unconditional on presence of indicators. The linked examples don't have indicators, and in one case is a redlink page that doesn't exist and is also affected.
Right yeh these are 2 different but very related issues. (The height is an incorrect approach at trying to counteract margin collapsing and the indicators float is not being cleared, creating a bit of a perfect storm of issues. Will look into it today.
I think we need to replace width: 2px with border-bottom: solid 2px transparent to avoid the margin collapse when #siteSub is hidden and there is no #contentSub. This fixes the overlap too.
Change 809681 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] Fixes Content sub unreadable in Vector 22
Change 809681 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fixes Content sub unreadable in Vector 22
Change 809890 had a related patch set uploaded (by Stang; author: Jdlrobson):
[mediawiki/skins/Vector@wmf/1.39.0-wmf.18] Fixes Content sub unreadable in Vector 22
Change 809890 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.39.0-wmf.18] Fixes Content sub unreadable in Vector 22
Mentioned in SAL (#wikimedia-operations) [2022-06-30T13:25:53Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.18/skins/Vector/resources/skins.vector.styles/layouts/screen.less: a927e6fbf56f031c42737cd9710eb0531bab43e1: Fixes Content sub unreadable in Vector 22 (T311564) (duration: 03m 18s)
All done, resolving:
from https://test.wikipedia.org/wiki/User:Krinkle/X?useskin=vector-2022
