Page MenuHomePhabricator
Create Task
Maniphest T311567

ManualLogEntry::getComment() should always return string
Closed, ResolvedPublicBUG REPORT
Actions

Description

Tests are failing in ManualLogEntry::insert() when getComment() returns null and trim() complains

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
In ManualLogEntry, cast the comment to stringmediawiki/coreREL1_35+1 -1
In ManualLogEntry, cast the comment to stringmediawiki/coreREL1_38+1 -1
ManualLogEntry::getComment() should always return stringmediawiki/coreREL1_37+61 -19
ManualLogEntry::getComment() should always return stringmediawiki/coreREL1_35+150 -5
ManualLogEntry::getComment() should always return stringmediawiki/coreREL1_38+61 -19
ManualLogEntry::getComment() should always return stringmediawiki/coremaster+56 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

MarkAHershberger created this task.Jun 28 2022, 10:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2022, 10:59 PM
gerritbot added a comment.Jun 28 2022, 11:00 PM

Change 809314 had a related patch set uploaded (by MarkAHershberger; author: MarkAHershberger):

[mediawiki/core@master] ManualLogEntry::getComment() should always return string

https://gerrit.wikimedia.org/r/809314

gerritbot added a project: Patch-For-Review.Jun 28 2022, 11:00 PM
Reedy added a parent task: T289926: Fix passing null to non-null param of PHP internal functions in MediaWiki core (PHP 8.1 warning).Jun 28 2022, 11:01 PM
Reedy moved this task from Backlog to MediaWiki core on the PHP 8.1 support board.Jun 28 2022, 11:14 PM
Reedy added a project: MediaWiki-Logevents.Jun 28 2022, 11:25 PM
Reedy added projects: MW-1.35-release, MW-1.37-release, MW-1.38-release.Jun 29 2022, 12:29 AM
Reedy moved this task from Blocker to Not a blocker on the MW-1.35-release board.Jun 29 2022, 12:32 AM
Reedy moved this task from Blocker to Not a blocker on the MW-1.37-release board.
Reedy moved this task from Blocker to Not a blocker on the MW-1.38-release board.Jun 29 2022, 12:35 AM
gerritbot added a comment.Jul 11 2022, 1:03 PM

Change 809314 merged by jenkins-bot:

[mediawiki/core@master] ManualLogEntry::getComment() should always return string

https://gerrit.wikimedia.org/r/809314

Maintenance_bot removed a project: Patch-For-Review.Jul 11 2022, 1:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 7:02 AM
gerritbot added a comment.Jul 16 2022, 1:55 AM

Change 814141 had a related patch set uploaded (by Reedy; author: MarkAHershberger):

[mediawiki/core@REL1_38] ManualLogEntry::getComment() should always return string

https://gerrit.wikimedia.org/r/814141

gerritbot added a project: Patch-For-Review.Jul 16 2022, 1:55 AM

Change 814142 had a related patch set uploaded (by Reedy; author: MarkAHershberger):

[mediawiki/core@REL1_37] ManualLogEntry::getComment() should always return string

https://gerrit.wikimedia.org/r/814142

gerritbot added a comment.Jul 16 2022, 1:57 AM

Change 814143 had a related patch set uploaded (by Reedy; author: MarkAHershberger):

[mediawiki/core@REL1_35] ManualLogEntry::getComment() should always return string

https://gerrit.wikimedia.org/r/814143

gerritbot added a comment.Aug 26 2022, 3:09 PM

Change 814142 merged by jenkins-bot:

[mediawiki/core@REL1_37] ManualLogEntry::getComment() should always return string

https://gerrit.wikimedia.org/r/814142

Nikerabbit subscribed.Aug 26 2022, 3:25 PM

As far as I can tell, the backports will break the Translate extension in the respective release branches per T313608: Marking translations as reviewed fails.

ReleaseTaggerBot added a project: MW-1.37-notes.Aug 26 2022, 4:00 PM
Nikerabbit added a project: MediaWiki Language Extension Bundle.Sep 19 2022, 9:53 AM
Nikerabbit mentioned this in T318079: TypeError: Argument 2 passed to ChangeTagsRevisionList::updateChangeTagsOnAll() must be of the type array, null given, called in /srv/mediawiki/php-1.40.0-wmf.1/includes/specials/SpecialEditTags.php on line 440.
Nikerabbit moved this task from Backlog to 2022.10 on the MediaWiki Language Extension Bundle board.Sep 19 2022, 9:57 AM
gerritbot added a comment.Sep 25 2022, 4:36 PM

Change 814141 abandoned by Reedy:

[mediawiki/core@REL1_38] ManualLogEntry::getComment() should always return string

Reason:

T318040

https://gerrit.wikimedia.org/r/814141

gerritbot added a comment.Sep 25 2022, 4:36 PM

Change 814143 abandoned by Reedy:

[mediawiki/core@REL1_35] ManualLogEntry::getComment() should always return string

Reason:

T318040

https://gerrit.wikimedia.org/r/814143

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2022, 5:30 PM
gerritbot added a comment.Oct 21 2022, 12:51 AM

Change 845093 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@REL1_38] In ManualLogEntry, cast the comment to string

https://gerrit.wikimedia.org/r/845093

gerritbot added a project: Patch-For-Review.Oct 21 2022, 12:51 AM
Bawolff closed this task as Resolved.Oct 21 2022, 11:52 PM
Bawolff assigned this task to Jdforrester-WMF.
Bawolff subscribed.

This was fixed in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/831168 (which got included in master, 1.39 and 1.38, but not 1.37 and earlier)

gerritbot added a comment.Nov 1 2022, 5:07 AM

Change 851015 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/core@REL1_35] In ManualLogEntry, cast the comment to string

https://gerrit.wikimedia.org/r/851015

gerritbot added a comment.Nov 1 2022, 5:16 AM

Change 845093 merged by jenkins-bot:

[mediawiki/core@REL1_38] In ManualLogEntry, cast the comment to string

https://gerrit.wikimedia.org/r/845093

ReleaseTaggerBot added a project: MW-1.38-notes.Nov 1 2022, 6:00 AM
gerritbot added a comment.Nov 1 2022, 1:29 PM

Change 851015 merged by jenkins-bot:

[mediawiki/core@REL1_35] In ManualLogEntry, cast the comment to string

https://gerrit.wikimedia.org/r/851015

ReleaseTaggerBot added a project: MW-1.35-notes.Nov 1 2022, 2:00 PM
Nikerabbit mentioned this in T323791: It's not possible to remove the priority languages altogether.Nov 25 2022, 2:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits