Page MenuHomePhabricator

Erroneous message showing in template section during translation
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Start the Section translation for the article "Lekpande" from english to igbo
  • After the title section click next
  • In the map section observed the message displayed in the attachment

What happens?:
Erroneous message showing in template section during translation

What should have happened instead?:
The appropriate message for the right data should be displayed

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Google Chrome

Further investigation of the console yields the error in the attachment for the console log

Screen Shot 2022-06-29 at 12.21.12 AM.png (847×1 px, 241 KB)

Screen Shot 2022-06-29 at 12.13.36 AM.png (807×407 px, 182 KB)

Event Timeline

Notes for implementation: The issue appears inside the header of the block template adaptation card (which is implemented in the BlockTemplateAdaptationCard.vue Single File Component). Basically we want to strip the HTML comments from the returned value of the sourceTemplateName computed variable inside that component.

Change 829810 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/ContentTranslation@master] Strip HTML comments from source template name

https://gerrit.wikimedia.org/r/829810

Change 829810 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Strip HTML comments from source name of block templates

https://gerrit.wikimedia.org/r/829810

Change 837265 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20221003

https://gerrit.wikimedia.org/r/837265

@Wangombe

I see that this is not fixed yet .. your changes have been merged ?

if you have then it seems the changes did not fix the issue so we can move this task back to in-progress

Screen Shot 2022-10-04 at 11.14.31 AM.png (760×1 px, 361 KB)

Screen Shot 2022-10-04 at 11.14.44 AM.png (756×644 px, 157 KB)

Change 838865 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/ContentTranslation@master] Remove ? from regex that matches HTML comments

https://gerrit.wikimedia.org/r/838865

@EChukwukere-WMF the fix for this task has not yet been deployed to production, and that is the reason you are still able to reproduce the issue. Moving the ticket to "Recheck after deployment" column, until the fix is properly deployed.

Change 838865 abandoned by Wangombe:

[mediawiki/extensions/ContentTranslation@master] Remove ? from regex that matches HTML comments

Reason:

https://gerrit.wikimedia.org/r/838865

Testing status: QA PASS

See testing video