Page MenuHomePhabricator

Legacy section=new hint may overlap with floating boxes
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce

  1. Find a talk page that contains little or no unarchived discussion but has an archive box. E.g. https://en.wikipedia.org/wiki/User_talk:Kanashimi
  2. Run the following in the console to trigger the new topic tool hint (T293962): mw.config.set('wgUserEditCount', 501); mw.user.options.set('discussiontools-newtopictool-opened', false);
  3. Open the new topic tool.

Actual result

  1. The hint overlaps the archive box.

Screenshot 2022-06-29 at 10-47-50 User talk Kanashimi - Wikipedia.png (1,120×632 px, 56 KB)

Expected result

  1. The hint doesn't overlap with the archive box

Event Timeline

Esanders updated the task description. (Show Details)

Change 809574 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Add clear:both to new topic hint

https://gerrit.wikimedia.org/r/809574

Change 809574 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] New topic hint: Add clear:both

https://gerrit.wikimedia.org/r/809574

Change 809690 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[mediawiki/extensions/DiscussionTools@wmf/1.39.0-wmf.17] New topic hint: Add clear:both

https://gerrit.wikimedia.org/r/809690

Change 809691 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[mediawiki/extensions/DiscussionTools@wmf/1.39.0-wmf.18] New topic hint: Add clear:both

https://gerrit.wikimedia.org/r/809691

I'm planning to backport T311665, so I thought we might backport this as well, since it's in a similar area.

If no one complained about it for months, it probably happens rarely enough that it could wait until next week, but if it’s easier for you to backport both, it’s no problem of course.

Change 809690 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.39.0-wmf.17] New topic hint: Add clear:both

https://gerrit.wikimedia.org/r/809690

Change 809691 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.39.0-wmf.18] New topic hint: Add clear:both

https://gerrit.wikimedia.org/r/809691

Mentioned in SAL (#wikimedia-operations) [2022-06-29T21:37:51Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.17/extensions/DiscussionTools/modules/dt.ui.NewTopicController.less: Backport: [[gerrit:809690|New topic hint: Add clear:both (T311597)]] (duration: 03m 24s)

Mentioned in SAL (#wikimedia-operations) [2022-06-29T21:41:37Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.18/extensions/DiscussionTools/modules/dt.ui.NewTopicController.less: Backport: [[gerrit:809691|New topic hint: Add clear:both (T311597)]] (duration: 03m 27s)

EAkinloose subscribed.

The hint doesn't overlap with the archive box as expected. See

Screenshot 2022-06-29 at 23.02.25.png (1,994×1,078 px, 269 KB)

ppelberg claimed this task.