Page MenuHomePhabricator
Create Task
Maniphest T311627

Add chat group links in event details pop-up
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Daimona
Authored By
ifried
Jun 29 2022, 1:23 PM
Tags
Referenced Files
F35525934: Screen Shot 2022-09-20 at 10.17.22 AM.png
Sep 20 2022, 2:18 PM
F35501945: Screen Shot 2022-08-31 at 2.06.02 PM.png
Aug 31 2022, 7:19 PM
F35501880: Screen Recording 2022-08-31 at 1.49.49 PM.mov-04FA4881-6D31-4ACA-901E-0C2FAE020A87.gif
Aug 31 2022, 7:19 PM
F35501865: Screen Shot 2022-08-31 at 1.47.48 PM.png
Aug 31 2022, 7:19 PM
F35501495: Screen Shot 2022-08-31 at 11.25.32 AM.png
Aug 31 2022, 7:19 PM
F35489947: Screenshot 2022-08-25 at 17.43.10.png
Aug 25 2022, 4:47 PM
F35489682: Screenshot 2022-08-25 at 12.29.15.png
Aug 25 2022, 11:36 AM
F35487463: Screen Shot 2022-08-24 at 8.06.36 AM.png
Aug 24 2022, 12:08 PM
View All 9 Files
Subscribers
Aklapper
gonyeahialam
ifried
vaughnwalters

Description

As an event participant, I want to see the link to the chat group in 'More Details,' so I can easily access the information in the modal without needing to go to the EventDetails page.

Background: The chat group link is currently only viewable to participants in EventDetails (but not in 'More Details'). We should make it viewable in 'More Details' as well.

Acceptance Criteria:

  • Display link to chat group to users (if they have registered as participants or if they are organizers) below 'Location' information in 'more details' pop-up
  • The chat group information should be displayed in the same format/structure as it is displayed in EventDetails
  • Chat group links should only be displayed to participants after someone registers for event

Visual examples of current behavior:

I don't see chat link as a participant on More Details:

Screen Shot 2022-08-24 at 8.06.20 AM.png (800×1 px, 107 KB)

I see chat link as a participant in EventDetails:

Screen Shot 2022-08-24 at 8.06.36 AM.png (852×1 px, 149 KB)

Visual examples of proposed behavior:

Screenshot 2022-08-25 at 17.43.10.png (1×3 px, 663 KB)

Details

SubjectRepoBranchLines +/-
Show group chat invite link in the "more details" dialogmediawiki/extensions/CampaignEventsmaster+41 -0
Customize query in gerrit

Related Objects

Event Timeline

ifried created this task.Jun 29 2022, 1:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2022, 1:23 PM
ifried added projects: Campaign-Tools, CampaignEvents.Jun 29 2022, 1:24 PM
• vyuen moved this task from V0 to V1 (MVP) on the Campaign-Registration board.Aug 24 2022, 11:15 AM
ifried updated the task description. (Show Details)Aug 24 2022, 12:06 PM
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)Aug 24 2022, 12:08 PM
ifried updated the task description. (Show Details)
ifried added a subscriber: gonyeahialam.Aug 24 2022, 12:12 PM

@gonyeahialam Hello! Is there an updated design/image we could use for this ticket? Thank you!

ifried renamed this task from Add chat group links in event details pop-up [VO or V1] to Add chat group links in event details pop-up.Aug 24 2022, 12:21 PM
ifried updated the task description. (Show Details)Aug 24 2022, 1:07 PM
gonyeahialam updated the task description. (Show Details)Aug 25 2022, 11:36 AM
gonyeahialam updated the task description. (Show Details)
ldelench_wmf triaged this task as High priority.Aug 25 2022, 4:32 PM
ldelench_wmf set the point value for this task to 3.
ldelench_wmf edited projects, added Campaign-Tools (Campaign-Tools-Current-Sprint); removed Campaign-Tools.
gonyeahialam updated the task description. (Show Details)Aug 25 2022, 4:47 PM
Daimona claimed this task.Aug 26 2022, 5:30 PM
gerritbot added a comment.Aug 26 2022, 5:47 PM

Change 826896 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Show group chat invite link in the "more details" dialog

https://gerrit.wikimedia.org/r/826896

gerritbot added a project: Patch-For-Review.Aug 26 2022, 5:47 PM
Daimona moved this task from Needs Input / Design in progress to Code Review on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Aug 26 2022, 5:47 PM
ldelench_wmf moved this task from V1 (MVP) to Darkship on the Campaign-Registration board.Aug 26 2022, 7:54 PM
• vyuen moved this task from Darkship to V1 (MVP) on the Campaign-Registration board.Aug 29 2022, 4:00 PM
gerritbot added a comment.Aug 31 2022, 11:42 AM

Change 826896 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Show group chat invite link in the "more details" dialog

https://gerrit.wikimedia.org/r/826896

Daimona mentioned this in rUCAM780a642ac919: Show group chat invite link in the "more details" dialog.Aug 31 2022, 11:43 AM
Daimona moved this task from Code Review to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Aug 31 2022, 11:45 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.28; 2022-09-05).Aug 31 2022, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 31 2022, 12:30 PM
vaughnwalters subscribed.EditedAug 31 2022, 7:19 PM
  • Display link to chat group to users (if they have registered as participants or if they are organizers) below 'Location' information in 'more details' pop-up

Participant:

Screen Shot 2022-08-31 at 11.25.32 AM.png (1×1 px, 652 KB)

Organizer (same view as participant):
Screen Shot 2022-08-31 at 1.47.48 PM.png (1×1 px, 646 KB)

  • Chat group links should only be displayed to participants after someone registers for event

Screen Recording 2022-08-31 at 1.49.49 PM.mov-04FA4881-6D31-4ACA-901E-0C2FAE020A87.gif (350×720 px, 723 KB)

  • The chat group information should be displayed in the same format/structure as it is displayed in EventDetails

@Daimona this structure is slightly different. Tagging @gonyeahialam for thoughts. See differences below.

In EventDetails the text is:
Chat group invite link

In more details modal the text is:
Join event chat group

The icons are also different and placed differently as seen below:

EventDetails page:

Screen Shot 2022-08-31 at 2.06.02 PM.png (988×1 px, 359 KB)

More details popup:

Screen Shot 2022-08-31 at 11.25.32 AM.png (1×1 px, 652 KB)

Also the Join event chat group link is underlined in the comp but it is not in the build. I assume this is fine because it is underlined on hover like other links in the extension, but just noting it here.

Daimona added a comment.Aug 31 2022, 8:08 PM
In T311627#8203962, @vaughnwalters wrote:

@Daimona this structure is slightly different.

Thanks for pointing this out. I mostly implemented what was in the prototype, so if that's different from what we have in Special:EventDetails, I'm guessing that the AC is wrong.

vaughnwalters moved this task from QA 🐛 to Design Sign-Off 🖌️ on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Aug 31 2022, 8:18 PM
In T311627#8204114, @Daimona wrote:
In T311627#8203962, @vaughnwalters wrote:

@Daimona this structure is slightly different.

Thanks for pointing this out. I mostly implemented what was in the prototype, so if that's different from what we have in Special:EventDetails, I'm guessing that the AC is wrong.

I thought that might be the case. I'll move this to design sign off to make sure, and then we can change the AC as needed.

gonyeahialam added a comment.Sep 2 2022, 11:04 AM

The chat group information should be displayed in the same format/structure as it is displayed in EventDetails

@vaughnwalters we can remove the above as an acceptance criterion. I will update the design of EventDetails in T316606.

gonyeahialam moved this task from Design Sign-Off 🖌️ to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Sep 8 2022, 3:50 PM
ifried closed this task as Resolved.Sep 20 2022, 2:18 PM
ifried moved this task from Product sign-off 🤘 to Done 🏁 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.

I now see the chat group link in 'more details' (see screenshot example below), so I'm marking this as Done.

Screen Shot 2022-09-20 at 10.17.22 AM.png (728×1 px, 78 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL