Page MenuHomePhabricator
Create Task
Maniphest T311663

Why is the subscribe button in a completely different location for RTL vs LTR?
Closed, ResolvedPublic
Actions

Description

From the Arabic Beta Cluster, with the UI language set to English vs Arabic:

Screen Shot 2022-06-29 at 11.30.08 AM.png (252×1 px, 40 KB)

Screen Shot 2022-06-29 at 11.30.24 AM.png (298×1 px, 37 KB)

I think it's unlikely that all the buttons are meant to be cheek-by-jowl in one language, but when you switch languages, one of the buttons goes flying all the way across the page. Presumably the locations should be comparable.

Details

SubjectRepoBranchLines +/-
Use interface language direction for topic metadata wrappermediawiki/extensions/DiscussionToolsmaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Jun 29 2022, 6:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2022, 6:35 PM
• Whatamidoing-WMF attached a referenced file: F35287162: Screen Shot 2022-06-29 at 11.30.24 AM.png. (Show Details)Jun 29 2022, 7:06 PM
• Whatamidoing-WMF attached a referenced file: F35287157: Screen Shot 2022-06-29 at 11.30.08 AM.png. (Show Details)
Aklapper added a project: RTL.Jun 29 2022, 9:04 PM
Restricted Application added a project: I18n. · View Herald TranscriptJun 29 2022, 9:04 PM
matmarex mentioned this in T305286: Metadata within topic containers gets jumbled when switching between languages .Jun 30 2022, 12:29 AM
gerritbot added a comment.Jun 30 2022, 12:37 AM

Change 809728 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Use interface language direction for topic metadata wrapper

https://gerrit.wikimedia.org/r/809728

gerritbot added a project: Patch-For-Review.Jun 30 2022, 12:37 AM
matmarex claimed this task.Jun 30 2022, 12:37 AM
matmarex subscribed.

(There's some more interesting discussion about different approaches to this at T305286.)

matmarex added a project: Editing-team (Kanban Board).Jun 30 2022, 12:37 AM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
matmarex moved this task from Backlog to Triaged on the DiscussionTools board.Jun 30 2022, 3:52 PM
gerritbot added a comment.Jun 30 2022, 5:38 PM

Change 809728 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use interface language direction for topic metadata wrapper

https://gerrit.wikimedia.org/r/809728

Maintenance_bot removed a project: Patch-For-Review.Jun 30 2022, 6:29 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jun 30 2022, 7:26 PM
matmarex added a project: Editing QA.
Ryasmeen edited projects, added Verified; removed Editing QA.Jul 5 2022, 7:52 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
• ppelberg closed this task as Resolved.Jul 8 2022, 12:44 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 11 2022, 11:02 PM
• ppelberg mentioned this in T315037: "subscribe" button is on the wrong side when heading and content are marked up in reverse directionality.Aug 25 2022, 3:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL