Page MenuHomePhabricator
Create Task
Maniphest T311724

Display generic error message on Special:SimilarEditors
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

This task is spun out from T308649#8010691

If the Similarusers service returns errors other than those specified in T311535 and T311536, display a generic error message:

Something has gone wrong, we’re looking into it. If the problem persists please reach out to us here.

Mockup (don't use the text from the mockup):

Screen Shot 2022-06-03 at 10.36.54 AM.png (850×1 px, 67 KB)

Notes

  • The error message should be translateable
  • As part of this task, we need to figure out how to know which message the service has returned
  • We will probably need to update the service too

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Return empty array from client if there are no resultsmediawiki/extensions/SimilarEditorsmaster+21 -2
Show a generic error if the Similarusers service doesn't return good resultsmediawiki/extensions/SimilarEditorsmaster+122 -28
Replace calls to flask.abort with flask.jsonifymediawiki/services/similar-usersmain+3 -4
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Jun 30 2022, 2:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 30 2022, 2:22 PM
Tchanders attached a referenced file: F35202270: Screen Shot 2022-06-03 at 10.36.54 AM.png. (Show Details)Jun 30 2022, 2:22 PM
Tchanders mentioned this in T308649: Investigate: How to implement error handling for similar users api call [8H].
• Prtksxna subscribed.Jul 1 2022, 3:37 AM
Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.Jul 18 2022, 3:39 PM
Tchanders updated the task description. (Show Details)Jul 18 2022, 5:18 PM
Tchanders set the point value for this task to 5.
Tchanders moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.Jul 18 2022, 5:35 PM
Tchanders moved this task from Cards ready for development to AHaT Sprint 12: The Dutch Cap on the Anti-Harassment-Team board.Jul 19 2022, 1:29 PM
Tchanders edited projects, added Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap); removed Anti-Harassment-Team.
Tchanders claimed this task.Jul 20 2022, 10:05 AM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap) board.
gerritbot added a comment.Jul 25 2022, 2:35 PM

Change 816794 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/services/similar-users@main] Replace calls to flask.abort with flask.jsonify

https://gerrit.wikimedia.org/r/816794

gerritbot added a project: Patch-For-Review.Jul 25 2022, 2:35 PM
gerritbot added a comment.Jul 26 2022, 3:21 PM

Change 817290 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/SimilarEditors@master] WIP Show a generic error if the Similarusers service doesn't return good results

https://gerrit.wikimedia.org/r/817290

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap) board.Jul 26 2022, 6:03 PM
gerritbot added a comment.Jul 28 2022, 4:12 PM

Change 816794 merged by jenkins-bot:

[mediawiki/services/similar-users@main] Replace calls to flask.abort with flask.jsonify

https://gerrit.wikimedia.org/r/816794

Tchanders mentioned this in rMSSUebfbc0c46833: Replace calls to flask.abort with flask.jsonify.Jul 28 2022, 4:15 PM
gerritbot added a comment.Jul 29 2022, 1:12 PM

Change 817290 merged by jenkins-bot:

[mediawiki/extensions/SimilarEditors@master] Show a generic error if the Similarusers service doesn't return good results

https://gerrit.wikimedia.org/r/817290

Tchanders mentioned this in rESIE5de407fad937: Show a generic error if the Similarusers service doesn't return good results.Jul 29 2022, 1:14 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 29 2022, 1:30 PM
• TThoabala moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap) board.Jul 29 2022, 1:47 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Jul 29 2022, 2:00 PM
dom_walden subscribed.Aug 1 2022, 10:41 AM

The error message in the task description is:

Something has gone wrong, we’re looking into it. If the problem persists please reach out to us here.

But the error message in the software is:

Something has gone wrong, we’re looking into it.

@Tchanders @Prtksxna Is that OK?

Tchanders mentioned this in T314287: Add help link for SimilarEditors error.Aug 1 2022, 12:00 PM
dom_walden added a comment.Aug 1 2022, 12:24 PM

@Tchanders We also show the error message when there are no results for a user, e.g. Special:SimilarEditors?wpTarget=B2Belgium.

Before, we showed There are no results (as per T310491).

Tchanders added a comment.Aug 1 2022, 1:04 PM
In T311724#8118812, @dom_walden wrote:

The error message in the task description is:

Something has gone wrong, we’re looking into it. If the problem persists please reach out to us here.

But the error message in the software is:

Something has gone wrong, we’re looking into it.

@Tchanders @Prtksxna Is that OK?

Oh yes - I was thinking we should add the link for reaching out to us via WikimediaMessages. Filed as: T314287

In T311724#8119102, @dom_walden wrote:

@Tchanders We also show the error message when there are no results for a user, e.g. Special:SimilarEditors?wpTarget=B2Belgium.

Before, we showed There are no results (as per T310491).

This is a bug - will fix. Thanks @dom_walden

Tchanders moved this task from QA/Testing 🐞 to In Progress 💪 on the Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap) board.Aug 1 2022, 1:04 PM
gerritbot added a comment.Aug 1 2022, 5:53 PM

Change 819126 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/SimilarEditors@master] Return empty array from client if there are no results

https://gerrit.wikimedia.org/r/819126

gerritbot added a project: Patch-For-Review.Aug 1 2022, 5:53 PM
Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap) board.Aug 1 2022, 5:54 PM
gerritbot added a comment.Aug 2 2022, 3:03 PM

Change 819126 merged by jenkins-bot:

[mediawiki/extensions/SimilarEditors@master] Return empty array from client if there are no results

https://gerrit.wikimedia.org/r/819126

Tchanders mentioned this in rESIEee5b9bc2683f: Return empty array from client if there are no results.Aug 2 2022, 3:04 PM
• TThoabala moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap) board.Aug 2 2022, 3:08 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 2 2022, 3:30 PM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.25; 2022-08-15); removed MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Aug 2 2022, 4:00 PM
ARamirez_WMF edited projects, added Anti-Harassment-Team (AHaT Sprint 13: The Magikarp Hat); removed Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap).Aug 2 2022, 4:59 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment-Team (AHaT Sprint 13: The Magikarp Hat) board.
dom_walden moved this task from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment-Team (AHaT Sprint 13: The Magikarp Hat) board.Aug 5 2022, 1:17 PM

When we get an error (including a timeout in the service or extension or the user does not exist), we are now showing the error:

Something has gone wrong, we’re looking into it.

Empty results returns:

There are no results.

Test environment:

Niharika closed this task as Resolved.Sep 2 2022, 8:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits