Page MenuHomePhabricator
Create Task
Maniphest T311728

Gracefully handle non-wikitext pages when returning HTML from the page endpoints
Closed, ResolvedPublic
Actions

Description

The v1/(page|revision)/{title}/html endpoints curently get all HTML from ParsoidOutputAccess. ParsoidOutputAccess will fail hard for content models not supported by Parsoid (currently, wikitext and JSON).

For example, the following should not trigger a 500: https://www.wikidata.org/w/rest.php/v1/page/Q3/html.
We should return a 4xx error for now. 415 perhaps.

Note that for now, we just need to avoid a hard crash. Eventually, the endpoints should handle requests for non-wikitext content (or multi-slot pages) gracefully, by using ParserOutputAccess instead of ParsoidOutputAccess if the content model isn't supported by parsoid. See T311648: Allow WikitextContentHandler to use Parsoid for rendering wikitext.

Details

SubjectRepoBranchLines +/-
REST: HTML endpoints should support all content modelsmediawiki/coremaster+50 -167
ParsoidOutputAccess: Mark dummy parser output as non-cacheablemediawiki/coremaster+6 -0
ParsoidOutputAccess: Completely handle unsupported content modelsmediawiki/coremaster+40 -6
parser: Default to ParserOutputAccess if content model not supportedmediawiki/coremaster+36 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel triaged this task as High priority.Jun 30 2022, 2:45 PM
daniel created this task.
daniel moved this task from Unsorted pile to VE Backend pile on the Platform Team Workboards (MW Expedition) board.
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jun 30 2022, 3:36 PM
Arlolra subscribed.Jun 30 2022, 6:24 PM

T308648 is relevant here

Arlolra moved this task from Needs Triage to Missing Functionality on the Parsoid board.Jun 30 2022, 6:24 PM
Eevans unsubscribed.Jul 1 2022, 2:25 PM
gerritbot added a comment.Jul 4 2022, 9:51 AM

Change 810852 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] parser: Default to ParserOutputAccess if content model not supported

https://gerrit.wikimedia.org/r/810852

gerritbot added a project: Patch-For-Review.Jul 4 2022, 9:51 AM
DAlangi_WMF moved this task from VE Backend pile to Doing on the Platform Team Workboards (MW Expedition) board.Jul 13 2022, 9:45 AM
daniel moved this task from Doing to VE Backend pile on the Platform Team Workboards (MW Expedition) board.Jul 27 2022, 10:20 AM
daniel updated the task description. (Show Details)
daniel mentioned this in T308743: PageHTMLHandler: add support for getting fully annotated parsoid HTML..Aug 4 2022, 10:15 AM
daniel updated the task description. (Show Details)Aug 4 2022, 10:23 AM
daniel updated the task description. (Show Details)
Nikki unsubscribed.Aug 5 2022, 8:00 AM
daniel lowered the priority of this task from High to Medium.Sep 5 2022, 9:22 AM
daniel added a subtask: T317018: Make HtmlOutputRendererHelper use ParserOutputAccess.Sep 5 2022, 9:30 AM
daniel moved this task from VE Backend pile to PCS Service Pile on the Platform Team Workboards (MW Expedition) board.Sep 26 2022, 3:38 PM
VirginiaPoundstone moved this task from Incoming to Radar on the API Platform board.Oct 25 2022, 2:53 PM
daniel added a project: RESTBase Sunsetting.Dec 6 2022, 3:15 PM
daniel moved this task from Unsorted to PCS Service Pile on the RESTBase Sunsetting board.Dec 6 2022, 3:17 PM
daniel mentioned this in T324711: UnexpectedValueException: Parsoid does not support content model proofread-index.Dec 7 2022, 9:40 PM
daniel raised the priority of this task from Medium to High.Dec 7 2022, 9:53 PM

Bumping to high per T324711

daniel updated the task description. (Show Details)Dec 8 2022, 6:40 AM
daniel updated the task description. (Show Details)Dec 8 2022, 6:45 AM
daniel lowered the priority of this task from High to Medium.Dec 14 2022, 12:21 PM
gerritbot added a comment.Jan 3 2023, 8:57 PM

Change 810852 abandoned by D3r1ck01:

[mediawiki/core@master] parser: Default to ParserOutputAccess if content model not supported

Reason:

https://gerrit.wikimedia.org/r/810852

daniel raised the priority of this task from Medium to High.Jan 9 2023, 10:02 AM
daniel updated the task description. (Show Details)
Maintenance_bot removed a project: Patch-For-Review.Jan 9 2023, 10:30 AM
gerritbot added a comment.Jan 9 2023, 11:21 AM

Change 877115 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] ParsoidOutputAccess: Completely handle unsupported content models

https://gerrit.wikimedia.org/r/877115

gerritbot added a project: Patch-For-Review.Jan 9 2023, 11:21 AM
gerritbot added a comment.Jan 10 2023, 11:30 AM

Change 877115 merged by jenkins-bot:

[mediawiki/core@master] ParsoidOutputAccess: Completely handle unsupported content models

https://gerrit.wikimedia.org/r/877115

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2023, 11:31 AM
gerritbot added a comment.Jan 10 2023, 11:43 AM

Change 877997 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] ParsoidOutputAccess: Mark dummy parser output as non-cacheable

https://gerrit.wikimedia.org/r/877997

gerritbot added a project: Patch-For-Review.Jan 10 2023, 11:43 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 10 2023, 12:00 PM
gerritbot added a comment.Jan 10 2023, 6:16 PM

Change 877997 merged by jenkins-bot:

[mediawiki/core@master] ParsoidOutputAccess: Mark dummy parser output as non-cacheable

https://gerrit.wikimedia.org/r/877997

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2023, 6:29 PM
daniel closed this task as Resolved.Jan 11 2023, 5:30 PM
daniel updated the task description. (Show Details)
Arlolra added a comment.Jun 16 2023, 12:33 AM

For example, the following should not trigger a 500: https://www.wikidata.org/w/rest.php/v1/page/Q3/html.

It still does, whereas https://www.wikidata.org/api/rest_v1/page/html/Q3 responds with a dummy msg

ssastry reopened subtask T317018: Make HtmlOutputRendererHelper use ParserOutputAccess as Open.Oct 17 2023, 1:45 AM
ssastry removed a subtask: T317018: Make HtmlOutputRendererHelper use ParserOutputAccess.Oct 23 2023, 4:56 PM
daniel mentioned this in T349868: page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages with JSON content.Nov 9 2023, 11:47 AM
daniel mentioned this in T353689: REST HTML endpoint returning 500 for JSON page.Dec 19 2023, 7:02 AM
gerritbot added a comment.Mar 6 2024, 9:06 AM

Change 1009205 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] REST: HTML endpoints should support all content models

https://gerrit.wikimedia.org/r/1009205

gerritbot added a project: Patch-For-Review.Mar 6 2024, 9:06 AM
gerritbot added a comment.Mar 13 2024, 9:57 AM

Change 1009205 merged by jenkins-bot:

[mediawiki/core@master] REST: HTML endpoints should support all content models

https://gerrit.wikimedia.org/r/1009205

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2024, 10:30 AM
daniel added a parent task: T359426: REST: endpoints that return rendered page content should support all content models.Wed, Apr 3, 12:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL