Page MenuHomePhabricator

Hide mobile lede section when DiscussionTools is enabled
Closed, ResolvedPublic

Description

DT disabled the talk page overlay, the result of which is that the lede section is now shown. On many wikis this is fine as MobileFrontend's page-issues feature hides all the content and puts it in a popup, obscurely hidden behind a "About this page" link that doesn't look like a link (example: https://en.m.wikipedia.org/wiki/Talk:Alan_Pardew?dtenable=0 click "Read as wiki page"), but this feature is broken on many wikis, which means lots of "coffee roll" is now shown before you can see topic titles (example: https://fr.m.wikipedia.org/wiki/Discussion:David_Bowie).

Not being able to see the topic titles in the main issue here so I propose the following actions in order of priority:

  1. Hide the lede section when DT is enabled on mobile immediately. This already happens in the MobileFrontend talk overlay. This means that some of this content will not be discoverable on wikis where the page-issues feature doesn't work (e.g. fr.wiki) however they were barely accessible before, and this is better than pushing the actual topics way down the page.
  2. Come up with a way to expose the lede section, hopefully fixing the various issues with the existing page-issues feature (see the "About this page" popup on https://en.m.wikipedia.org/wiki/Talk:Polar_bear for an example of the issues being referred to here).

Event Timeline

Change 810065 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Hide the lede section on mobile when DiscussionTools is enabled

https://gerrit.wikimedia.org/r/810065

New Vector’s table of contents treats the lead section as a special section named Beginning. What about doing the same on talk pages with MobileFrontend (surprisingly it’s a MobileFrontend feature, not Minerva?), putting the lead in a collapsible section? With this done, I think the “About this page” thing can be disabled on talk pages, as it doesn’t really work with complex tmboxes (tmboxes are often much more complex than amboxes)—see for example https://en.m.wikipedia.org/wiki/Talk:History_of_architecture#/issues/all (vs desktop version), the mobile version shows the metadata blob (which is incomprehensible for humans), but doesn’t show the portal link (which may be the most important thing for mobile users who also edit from desktop and use mobile mainly for reading).

putting the lead in a collapsible section?

I think this is one of the possible options for part 2 in the description, although I haven't created a task for it yet. I'm not sure we would use a normal collapsible section, especially as we are re-styling those in the near future, but something you click on to reveal the lede section somewhere.

With this done, I think the “About this page” thing can be disabled on talk pages, as it doesn’t really work with complex tmboxes (tmboxes are often much more complex than amboxes)

I agree we should probably ditch that feature on talk pages once we have a solution to part 2.

Change 810065 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Hide the lede section on mobile when DiscussionTools is enabled

https://gerrit.wikimedia.org/r/810065

This means that some of this content will not be discoverable on wikis where the page-issues feature doesn't work

After https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/810113/1, the lede section becomes visible when "Read as wiki page" is clicked which maintains the status quo.

I don't like this solution. I dislike hiding that content completely (I also dislike what MobileFrontend is doing with the "About this page" section), and I really really dislike that it is forcing us to keep the "Read as wiki page" button in our new design.

Change 811410 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Hide the lede section on mobile when DiscussionTools is enabled (2nd attempt)

https://gerrit.wikimedia.org/r/811410

So the first patch applied this treatment to any page where the reply tool might be available. Unfortunately DiscussionTools is quite permissive and includes all namespaces in $wgExtraSignatureNamespaces, which can be a lot, for example on mediawiki.org it includes the main namespace, so this caused T312177.

What we were trying to do was provide a replacement for Minerva/MobileFrontend's simplified talk page view, which is only enabled in actual talk namespaces (see SkinMinerva::isSimplifiedTalkPageEnabled), so the 2nd attempt of this patch restricts the feature to pages with ns-talk.

putting the lead in a collapsible section?

I think this is one of the possible options for part 2 in the description, although I haven't created a task for it yet.

Here is a task for iterating upon the experience this task introduces: T312309

putting the lead in a collapsible section?

With this done, I think the “About this page” thing can be disabled on talk pages, as it doesn’t really work with complex tmboxes (tmboxes are often much more complex than amboxes)

I agree we should probably ditch that feature on talk pages once we have a solution to part 2.

+1; here is a task for deprecating the About this page feature: T312312.

New Vector’s table of contents treats the lead section as a special section named Beginning. What about doing the same on talk pages with MobileFrontend (surprisingly it’s a MobileFrontend feature, not Minerva?), putting the lead in a collapsible section?

I've added the above to T312309 as a potential approach.

With this done, I think the “About this page” thing can be disabled on talk pages, as it doesn’t really work with complex tmboxes (tmboxes are often much more complex than amboxes)—see for example https://en.m.wikipedia.org/wiki/Talk:History_of_architecture#/issues/all (vs desktop version), the mobile version shows the metadata blob (which is incomprehensible for humans), but doesn’t show the portal link (which may be the most important thing for mobile users who also edit from desktop and use mobile mainly for reading).

@Tacsipacsi, to be doubly clear, would it be accurate for me to understand the the issues you see with the current About this page experience as the following?

  1. The mobile About this page experience arbitrarily excludes / hides content that is otherwise shown on desktop. E.g. notice how links to Portal:Architecture) and Portal:History do NOT appear in Talk:History_of_architecture#/issues/all.
  2. The mobile About this page experience displays content in a way that is difficult for people to read. E.g. notice how dense the text is and the amount of text that is shown. [i]

i.

Change 811410 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Hide the lede section on mobile when DiscussionTools is enabled (2nd attempt)

https://gerrit.wikimedia.org/r/811410

With this done, I think the “About this page” thing can be disabled on talk pages, as it doesn’t really work with complex tmboxes (tmboxes are often much more complex than amboxes)—see for example https://en.m.wikipedia.org/wiki/Talk:History_of_architecture#/issues/all (vs desktop version), the mobile version shows the metadata blob (which is incomprehensible for humans), but doesn’t show the portal link (which may be the most important thing for mobile users who also edit from desktop and use mobile mainly for reading).

@Tacsipacsi, to be doubly clear, would it be accurate for me to understand the the issues you see with the current About this page experience as the following?

  1. The mobile About this page experience arbitrarily excludes / hides content that is otherwise shown on desktop. E.g. notice how links to Portal:Architecture) and Portal:History do NOT appear in Talk:History_of_architecture#/issues/all.

Yes. And actually this is by far not the worst: for example, on https://en.m.wikipedia.org/wiki/Talk:Archaeology#/issues/all in addition to the portal link, the Article milestones section is missing from the article history template, as well as the archive links from the archive template, without which it doesn’t make much sense…

  1. The mobile About this page experience displays content in a way that is difficult for people to read. E.g. notice how dense the text is and the amount of text that is shown. [i]

No, I don’t think it’s unreadably dense. And it’s definitely not what I meant: what I meant is that the About this page experience arbitrarily displays content that is not aimed at humans and is accordingly hidden on desktop. E.g. notice that ArchitectureWikipedia:WikiProject ArchitectureTemplate:WikiProject ArchitectureArchitecture articles appears in the About this page view, even though it doesn’t appear on desktop (it’s hidden using TemplateStyles).

ppelberg claimed this task.

With this done, I think the “About this page” thing can be disabled on talk pages, as it doesn’t really work with complex tmboxes (tmboxes are often much more complex than amboxes)—see for example https://en.m.wikipedia.org/wiki/Talk:History_of_architecture#/issues/all (vs desktop version), the mobile version shows the metadata blob (which is incomprehensible for humans), but doesn’t show the portal link (which may be the most important thing for mobile users who also edit from desktop and use mobile mainly for reading).

@Tacsipacsi, to be doubly clear, would it be accurate for me to understand the the issues you see with the current About this page experience as the following?

  1. The mobile About this page experience arbitrarily excludes / hides content that is otherwise shown on desktop. E.g. notice how links to Portal:Architecture) and Portal:History do NOT appear in Talk:History_of_architecture#/issues/all.

Yes. And actually this is by far not the worst...

Thank you for sharing this additional context, @Tacsipacsi. What you shared here helped me further clarify the requirements in T312309. See: T312309#8109717.