Page MenuHomePhabricator

TimedMediaHandler / MwEmbedSupport's extension setup files define, execute functions
Closed, ResolvedPublic

Description

TimedMediaHandler.php contains this bit:

// Register the Timed Media Handler javascript resources ( MwEmbed modules )
MwEmbedResourceManager::register( 'extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer' );
MwEmbedResourceManager::register( 'extensions/TimedMediaHandler/MwEmbedModules/TimedText' );

which relies on the class being set up and ready to execute via earlier code.

Defining and then using classes & functions in the setup files is dangerous and I think may interfere with HipHop compatibility.


Version: unspecified
Severity: normal

Details

Reference
bz29177

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz29177.
brion created this task.May 27 2011, 11:12 PM

mdale wrote:

fixed in r89246

Gilles moved this task from Untriaged to Done on the Multimedia board.Dec 4 2014, 10:10 AM
Gilles triaged this task as Unbreak Now! priority.
Gilles lowered the priority of this task from Unbreak Now! to Needs Triage.Dec 4 2014, 11:22 AM