Maniphest T311773

[Layout] Deploy title/tab order everywhere (Make it so that the title should always be above tabs)
Closed, ResolvedPublic
Actions

Description

UI CHANGES

This change will result in expected UI changes so will flag problems with Pixel.
Before merging please confirm Pixel reports 31 passed, 47 failed
After merging, we should update LocalSettings.php to reset these changes.

TODO

Check there are no blockers for making this the default
Enable everywhere by removing the configuration flag.
Temporary configuration flag has been removed
Cleanup redundant styles

Sign off steps

Make sure https://www.mediawiki.org/wiki/Reading/Web/Release_timeline/Visual_Changes documents when the change went out.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Followup to 33a6fb6 - remove is-title-above-tabs from template	mediawiki/skins/Vector	master	+1 -1
CSS cleanup: Revise CSS that is no longer needed per FIXME guidelines	mediawiki/skins/Vector	master	+9 -36
Enable title above tabs everywhere	operations/mediawiki-config	master	+1 -14

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T309972 [Goal] prepare desktop improvements project for further deployment
Resolved	ovasileva	T301780 [Epic] Visual design & layout refinements
Resolved	ovasileva	T303549 Move titlebar above toolbar
Resolved	Jdlrobson	T311773 [Layout] Deploy title/tab order everywhere (Make it so that the title should always be above tabs)

Event Timeline

Jdlrobson created this task.Jun 30 2022, 8:56 PM

Jdlrobson triaged this task as High priority.Jun 30 2022, 9:10 PM

Jdlrobson mentioned this in T310054: Deploy new toolbar order to everywhere except desktop improvements group 2 wikis.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.Jun 30 2022, 9:54 PM

@Jdlrobson - just to double-check - in T310054: Deploy new toolbar order to everywhere except desktop improvements group 2 wikis it mentions that this is the deployment ticket for the new order. Do we plan on deploying and removing the config within the same task?

I've clarified the titles.

Jdlrobson moved this task from Incoming to Layout on the Vector 2022 board.Jul 1 2022, 3:26 PM

Change 811339 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable title above tabs everywhere

https://gerrit.wikimedia.org/r/811339

gerritbot added a project: Patch-For-Review.Jul 5 2022, 4:49 PM

Change 811339 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable title above tabs everywhere

https://gerrit.wikimedia.org/r/811339

Mentioned in SAL (#wikimedia-operations) [2022-07-05T21:55:25Z] <ebernhardson@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:811339|Enable title above tabs everywhere (T311773)]] (duration: 03m 23s)

Jdlrobson updated the task description. (Show Details)Jul 5 2022, 9:59 PM

Now this is enabled, before removing this code altogether I suggest leaving this 1-2 days to see if we get any bug reports

Maintenance_bot removed a project: Patch-For-Review.Jul 5 2022, 10:30 PM

Change 811734 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [FIXMEs] Revise CSS that is no longer needed per FIXME guidelines

https://gerrit.wikimedia.org/r/811734

gerritbot added a project: Patch-For-Review.Jul 6 2022, 2:59 PM

Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.Jul 6 2022, 4:40 PM

I'm feeling comfortable with us merging https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/808059 now. In the unlikely event anything pops up we have a week to fix it (there are no deploys next week).

Jdlrobson assigned this task to bwang.Jul 6 2022, 5:50 PM

Rexogamer updated the task description. (Show Details)Jul 6 2022, 7:47 PM

bwang moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.Jul 7 2022, 1:46 PM

Jdlrobson mentioned this in T312186: Page menus are occasional rendered after page header instead of before it.Jul 8 2022, 6:18 PM

Change 811734 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] CSS cleanup: Revise CSS that is no longer needed per FIXME guidelines

https://gerrit.wikimedia.org/r/811734

Jdlrobson moved this task from QA to Code Review on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.Jul 8 2022, 7:21 PM

Jdlrobson updated the task description. (Show Details)

ovasileva added a parent task: T303549: Move titlebar above toolbar.Jul 11 2022, 9:00 AM

ovasileva mentioned this in T312749: Show central notice at full width after grid work.Jul 11 2022, 9:04 AM

Change 811734 merged by jenkins-bot:

[mediawiki/skins/Vector@master] CSS cleanup: Revise CSS that is no longer needed per FIXME guidelines

https://gerrit.wikimedia.org/r/811734

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.Jul 11 2022, 6:18 PM

Jdrewniak claimed this task.Jul 18 2022, 2:40 PM

Jdrewniak added a subscriber: bwang.

Change 814825 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Followup to 33a6fb6 - remove is-title-above-tabs from template

https://gerrit.wikimedia.org/r/814825

@Esanders caught a bug with this task today. It looks like the configuration was removed, but the conditional in the Mustache template wasn't. The above patch address that. @bwang Could you review?