Page MenuHomePhabricator

[Layout] Deploy title/tab order everywhere (Make it so that the title should always be above tabs)
Closed, ResolvedPublic

Description

UI CHANGES

  • This change will result in expected UI changes so will flag problems with Pixel.
  • Before merging please confirm Pixel reports 31 passed, 47 failed
  • After merging, we should update LocalSettings.php to reset these changes.

TODO

  • Check there are no blockers for making this the default
  • Enable everywhere by removing the configuration flag.
  • Temporary configuration flag has been removed
  • Cleanup redundant styles

Sign off steps

Event Timeline

ovasileva renamed this task from [Layout] Make it so that the title should always be above tabs to [Layout] Deploy title/tab order to all pilot wikis (Make it so that the title should always be above tabs).Jul 1 2022, 5:56 AM

@Jdlrobson - just to double-check - in T310054: Deploy new toolbar order to everywhere except desktop improvements group 2 wikis it mentions that this is the deployment ticket for the new order. Do we plan on deploying and removing the config within the same task?

Jdlrobson renamed this task from [Layout] Deploy title/tab order to all pilot wikis (Make it so that the title should always be above tabs) to [Layout] Deploy title/tab order everywhere (Make it so that the title should always be above tabs).Jul 1 2022, 3:09 PM

I've clarified the titles.

Change 811339 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable title above tabs everywhere

https://gerrit.wikimedia.org/r/811339

Change 811339 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable title above tabs everywhere

https://gerrit.wikimedia.org/r/811339

Mentioned in SAL (#wikimedia-operations) [2022-07-05T21:55:25Z] <ebernhardson@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:811339|Enable title above tabs everywhere (T311773)]] (duration: 03m 23s)

Now this is enabled, before removing this code altogether I suggest leaving this 1-2 days to see if we get any bug reports

Change 811734 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [FIXMEs] Revise CSS that is no longer needed per FIXME guidelines

https://gerrit.wikimedia.org/r/811734

I'm feeling comfortable with us merging https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/808059 now. In the unlikely event anything pops up we have a week to fix it (there are no deploys next week).

Change 811734 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] CSS cleanup: Revise CSS that is no longer needed per FIXME guidelines

https://gerrit.wikimedia.org/r/811734

Change 811734 merged by jenkins-bot:

[mediawiki/skins/Vector@master] CSS cleanup: Revise CSS that is no longer needed per FIXME guidelines

https://gerrit.wikimedia.org/r/811734

Change 814825 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Followup to 33a6fb6 - remove is-title-above-tabs from template

https://gerrit.wikimedia.org/r/814825

Jdrewniak added subscribers: Esanders, Jdrewniak.

@Esanders caught a bug with this task today. It looks like the configuration was removed, but the conditional in the Mustache template wasn't. The above patch address that. @bwang Could you review?

Change 814825 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Followup to 33a6fb6 - remove is-title-above-tabs from template

https://gerrit.wikimedia.org/r/814825

cjming reassigned this task from cjming to Jdlrobson.
cjming updated the task description. (Show Details)
cjming added a subscriber: cjming.