Page MenuHomePhabricator

Migrate Database::select usages to SelectQueryBuilder
Open, Needs TriagePublic

Description

After T243051: A query builder for MediaWiki core being done, we should use it which would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc. and would pave the way for further improvements such as T210206.

Note: It's not just select(). selectField(), selectFieldValues(), selectRow(), estimateRowCount(), and selectRowCount() also need to phased out.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+28 -38
mediawiki/coremaster+12 -10
mediawiki/coremaster+34 -53
mediawiki/coremaster+7 -0
mediawiki/coremaster+105 -136
mediawiki/coremaster+115 -75
mediawiki/coremaster+30 -19
mediawiki/coremaster+14 -16
mediawiki/coremaster+8 -8
mediawiki/coremaster+11 -17
mediawiki/coremaster+14 -8
mediawiki/coremaster+16 -20
mediawiki/coremaster+57 -84
mediawiki/coremaster+81 -64
mediawiki/coremaster+6 -8
mediawiki/coremaster+42 -61
mediawiki/coremaster+17 -21
mediawiki/coremaster+36 -40
mediawiki/coremaster+2 -1
mediawiki/coremaster+131 -68
mediawiki/coremaster+33 -52
mediawiki/coremaster+10 -10
mediawiki/coremaster+33 -28
mediawiki/coremaster+5 -6
mediawiki/coremaster+21 -19
mediawiki/coremaster+12 -11
mediawiki/coremaster+46 -36
mediawiki/coremaster+236 -269
mediawiki/coremaster+67 -49
mediawiki/coremaster+11 -10
mediawiki/coremaster+12 -11
mediawiki/coremaster+12 -27
mediawiki/coremaster+13 -0
mediawiki/coremaster+62 -57
mediawiki/coremaster+84 -76
mediawiki/coremaster+18 -0
mediawiki/coremaster+11 -15
mediawiki/coremaster+9 -9
Show related patches Customize query in gerrit

Related Objects

StatusSubtypeAssignedTask
OpenNone
InvalidNone
OpenNone
OpenNone
OpenNone
OpenNone
InvalidNone
ResolvedKrinkle
OpenNone
OpenNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
OpenNone
OpenNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
OpenNone
Resolvedmatmarex
InvalidNone
OpenNone
OpenNone
OpenNone
InvalidNone
DeclinedNone
OpenNone
OpenNone
OpenNone
InvalidNone
ResolvedHasanAkgun_WMDE
InvalidNone
OpenNone
InvalidNone
ResolvedLucas_Werkmeister_WMDE
InvalidNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
Resolvedori
OpenNone
Resolvedhoo
OpenNone
InvalidNone
DuplicateNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
OpenNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenZabe
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
OpenNone
OpenNone
OpenNone
Resolved EJoseph
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedTThoabala
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
OpenNone
ResolvedSbailey
InvalidNone
InvalidNone
InvalidNone
OpenNone
OpenNone
ResolvedSD0001
InvalidNone
OpenNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
OpenNone
InvalidNone
OpenNone
OpenNone
OpenNone
InvalidNone
InvalidNone
OpenNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
OpenNone
Resolvedmatmarex
ResolvedTheDJ
InvalidNone
OpenNone
InvalidNone
InvalidNone
Resolvedmatmarex
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
ResolvedDreamy_Jazz
ResolvedTchanders
ResolvedTThoabala
ResolvedTThoabala
In ProgressScardenasmolinar
OpenNone
OpenNone
InvalidNone
OpenNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
OpenNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
DuplicateNone

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 819115 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] ChangeTags: Improve database query hygine

https://gerrit.wikimedia.org/r/819115

Change 819115 merged by jenkins-bot:

[mediawiki/core@master] ChangeTags: Improve database query hygine

https://gerrit.wikimedia.org/r/819115

Change 818228 merged by jenkins-bot:

[mediawiki/core@master] Use SelectQueryBuilder instead of IDatabase::select()

https://gerrit.wikimedia.org/r/818228

Change 820781 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] PageProps: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/820781

Change 820782 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] externalstore: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/820782

Change 820783 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] SiteStats: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/820783

Change 820802 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] api: Migrate IDatabase::select() to SelectQueryBuilder interface

https://gerrit.wikimedia.org/r/820802

Change 820781 merged by jenkins-bot:

[mediawiki/core@master] PageProps: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/820781

Change 820782 merged by jenkins-bot:

[mediawiki/core@master] externalstore: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/820782

Change 820783 merged by jenkins-bot:

[mediawiki/core@master] SiteStats: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/820783

Change 820802 merged by jenkins-bot:

[mediawiki/core@master] api: Migrate IDatabase::select() to SelectQueryBuilder interface

https://gerrit.wikimedia.org/r/820802

Change 822620 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] watcheditem: Migrate $db->select() and similar to SelectQueryBuilder

https://gerrit.wikimedia.org/r/822620

Change 822620 merged by jenkins-bot:

[mediawiki/core@master] watcheditem: Migrate $db->select() and similar to SelectQueryBuilder

https://gerrit.wikimedia.org/r/822620

Change 824546 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] SqlBagOStuff: Migrate from IDatabase::select to SelectQueryBuilder

https://gerrit.wikimedia.org/r/824546

Change 824546 merged by jenkins-bot:

[mediawiki/core@master] SqlBagOStuff: Migrate from IDatabase::select to SelectQueryBuilder

https://gerrit.wikimedia.org/r/824546

Change 824784 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] parser: Use SelectQueryBuilder instead of IDatabase::select

https://gerrit.wikimedia.org/r/824784

Change 824784 merged by jenkins-bot:

[mediawiki/core@master] parser: Use SelectQueryBuilder instead of IDatabase::select

https://gerrit.wikimedia.org/r/824784

Change 837122 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] RestrictionStore: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/837122

Change 837125 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] ResourceLoader: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/837125

Change 837129 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] SiteStatsInit: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/837129

Change 837122 merged by jenkins-bot:

[mediawiki/core@master] RestrictionStore: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/837122

Change 837125 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/837125

Change 837129 merged by jenkins-bot:

[mediawiki/core@master] SiteStatsInit: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/837129

Change 850457 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] WikiExporter: Migrate to SelectQueryBuilder

https://gerrit.wikimedia.org/r/850457

Change 850458 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] user: Migrate selects in UserGroupManager to SelectQueryBuilder

https://gerrit.wikimedia.org/r/850458

Change 851080 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] RevisionStore: Add support for trnasforming SelectQueryBuilder

https://gerrit.wikimedia.org/r/851080

Change 850457 merged by jenkins-bot:

[mediawiki/core@master] WikiExporter: Migrate to SelectQueryBuilder

https://gerrit.wikimedia.org/r/850457

Change 850458 merged by jenkins-bot:

[mediawiki/core@master] user: Migrate selects in UserGroupManager to SelectQueryBuilder

https://gerrit.wikimedia.org/r/850458

Change 856595 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] rdbms: Remove `@internal` from SelectQueryBuilder constructor

https://gerrit.wikimedia.org/r/856595

Change 856595 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Remove `@internal` from SelectQueryBuilder constructor

https://gerrit.wikimedia.org/r/856595

Change 857486 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] rdbms: Document template SelectQueryBuilder pattern

https://gerrit.wikimedia.org/r/857486

Change 857486 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Document template SelectQueryBuilder pattern

https://gerrit.wikimedia.org/r/857486

Change 858614 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Category: Use SelectQueryBuilder

https://gerrit.wikimedia.org/r/858614

Change 858615 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] CommentStore: Use SelectQueryBuilder

https://gerrit.wikimedia.org/r/858615

Change 858614 merged by jenkins-bot:

[mediawiki/core@master] Category: Use SelectQueryBuilder

https://gerrit.wikimedia.org/r/858614

Change 858615 merged by jenkins-bot:

[mediawiki/core@master] CommentStore: Use SelectQueryBuilder

https://gerrit.wikimedia.org/r/858615

Change 860929 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] auth: Migrate some calls of $db->select() to SelectQueryBuilder

https://gerrit.wikimedia.org/r/860929

Change 860929 merged by jenkins-bot:

[mediawiki/core@master] auth: Migrate some calls of $db->select() to SelectQueryBuilder

https://gerrit.wikimedia.org/r/860929

Change 861360 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] Rest: Use SelectQueryBuilder in LanguageLinksHandler

https://gerrit.wikimedia.org/r/861360

Change 861360 merged by jenkins-bot:

[mediawiki/core@master] Rest: Use SelectQueryBuilder in LanguageLinksHandler

https://gerrit.wikimedia.org/r/861360

Change 861420 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] Use SelectQueryBuilder in BacklinkCache

https://gerrit.wikimedia.org/r/861420

Change 867115 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Rest: Migrate most of db queries to SelectQueryBuilder

https://gerrit.wikimedia.org/r/867115

Change 861420 merged by jenkins-bot:

[mediawiki/core@master] Use SelectQueryBuilder in BacklinkCache

https://gerrit.wikimedia.org/r/861420

Change 867115 merged by jenkins-bot:

[mediawiki/core@master] Rest: Migrate most of db queries to SelectQueryBuilder

https://gerrit.wikimedia.org/r/867115

Change 867525 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] upload: Migrate select queries to SelectQueryBuilder

https://gerrit.wikimedia.org/r/867525

Change 867525 merged by jenkins-bot:

[mediawiki/core@master] upload: Migrate select queries to SelectQueryBuilder

https://gerrit.wikimedia.org/r/867525

Change 868227 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] specials: Migrate queries to SelectQueryBuilder in SpecialActiveUsers

https://gerrit.wikimedia.org/r/868227

Change 868227 merged by jenkins-bot:

[mediawiki/core@master] specials: Migrate queries to SelectQueryBuilder in SpecialActiveUsers

https://gerrit.wikimedia.org/r/868227

Change 868647 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Storage: Migrate NameTableStore to SelectQueryBuilder

https://gerrit.wikimedia.org/r/868647

Change 868648 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] api: Migrate subquery to use SelectQueryBuilder in ApiQueryAllUsers

https://gerrit.wikimedia.org/r/868648

Change 868647 merged by jenkins-bot:

[mediawiki/core@master] Storage: Migrate NameTableStore to SelectQueryBuilder

https://gerrit.wikimedia.org/r/868647

Change 868648 merged by jenkins-bot:

[mediawiki/core@master] api: Migrate subquery to use SelectQueryBuilder in ApiQueryAllUsers

https://gerrit.wikimedia.org/r/868648

Change 869580 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] cache: Migrate queries to SelectQueryBuilder

https://gerrit.wikimedia.org/r/869580

Change 869580 merged by jenkins-bot:

[mediawiki/core@master] cache: Migrate queries to SelectQueryBuilder

https://gerrit.wikimedia.org/r/869580

Change 886346 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Pingback: Migrate select queries to SelectQueryBuilder

https://gerrit.wikimedia.org/r/886346

Change 886346 merged by jenkins-bot:

[mediawiki/core@master] Pingback: Migrate select queries to SelectQueryBuilder

https://gerrit.wikimedia.org/r/886346

Change 891547 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] joqueue: Migrate all IDatabase::select to SelectQueryBuilder

https://gerrit.wikimedia.org/r/891547

Change 891547 merged by jenkins-bot:

[mediawiki/core@master] jobqueue: Migrate all IDatabase::select to SelectQueryBuilder

https://gerrit.wikimedia.org/r/891547

Change 892988 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] ResourceLoader: Switch to use select query builder in WikiModule

https://gerrit.wikimedia.org/r/892988

Change 892988 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Switch to use select query builder in WikiModule

https://gerrit.wikimedia.org/r/892988

Change 908840 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] jobs: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/908840

Change 908840 merged by jenkins-bot:

[mediawiki/core@master] jobs: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/908840

Change 912416 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] SiteStats: Database related clean ups:

https://gerrit.wikimedia.org/r/912416

Change 919882 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] user: Clean up database-related code in UserNamePrefixSearch

https://gerrit.wikimedia.org/r/919882

Change 919882 merged by jenkins-bot:

[mediawiki/core@master] user: Clean up database-related code in UserNamePrefixSearch

https://gerrit.wikimedia.org/r/919882