Page MenuHomePhabricator

Migrate Database::select usages to SelectQueryBuilder
Open, Needs TriagePublic

Description

After T243051: A query builder for MediaWiki core being done, we should use it which would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc. and would pave the way for further improvements such as T210206.

Note: It's not just select(). selectField(), selectFieldValues(), selectRow(), estimateRowCount(), and selectRowCount() also need to phased out.

Related Objects

StatusSubtypeAssignedTask
OpenNone
InvalidNone
OpenNone
OpenNone
OpenNone
OpenNone
InvalidNone
ResolvedKrinkle
OpenNone
OpenNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
OpenNone
OpenNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
OpenNone
OpenNone
InvalidNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
InvalidNone
OpenNone
InvalidNone
OpenNone
InvalidNone
Resolved Lucas_Werkmeister_WMDE
InvalidNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
Resolvedori
OpenNone
OpenNone
OpenNone
InvalidNone
DuplicateNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
OpenNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenZabe
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
OpenNone
OpenNone
OpenNone
OpenEJoseph
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
OpenNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
OpenNone
OpenNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
OpenNone
InvalidNone
OpenNone
OpenNone
OpenNone
InvalidNone
InvalidNone
OpenNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
OpenNone
OpenNone
OpenNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
OpenDreamy_Jazz
OpenNone
OpenNone
OpenNone
InvalidNone
OpenNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
InvalidNone
InvalidNone
OpenNone
OpenNone
InvalidNone
InvalidNone
InvalidNone
OpenNone
DuplicateNone

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Given that not every extension calls the functions that were mentioned in the description of this task, 99 of the subtasks have been closed as invalid. All tasks that have been left open make at least one call to one of these functions.

Change 818228 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] Use SelectQueryBuilder instead of IDatabase::select()

https://gerrit.wikimedia.org/r/818228

Change 819115 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] ChangeTags: Improve database query hygine

https://gerrit.wikimedia.org/r/819115

Change 819115 merged by jenkins-bot:

[mediawiki/core@master] ChangeTags: Improve database query hygine

https://gerrit.wikimedia.org/r/819115

Change 818228 merged by jenkins-bot:

[mediawiki/core@master] Use SelectQueryBuilder instead of IDatabase::select()

https://gerrit.wikimedia.org/r/818228

Change 820781 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] PageProps: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/820781

Change 820782 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] externalstore: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/820782

Change 820783 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] SiteStats: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/820783

Change 820802 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] api: Migrate IDatabase::select() to SelectQueryBuilder interface

https://gerrit.wikimedia.org/r/820802

Change 820781 merged by jenkins-bot:

[mediawiki/core@master] PageProps: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/820781

Change 820782 merged by jenkins-bot:

[mediawiki/core@master] externalstore: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/820782

Change 820783 merged by jenkins-bot:

[mediawiki/core@master] SiteStats: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/820783