Page MenuHomePhabricator
Create Task
Maniphest T311866

Migrate Database::select usages to SelectQueryBuilder (in WMF-deployed extensions)
Open, Needs TriagePublic
Actions

Description

After T243051: A query builder for MediaWiki core being done, we should use it which would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc. and would pave the way for further improvements such as T210206.

Note: It's not just select(). selectField(), selectFieldValues(), selectRow(), estimateRowCount(), and selectRowCount() also need to phased out.

Details

SubjectRepoBranchLines +/-
Migrate Database::select() to SelectQueryBuildermediawiki/coremaster+26 -19
RevisionStore: Add support for transforming SelectQueryBuildermediawiki/coremaster+131 -68
rdbms: Soft-deprecate IDatabase::select() and similar methodsmediawiki/coremaster+13 -0
Migrate several more Database::select calls to SQBmediawiki/coremaster+100 -138
Introduce FileSelectQueryBuildermediawiki/coremaster+376 -398
Migrate last batch of simple Database::select* calls to SQBmediawiki/coremaster+243 -293
Migrate more calls of Database::select* to SelectQueryBuildermediawiki/coremaster+251 -269
tests: Switch to SelectQueryBuilder in Sqlite and PG integration testsmediawiki/coremaster+101 -33
maintenance: Switch simple calls of Database::select to SQBmediawiki/coremaster+449 -459
tests: Migrate Database::select usages to SelectQueryBuildermediawiki/coremaster+66 -43
Title: Switch Database::select calls to SelectQueryBuildermediawiki/coremaster+53 -64
SiteStats: Database related clean upsmediawiki/coremaster+41 -52
Migrate assertSelect() to SelectQueryBuildermediawiki/coremaster+379 -354
Add User::newQueryBuilder()mediawiki/coremaster+65 -77
Add CommentStore::newQueryBuildermediawiki/coremaster+76 -63
specials: Migrate a couple more Database::select* calls to SelectQueryBuildermediawiki/coremaster+46 -52
user: Clean up database-related code in UserNamePrefixSearchmediawiki/coremaster+28 -38
ResourceLoader: Switch to use select query builder in WikiModulemediawiki/coremaster+12 -10
rdbms: Document template SelectQueryBuilder patternmediawiki/coremaster+7 -0
jobs: Migrate Database::select usages to SelectQueryBuildermediawiki/coremaster+105 -136
jobqueue: Migrate all IDatabase::select to SelectQueryBuildermediawiki/coremaster+115 -75
Pingback: Migrate select queries to SelectQueryBuildermediawiki/coremaster+30 -19
cache: Migrate queries to SelectQueryBuildermediawiki/coremaster+14 -16
Storage: Migrate NameTableStore to SelectQueryBuildermediawiki/coremaster+8 -8
api: Migrate subquery to use SelectQueryBuilder in ApiQueryAllUsersmediawiki/coremaster+11 -17
specials: Migrate queries to SelectQueryBuilder in SpecialActiveUsersmediawiki/coremaster+14 -8
upload: Migrate select queries to SelectQueryBuildermediawiki/coremaster+16 -20
Rest: Migrate most of db queries to SelectQueryBuildermediawiki/coremaster+57 -84
Use SelectQueryBuilder in BacklinkCachemediawiki/coremaster+81 -64
Rest: Use SelectQueryBuilder in LanguageLinksHandlermediawiki/coremaster+6 -8
auth: Migrate some calls of $db->select() to SelectQueryBuildermediawiki/coremaster+42 -61
CommentStore: Use SelectQueryBuildermediawiki/coremaster+17 -21
Category: Use SelectQueryBuildermediawiki/coremaster+36 -40
rdbms: Remove `@internal` from SelectQueryBuilder constructormediawiki/coremaster+2 -1
user: Migrate selects in UserGroupManager to SelectQueryBuildermediawiki/coremaster+33 -52
WikiExporter: Migrate to SelectQueryBuildermediawiki/coremaster+10 -10
RestrictionStore: Migrate Database::select usages to SelectQueryBuildermediawiki/coremaster+33 -28
ResourceLoader: Migrate Database::select usages to SelectQueryBuildermediawiki/coremaster+5 -6
SiteStatsInit: Migrate Database::select usages to SelectQueryBuildermediawiki/coremaster+21 -19
parser: Use SelectQueryBuilder instead of IDatabase::selectmediawiki/coremaster+12 -11
SqlBagOStuff: Migrate from IDatabase::select to SelectQueryBuildermediawiki/coremaster+46 -36
watcheditem: Migrate $db->select() and similar to SelectQueryBuildermediawiki/coremaster+236 -269
api: Migrate IDatabase::select() to SelectQueryBuilder interfacemediawiki/coremaster+67 -49
SiteStats: Migrate Database::select usages to SelectQueryBuildermediawiki/coremaster+11 -10
externalstore: Migrate Database::select usages to SelectQueryBuildermediawiki/coremaster+12 -11
PageProps: Migrate Database::select usages to SelectQueryBuildermediawiki/coremaster+12 -27
Use SelectQueryBuilder instead of IDatabase::select()mediawiki/coremaster+62 -57
ChangeTags: Improve database query hyginemediawiki/coremaster+84 -76
rdbms: Add a note encouraging use of SelectQueryBuilder in IDatabase::selectmediawiki/coremaster+18 -0
Category: Migrate to use SelectQueryBuilder in ::getMembersmediawiki/coremaster+11 -15
Use SelectQueryBuilder in OutputPagemediawiki/coremaster+9 -9
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT311866 Migrate Database::select usages to SelectQueryBuilder (in WMF-deployed extensions)
 InvalidNoneT312322 Migrate usage of Database::select to SelectQueryBuilder in ApiFeatureUsage
 Resolvedsguebo_WMFT312323 Migrate usage of Database::select to SelectQueryBuilder in BetaFeatures
 OpenNoneT312324 Migrate usage of Database::select to SelectQueryBuilder in OAuthRateLimiter
 OpenNoneT312325 Migrate usage of Database::select to SelectQueryBuilder in Newsletter
 ResolvedUmherirrenderT312326 Migrate usage of Database::select to SelectQueryBuilder in CreditsSource
 InvalidNoneT312327 Migrate usage of Database::select to SelectQueryBuilder in QuickSurveys
 ResolvedKrinkleT312328 Migrate usage of Database::select to SelectQueryBuilder in NavigationTiming
 ResolvedUmherirrenderT312329 Migrate usage of Database::select to SelectQueryBuilder in GlobalBlocking
 OpenDreamy_JazzT360621 Test and make improvements to the fixGlobalBlockWhitelist.php script
 OpenNoneT312330 Migrate usage of Database::select to SelectQueryBuilder in GrowthExperiments
 InvalidNoneT312331 Migrate usage of Database::select to SelectQueryBuilder in TwoColConflict
 InvalidNoneT312332 Migrate usage of Database::select to SelectQueryBuilder in cldr
 OpenNoneT312333 Migrate usage of Database::select to SelectQueryBuilder in Echo
 InvalidNoneT312334 Migrate usage of Database::select to SelectQueryBuilder in Quiz
 InvalidNoneT312335 Migrate usage of Database::select to SelectQueryBuilder in EventLogging
 InvalidNoneT312336 Migrate usage of Database::select to SelectQueryBuilder in Campaigns
 ResolvedWangombeT312337 Migrate usage of Database::select to SelectQueryBuilder in TranslationNotifications
 OpenNoneT312338 Migrate usage of Database::select to SelectQueryBuilder in Babel
 OpenNoneT312339 Migrate usage of Database::select to SelectQueryBuilder in intersection
 InvalidNoneT312340 Migrate usage of Database::select to SelectQueryBuilder in UniversalLanguageSelector
 InvalidNoneT312341 Migrate usage of Database::select to SelectQueryBuilder in MobileApp
 InvalidNoneT312342 Migrate usage of Database::select to SelectQueryBuilder in Wikisource
 InvalidNoneT312343 Migrate usage of Database::select to SelectQueryBuilder in wikihiero
 InvalidNoneT312344 Migrate usage of Database::select to SelectQueryBuilder in SyntaxHighlight_GeSHi
 InvalidNoneT312345 Migrate usage of Database::select to SelectQueryBuilder in CiteThisPage
 ResolvedUmherirrenderT312346 Migrate usage of Database::select to SelectQueryBuilder in MediaSearch
 ResolvedUmherirrenderT312347 Migrate usage of Database::select to SelectQueryBuilder in AntiSpoof
 ResolvedmatmarexT312348 Migrate usage of Database::select to SelectQueryBuilder in TemplateData
 InvalidNoneT312349 Migrate usage of Database::select to SelectQueryBuilder in WikibaseLexeme
 InvalidNoneT312350 Migrate usage of Database::select to SelectQueryBuilder in TextExtracts
 ResolvedUmherirrenderT312352 Migrate usage of Database::select to SelectQueryBuilder in ImageSuggestions
 InvalidNoneT312353 Migrate usage of Database::select to SelectQueryBuilder in TemplateStyles
 DeclinedNoneT312354 Migrate usage of Database::select to SelectQueryBuilder in EventBus
 InvalidNoneT312355 Migrate usage of Database::select to SelectQueryBuilder in LandingCheck
 ResolvedAtienoT312356 Migrate usage of Database::select to SelectQueryBuilder in BounceHandler
 InvalidNoneT312357 Migrate usage of Database::select to SelectQueryBuilder in CommonsMetadata
 InvalidNoneT312358 Migrate usage of Database::select to SelectQueryBuilder in DismissableSiteNotice
 ResolvedHasanAkgun_WMDET312359 [ES-M1] Migrate usage of Database::select to SelectQueryBuilder in EntitySchema
 InvalidNoneT312360 Migrate usage of Database::select to SelectQueryBuilder in StopForumSpam
 ResolvedLadsgroupT312361 Migrate usage of Database::select to SelectQueryBuilder in Nuke
 InvalidNoneT312362 Migrate usage of Database::select to SelectQueryBuilder in WikimediaBadges
 ResolvedLucas_Werkmeister_WMDET312363 Migrate usage of Database::select to SelectQueryBuilder in WikibaseQualityConstraints
 InvalidNoneT312364 Migrate usage of Database::select to SelectQueryBuilder in Wikistories
 InvalidNoneT312365 Migrate usage of Database::select to SelectQueryBuilder in PageViewInfo
 InvalidNoneT312366 Migrate usage of Database::select to SelectQueryBuilder in CharInsert
 InvalidNoneT312367 Migrate usage of Database::select to SelectQueryBuilder in Popups
 InvalidNoneT312368 Migrate usage of Database::select to SelectQueryBuilder in TheWikipediaLibrary
 OpenNoneT312369 Migrate usage of Database::select to SelectQueryBuilder in CentralNotice
 InvalidNoneT312370 Migrate usage of Database::select to SelectQueryBuilder in timeline
 ResolvedDreamy_JazzT312371 Migrate usage of Database::select to SelectQueryBuilder in MediaModeration
 InvalidNoneT312372 Migrate usage of Database::select to SelectQueryBuilder in ChessBrowser
 InvalidNoneT312373 Migrate usage of Database::select to SelectQueryBuilder in ContactPage
 InvalidNoneT312374 Migrate usage of Database::select to SelectQueryBuilder in FeaturedFeeds
 InvalidNoneT312375 Migrate usage of Database::select to SelectQueryBuilder in SecureLinkFixer
 InvalidNoneT312376 Migrate usage of Database::select to SelectQueryBuilder in TemplateSandbox
 ResolvedoriT312377 Migrate usage of Database::select to SelectQueryBuilder in WikiLambda
 OpenNoneT312378 Migrate usage of Database::select to SelectQueryBuilder in FlaggedRevs
 ResolvedhooT312379 Migrate usage of Database::select to SelectQueryBuilder in Cognate
 ResolvedUmherirrenderT312380 Migrate usage of Database::select to SelectQueryBuilder in GlobalUsage
 InvalidNoneT312381 Migrate usage of Database::select to SelectQueryBuilder in WikidataPageBanner
 DuplicateNoneT312382 Migrate usage of Database::select to SelectQueryBuilder in ApiFeatureUsage
 InvalidNoneT312383 Migrate usage of Database::select to SelectQueryBuilder in GeoCrumbs
 InvalidNoneT312384 Migrate usage of Database::select to SelectQueryBuilder in Josa
 InvalidNoneT312385 Migrate usage of Database::select to SelectQueryBuilder in WikibaseLexemeCirrusSearch
 InvalidNoneT312386 Migrate usage of Database::select to SelectQueryBuilder in ArticleCreationWorkflow
 InvalidNoneT312387 Migrate usage of Database::select to SelectQueryBuilder in ElectronPdfService
 OpenBluDogeT312388 Migrate usage of Database::select to SelectQueryBuilder in GeoData
 OpenNoneT312389 Migrate usage of Database::select to SelectQueryBuilder in GlobalPreferences
 ResolvedUmherirrenderT312390 Migrate usage of Database::select to SelectQueryBuilder in GoogleNewsSitemap
 InvalidNoneT312391 Migrate usage of Database::select to SelectQueryBuilder in WikimediaMessages
 InvalidNoneT312392 Migrate usage of Database::select to SelectQueryBuilder in JsonConfig
 InvalidNoneT312393 Migrate usage of Database::select to SelectQueryBuilder in MassMessage
 OpenZabeT312394 Migrate usage of Database::select to SelectQueryBuilder in CentralAuth
 OpenNoneT312395 Migrate usage of Database::select to SelectQueryBuilder in CategoryTree
 InvalidNoneT312396 Migrate usage of Database::select to SelectQueryBuilder in Insider
 InvalidNoneT312397 Migrate usage of Database::select to SelectQueryBuilder in NearbyPages
 InvalidNoneT312398 Migrate usage of Database::select to SelectQueryBuilder in EventStreamConfig
 ResolvedZabeT312399 Migrate usage of Database::select to SelectQueryBuilder in LoginNotify
 InvalidNoneT312401 Migrate usage of Database::select to SelectQueryBuilder in WikibaseCirrusSearch
 InvalidNoneT312400 Migrate usage of Database::select to SelectQueryBuilder in PdfHandler
 InvalidNoneT312402 Migrate usage of Database::select to SelectQueryBuilder in SearchExtraNS
 InvalidNoneT312403 Migrate usage of Database::select to SelectQueryBuilder in PoolCounter
 InvalidNoneT312404 Migrate usage of Database::select to SelectQueryBuilder in XAnalytics
 InvalidNoneT312405 Migrate usage of Database::select to SelectQueryBuilder in DonationInterface
 InvalidNoneT312406 Migrate usage of Database::select to SelectQueryBuilder in 3D
 InvalidNoneT312407 Migrate usage of Database::select to SelectQueryBuilder in GlobalCssJs
 InvalidNoneT312408 Migrate usage of Database::select to SelectQueryBuilder in TemplateWizard
 ResolvedUmherirrenderT312409 Migrate usage of Database::select to SelectQueryBuilder in Disambiguator
 ResolvedUmherirrenderT312410 Migrate usage of Database::select to SelectQueryBuilder in FileImporter
 InvalidNoneT312411 Migrate usage of Database::select to SelectQueryBuilder in TorBlock
 InvalidNoneT312412 Migrate usage of Database::select to SelectQueryBuilder in UploadsLink
 InvalidNoneT312413 Migrate usage of Database::select to SelectQueryBuilder in Citoid
 InvalidNoneT312414 Migrate usage of Database::select to SelectQueryBuilder in Graph
 ResolvedLadsgroupT312415 Migrate usage of Database::select to SelectQueryBuilder in UrlShortener
 InvalidNoneT312416 Migrate usage of Database::select to SelectQueryBuilder in Cite
 InvalidNoneT312417 Migrate usage of Database::select to SelectQueryBuilder in WebAuthn
 OpenNoneT312418 Migrate usage of Database::select to SelectQueryBuilder in Flow
 ResolvedtaaviT312419 Migrate usage of Database::select to SelectQueryBuilder in OATHAuth
 OpenNoneT312420 Migrate usage of Database::select to SelectQueryBuilder in AbuseFilter
 Resolved• EJosephT312421 Migrate usage of Database::select to SelectQueryBuilder in CirrusSearch
 OpenNoneT312422 Migrate usage of Database::select to SelectQueryBuilder in Translate
 ResolvedUmherirrenderT312423 Migrate usage of Database::select to SelectQueryBuilder in GlobalUserPage
 OpenNoneT312424 Migrate usage of Database::select to SelectQueryBuilder in WikimediaEditorTasks
 OpenNoneT312425 Migrate usage of Database::select to SelectQueryBuilder in Interwiki
 Resolved• TThoabalaT312426 Migrate usage of Database::select to SelectQueryBuilder in IPInfo
 InvalidNoneT312427 Migrate usage of Database::select to SelectQueryBuilder in Poem
 InvalidNoneT312428 Migrate usage of Database::select to SelectQueryBuilder in Listings
 InvalidNoneT312429 Migrate usage of Database::select to SelectQueryBuilder in WikimediaApiPortalOAuth
 OpenNoneT312430 Migrate usage of Database::select to SelectQueryBuilder in LiquidThreads
 InvalidNoneT312431 Migrate usage of Database::select to SelectQueryBuilder in SandboxLink
 InvalidNoneT312432 Migrate usage of Database::select to SelectQueryBuilder in LabeledSectionTransclusion
 InvalidNoneT312433 Migrate usage of Database::select to SelectQueryBuilder in ConfirmEdit
 ResolvedSbaileyT312434 Migrate usage of Database::select to SelectQueryBuilder in Linter
 InvalidNoneT312435 Migrate usage of Database::select to SelectQueryBuilder in MultimediaViewer
 InvalidNoneT312436 Migrate usage of Database::select to SelectQueryBuilder in RevisionSlider
 InvalidNoneT312437 Migrate usage of Database::select to SelectQueryBuilder in CodeMirror
 InvalidNoneT312438 Migrate usage of Database::select to SelectQueryBuilder in SimilarEditors
 DeclinedNoneT312439 Migrate usage of Database::select to SelectQueryBuilder in Math
 ResolvedSD0001T312440 Migrate usage of Database::select to SelectQueryBuilder in Gadgets
 InvalidNoneT312441 Migrate usage of Database::select to SelectQueryBuilder in Scribunto
 ResolvedUmherirrenderT312442 Migrate usage of Database::select to SelectQueryBuilder in LdapAuthentication
 InvalidNoneT312443 Migrate usage of Database::select to SelectQueryBuilder in Capiunto
 InvalidNoneT312444 Migrate usage of Database::select to SelectQueryBuilder in FundraisingTranslateWorkflow
 ResolvedBluDogeT312445 Migrate usage of Database::select to SelectQueryBuilder in ShortUrl
 InvalidNoneT312446 Migrate usage of Database::select to SelectQueryBuilder in CodeEditor
 OpenNoneT312447 Migrate usage of Database::select to SelectQueryBuilder in PageAssessments
 InvalidNoneT312448 Migrate usage of Database::select to SelectQueryBuilder in PagedTiffHandler
 OpenNoneT312449 Migrate usage of Database::select to SelectQueryBuilder in SecurePoll
 DuplicateNoneT312450 Migrate usage of Database::select to SelectQueryBuilder in MobileFrontend
 ResolvedUmherirrenderT312451 Migrate usage of Database::select to SelectQueryBuilder in Collection
 InvalidNoneT312452 Migrate usage of Database::select to SelectQueryBuilder in GlobalWatchlist
 InvalidNoneT312453 Migrate usage of Database::select to SelectQueryBuilder in VipsScaler
 OpenNoneT312454 Migrate usage of Database::select to SelectQueryBuilder in ORES
 OpenNoneT312455 Migrate usage of Database::select to SelectQueryBuilder in PropertySuggester
 InvalidNoneT312456 Migrate usage of Database::select to SelectQueryBuilder in Wikidata.org
 InvalidNoneT312457 Migrate usage of Database::select to SelectQueryBuilder in RSS
 InvalidNoneT312458 Migrate usage of Database::select to SelectQueryBuilder in AdvancedSearch
 InvalidNoneT312459 Migrate usage of Database::select to SelectQueryBuilder in Dashiki
 InvalidNoneT312460 Migrate usage of Database::select to SelectQueryBuilder in GuidedTour
 InvalidNoneT312461 Migrate usage of Database::select to SelectQueryBuilder in WikiLove
 ResolvedLucas_Werkmeister_WMDET312462 Migrate usage of Database::select to SelectQueryBuilder in ArticlePlaceholder
 InvalidNoneT312463 Migrate usage of Database::select to SelectQueryBuilder in GWToolset
 InvalidNoneT312464 Migrate usage of Database::select to SelectQueryBuilder in ExternalGuidance
 ResolvedUmherirrenderT312465 Migrate usage of Database::select to SelectQueryBuilder in SubPageList3
 ResolvedmatmarexT312466 Migrate usage of Database::select to SelectQueryBuilder in DiscussionTools
 ResolvedTheDJT312467 Migrate usage of Database::select to SelectQueryBuilder in TimedMediaHandler
 InvalidNoneT312468 Migrate usage of Database::select to SelectQueryBuilder in Elastica
 ResolvedUmherirrenderT312469 Migrate usage of Database::select to SelectQueryBuilder in SpamBlacklist
 InvalidNoneT312470 Migrate usage of Database::select to SelectQueryBuilder in WikibaseMediaInfo
 InvalidNoneT312471 Migrate usage of Database::select to SelectQueryBuilder in SubpageSortkey
 ResolvedmatmarexT312472 Migrate usage of Database::select to SelectQueryBuilder in VisualEditor
 InvalidNoneT312473 Migrate usage of Database::select to SelectQueryBuilder in NewUserMessage
 InvalidNoneT312474 Migrate usage of Database::select to SelectQueryBuilder in DoubleWiki
 InvalidNoneT312475 Migrate usage of Database::select to SelectQueryBuilder in RelatedArticles
 OpenNoneT312476 Migrate usage of Database::select to SelectQueryBuilder in OAuth
 InvalidNoneT312477 Migrate usage of Database::select to SelectQueryBuilder in WikimediaIncubator
 InvalidNoneT312478 Migrate usage of Database::select to SelectQueryBuilder in FundraiserLandingPage
 ResolvedDreamy_JazzT312479 Migrate usage of Database::select to SelectQueryBuilder in CheckUser
 ResolvedTchandersT316433 Migrate usage of Database::select to SelectQueryBuilder in CheckUser's CompareService
 Resolved• TThoabalaT316434 Migrate usage of Database::select to SelectQueryBuilder in CheckUser's TimelineRowFormatter
 Resolved• TThoabalaT316435 Migrate usage of Database::select to SelectQueryBuilder in CheckUser's PreliminaryCheckService
 ResolvedScardenasmolinarT312480 Migrate usage of Database::select to SelectQueryBuilder in PageTriage
 ResolvedNoneT312481 Migrate usage of Database::select to SelectQueryBuilder in Thanks
 ResolvedAtienoT312482 Migrate usage of Database::select to SelectQueryBuilder in ReadingLists
 InvalidNoneT312483 Migrate usage of Database::select to SelectQueryBuilder in InputBox
 InvalidNoneT312484 Migrate usage of Database::select to SelectQueryBuilder in Renameuser
 InvalidNoneT312486 Migrate usage of Database::select to SelectQueryBuilder in ImageMap
 InvalidNoneT312487 Migrate usage of Database::select to SelectQueryBuilder in InterwikiSorting
 InvalidNoneT312488 Migrate usage of Database::select to SelectQueryBuilder in TrustedXFF
 InvalidNoneT312489 Migrate usage of Database::select to SelectQueryBuilder in SiteMatrix
 InvalidNoneT312490 Migrate usage of Database::select to SelectQueryBuilder in WikimediaEvents
 InvalidNoneT312491 Migrate usage of Database::select to SelectQueryBuilder in ParserFunctions
 InvalidNoneT312492 Migrate usage of Database::select to SelectQueryBuilder in Score
 InvalidNoneT312493 Migrate usage of Database::select to SelectQueryBuilder in OpenStackManager
 OpenNoneT312494 Migrate usage of Database::select to SelectQueryBuilder in ProofreadPage
 InvalidNoneT312495 Migrate usage of Database::select to SelectQueryBuilder in TitleBlacklist
 InvalidNoneT312496 Migrate usage of Database::select to SelectQueryBuilder in ExtensionDistributor
 InvalidNoneT312497 Migrate usage of Database::select to SelectQueryBuilder in MapSources
 OpenNoneT312498 Migrate usage of Database::select to SelectQueryBuilder in ContentTranslation
 InvalidNoneT312499 Migrate usage of Database::select to SelectQueryBuilder in Calendar
 InvalidNoneT312500 Migrate usage of Database::select to SelectQueryBuilder in Kartographer
 OpenUmherirrenderT312501 Migrate usage of Database::select to SelectQueryBuilder in PageImages
 OpenNoneT312502 Migrate usage of Database::select to SelectQueryBuilder in UploadWizard
 InvalidNoneT312503 Migrate usage of Database::select to SelectQueryBuilder in WikiEditor
 InvalidNoneT312504 Migrate usage of Database::select to SelectQueryBuilder in TocTree
 InvalidNoneT312505 Migrate usage of Database::select to SelectQueryBuilder in FileExporter
 ResolvedLucas_Werkmeister_WMDET312510 Migrate usage of Database::select to SelectQueryBuilder in Wikibase
 DuplicateNoneT312515 Migrate usage of Database::select to SelectQueryBuilder in Wikibase
 OpenLadsgroupT344971 Migrate Database::select usages to SelectQueryBuilder in MediaWiki core

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
TheDJ closed subtask T312467: Migrate usage of Database::select to SelectQueryBuilder in TimedMediaHandler as Resolved.Mar 28 2023, 12:21 PM
Sbailey closed subtask T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter as Resolved.Apr 3 2023, 3:11 PM
gerritbot added a comment.Apr 14 2023, 1:10 PM

Change 908840 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] jobs: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/908840

gerritbot added a comment.Apr 14 2023, 4:07 PM

Change 908840 merged by jenkins-bot:

[mediawiki/core@master] jobs: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/908840

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 14 2023, 5:00 PM
Scardenasmolinar changed the status of subtask T312480: Migrate usage of Database::select to SelectQueryBuilder in PageTriage from Open to In Progress.Apr 24 2023, 7:29 PM
gerritbot added a comment.Apr 26 2023, 11:36 PM

Change 912416 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] SiteStats: Database related clean ups:

https://gerrit.wikimedia.org/r/912416

gerritbot added a comment.May 15 2023, 7:30 PM

Change 919882 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] user: Clean up database-related code in UserNamePrefixSearch

https://gerrit.wikimedia.org/r/919882

gerritbot added a comment.May 16 2023, 8:52 AM

Change 919882 merged by jenkins-bot:

[mediawiki/core@master] user: Clean up database-related code in UserNamePrefixSearch

https://gerrit.wikimedia.org/r/919882

TheresNoTime mentioned this in T336964: InvalidArgumentException: Data for lt_namespace and lt_title must be non-empty.May 18 2023, 7:24 PM
gerritbot added a comment.Jun 2 2023, 3:29 PM

Change 926535 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] specials: Migrate a couple more Database::select* calls to SelectQueryBuilder

https://gerrit.wikimedia.org/r/926535

gerritbot added a comment.Jun 5 2023, 9:04 AM

Change 926535 merged by jenkins-bot:

[mediawiki/core@master] specials: Migrate a couple more Database::select* calls to SelectQueryBuilder

https://gerrit.wikimedia.org/r/926535

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.12; 2023-06-06); removed MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Jun 5 2023, 10:00 AM
Lucas_Werkmeister_WMDE closed subtask T312510: Migrate usage of Database::select to SelectQueryBuilder in Wikibase as Resolved.Jun 12 2023, 2:21 PM
Ladsgroup mentioned this in T340065: Migrate Database::delete usages to DeleteQueryBuilder.Jun 21 2023, 8:53 PM
gerritbot added a comment.Jun 26 2023, 6:47 AM

Change 932689 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Add User::newQueryBuilder()

https://gerrit.wikimedia.org/r/932689

gerritbot added a comment.Jun 26 2023, 7:25 AM

Change 932787 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Add CommentStore::newQueryBuilder

https://gerrit.wikimedia.org/r/932787

gerritbot added a comment.Jun 27 2023, 2:04 AM

Change 933207 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Migrate assertSelect() to SelectQueryBuilder

https://gerrit.wikimedia.org/r/933207

gerritbot added a comment.Jun 27 2023, 2:10 AM

Change 932787 abandoned by Tim Starling:

[mediawiki/core@master] Add CommentStore::newQueryBuilder

Reason:

It's not really valid to have a QueryBuilder with a join but no tables -- join() would throw if you tried to make this without using queryInfo()

https://gerrit.wikimedia.org/r/932787

gerritbot added a comment.Jun 27 2023, 9:24 AM

Change 932689 merged by jenkins-bot:

[mediawiki/core@master] Add User::newQueryBuilder()

https://gerrit.wikimedia.org/r/932689

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.16; 2023-07-04); removed MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 27 2023, 10:00 AM
Samwalton9-WMF closed subtask T312480: Migrate usage of Database::select to SelectQueryBuilder in PageTriage as Resolved.Jun 30 2023, 11:32 AM
gerritbot added a comment.Jul 3 2023, 10:52 AM

Change 933207 merged by jenkins-bot:

[mediawiki/core@master] Migrate assertSelect() to SelectQueryBuilder

https://gerrit.wikimedia.org/r/933207

gerritbot added a comment.Jul 4 2023, 2:05 PM

Change 912416 abandoned by Ladsgroup:

[mediawiki/core@master] SiteStats: Database related clean ups

Reason:

I'll do it from the ground up

https://gerrit.wikimedia.org/r/912416

gerritbot added a comment.Jul 14 2023, 3:03 PM

Change 938257 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Title: Switch Database::select calls to SelectQueryBuilder

https://gerrit.wikimedia.org/r/938257

gerritbot added a comment.Jul 14 2023, 3:20 PM

Change 938260 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] tests: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/938260

gerritbot added a comment.Jul 17 2023, 2:36 PM

Change 938257 merged by jenkins-bot:

[mediawiki/core@master] Title: Switch Database::select calls to SelectQueryBuilder

https://gerrit.wikimedia.org/r/938257

gerritbot added a comment.Jul 17 2023, 2:45 PM

Change 938260 merged by jenkins-bot:

[mediawiki/core@master] tests: Migrate Database::select usages to SelectQueryBuilder

https://gerrit.wikimedia.org/r/938260

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.18; 2023-07-18); removed MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jul 17 2023, 3:00 PM
gerritbot added a comment.Jul 18 2023, 9:41 PM

Change 939371 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] tests: Switch to SelectQueryBuilder in Sqlite and PG integration tests

https://gerrit.wikimedia.org/r/939371

gerritbot added a comment.Jul 18 2023, 10:58 PM

Change 939385 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] maintenance: Switch simple calls of Database::select to SQB

https://gerrit.wikimedia.org/r/939385

gerritbot added a comment.Jul 19 2023, 4:16 PM

Change 939385 merged by jenkins-bot:

[mediawiki/core@master] maintenance: Switch simple calls of Database::select to SQB

https://gerrit.wikimedia.org/r/939385

gerritbot added a comment.Jul 20 2023, 11:46 AM

Change 939371 merged by jenkins-bot:

[mediawiki/core@master] tests: Switch to SelectQueryBuilder in Sqlite and PG integration tests

https://gerrit.wikimedia.org/r/939371

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.19; 2023-07-25); removed MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 20 2023, 1:00 PM
gerritbot added a comment.Jul 25 2023, 1:41 PM

Change 941404 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Migrate more calls of Database::select* to SelectQueryBuilder

https://gerrit.wikimedia.org/r/941404

gerritbot added a comment.Jul 26 2023, 11:21 AM

Change 941404 merged by jenkins-bot:

[mediawiki/core@master] Migrate more calls of Database::select* to SelectQueryBuilder

https://gerrit.wikimedia.org/r/941404

Ladsgroup added a parent task: T343098: [epic] Data Persistence Hypothesis WE 3.2.1.Jul 31 2023, 9:45 AM
gerritbot added a comment.Aug 1 2023, 4:36 PM

Change 944261 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Migrate last batch of simple Database::select* calls to SQB

https://gerrit.wikimedia.org/r/944261

gerritbot added a comment.Aug 1 2023, 8:11 PM

Change 944261 merged by jenkins-bot:

[mediawiki/core@master] Migrate last batch of simple Database::select* calls to SQB

https://gerrit.wikimedia.org/r/944261

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Aug 1 2023, 9:00 PM
gerritbot added a comment.Aug 1 2023, 9:05 PM

Change 944317 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] [WIP] Introduce FileSelectQueryBuilder

https://gerrit.wikimedia.org/r/944317

gerritbot added a comment.Aug 8 2023, 10:52 AM

Change 944317 merged by jenkins-bot:

[mediawiki/core@master] Introduce FileSelectQueryBuilder

https://gerrit.wikimedia.org/r/944317

Ladsgroup added a comment.Aug 8 2023, 3:04 PM

We now have around 600 calls to select query builder in core. And only 200-ish left. The ones left are rather complex. e.g. some build the query array and then pass it to a hook runner. RevisionStore and some other classes have a decent chunks of calls to select because of ::getSlotsQueryInfo() and similar. In some cases it makes sense to make a new function that return a query builder object, in some cases it makes sense to create a sub-class of SQB (e.g. what we did for User and File). But the 200 cases left are going to take a while to migrate.

gerritbot added a comment.Aug 24 2023, 10:59 AM

Change 952166 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Migrate several more Database::select calls to SQB

https://gerrit.wikimedia.org/r/952166

gerritbot added a comment.Aug 24 2023, 1:43 PM

Change 952166 merged by jenkins-bot:

[mediawiki/core@master] Migrate several more Database::select calls to SQB

https://gerrit.wikimedia.org/r/952166

Ladsgroup removed a parent task: T343098: [epic] Data Persistence Hypothesis WE 3.2.1.Aug 25 2023, 6:53 AM
tstarling closed subtask T312399: Migrate usage of Database::select to SelectQueryBuilder in LoginNotify as Resolved.Aug 28 2023, 2:34 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 30 2023, 2:01 AM
Umherirrender closed subtask T312347: Migrate usage of Database::select to SelectQueryBuilder in AntiSpoof as Resolved.Sep 13 2023, 5:41 PM
Urbanecm_WMF closed subtask T312481: Migrate usage of Database::select to SelectQueryBuilder in Thanks as Resolved.Sep 19 2023, 5:18 PM
gerritbot added a comment.Nov 21 2023, 5:48 PM

Change 810856 abandoned by Ladsgroup:

[mediawiki/core@master] rdbms: Soft-deprecate IDatabase::select() and similar methods

Reason:

These methods are now @internal making this patch moot

https://gerrit.wikimedia.org/r/810856

Ladsgroup closed subtask T312415: Migrate usage of Database::select to SelectQueryBuilder in UrlShortener as Resolved.Nov 30 2023, 4:35 PM
gerritbot added a comment.Dec 1 2023, 4:47 PM

Change 851080 abandoned by Ladsgroup:

[mediawiki/core@master] RevisionStore: Add support for transforming SelectQueryBuilder

Reason:

We actually built RevisionSQB making this patch moot

https://gerrit.wikimedia.org/r/851080

taavi closed subtask T312419: Migrate usage of Database::select to SelectQueryBuilder in OATHAuth as Resolved.Dec 6 2023, 3:44 PM
DAlangi_WMF subscribed.Dec 11 2023, 12:08 PM
Atieno subscribed.Dec 11 2023, 12:12 PM
tchin awarded a token.Dec 11 2023, 3:10 PM
gerritbot added a comment.Dec 13 2023, 3:14 PM

Change 982813 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] language: Migrate Database::select() to SQB

https://gerrit.wikimedia.org/r/982813

Jdlrobson changed the status of subtask T312450: Migrate usage of Database::select to SelectQueryBuilder in MobileFrontend from Open to Stalled.Dec 13 2023, 10:24 PM
Atieno closed subtask T312482: Migrate usage of Database::select to SelectQueryBuilder in ReadingLists as Resolved.Dec 15 2023, 2:03 PM
sguebo_WMF closed subtask T312323: Migrate usage of Database::select to SelectQueryBuilder in BetaFeatures as Resolved.Dec 16 2023, 2:24 AM
Ladsgroup reopened subtask T312482: Migrate usage of Database::select to SelectQueryBuilder in ReadingLists as Open.Dec 18 2023, 6:15 PM
Ladsgroup closed subtask T312361: Migrate usage of Database::select to SelectQueryBuilder in Nuke as Resolved.Dec 19 2023, 7:33 PM
Atieno closed subtask T312482: Migrate usage of Database::select to SelectQueryBuilder in ReadingLists as Resolved.Jan 9 2024, 4:28 PM
Ladsgroup closed subtask T312439: Migrate usage of Database::select to SelectQueryBuilder in Math as Declined.Jan 15 2024, 9:50 AM
Dreamy_Jazz closed subtask T312371: Migrate usage of Database::select to SelectQueryBuilder in MediaModeration as Resolved.Jan 30 2024, 10:36 AM
Wangombe changed the status of subtask T312337: Migrate usage of Database::select to SelectQueryBuilder in TranslationNotifications from Open to In Progress.Feb 12 2024, 7:45 AM
Samwilson added a subtask: T357956: Migrate usage of Database::select to SelectQueryBuilder in Genealogy.Feb 20 2024, 8:25 AM
abi_ closed subtask T312337: Migrate usage of Database::select to SelectQueryBuilder in TranslationNotifications as Resolved.Feb 21 2024, 10:04 AM
Krinkle renamed this task from Migrate Database::select usages to SelectQueryBuilder to Migrate Database::select usages to SelectQueryBuilder (in WMF-deployed extensions).Mar 5 2024, 7:37 PM
Jdforrester-WMF closed subtask T312485: Migrate usage of Database::select to SelectQueryBuilder in MachineVision as Invalid.Fri, Apr 5, 7:55 PM
Jdforrester-WMF removed a subtask: T312485: Migrate usage of Database::select to SelectQueryBuilder in MachineVision.
Umherirrender removed a subtask: T357956: Migrate usage of Database::select to SelectQueryBuilder in Genealogy.Fri, Apr 19, 9:13 PM
Umherirrender closed subtask T312484: Migrate usage of Database::select to SelectQueryBuilder in Renameuser as Invalid.Fri, Apr 19, 9:20 PM
Umherirrender removed a subtask: T312351: Migrate usage of Database::select to SelectQueryBuilder in CongressLookup.Fri, Apr 19, 9:28 PM
Umherirrender closed subtask T312445: Migrate usage of Database::select to SelectQueryBuilder in ShortUrl as Resolved.Sat, Apr 20, 7:43 PM
Umherirrender closed subtask T312350: Migrate usage of Database::select to SelectQueryBuilder in TextExtracts as Invalid.Sat, Apr 20, 7:46 PM
Umherirrender closed subtask T312340: Migrate usage of Database::select to SelectQueryBuilder in UniversalLanguageSelector as Invalid.Sat, Apr 20, 7:49 PM
Umherirrender closed subtask T312355: Migrate usage of Database::select to SelectQueryBuilder in LandingCheck as Invalid.
Umherirrender closed subtask T312469: Migrate usage of Database::select to SelectQueryBuilder in SpamBlacklist as Resolved.Sat, Apr 20, 9:07 PM
Umherirrender closed subtask T312465: Migrate usage of Database::select to SelectQueryBuilder in SubPageList3 as Resolved.
Umherirrender closed subtask T312356: Migrate usage of Database::select to SelectQueryBuilder in BounceHandler as Resolved.Sat, Apr 20, 9:13 PM
Umherirrender closed subtask T312462: Migrate usage of Database::select to SelectQueryBuilder in ArticlePlaceholder as Resolved.
Umherirrender closed subtask T312357: Migrate usage of Database::select to SelectQueryBuilder in CommonsMetadata as Invalid.Sat, Apr 20, 9:24 PM
Umherirrender closed subtask T312433: Migrate usage of Database::select to SelectQueryBuilder in ConfirmEdit as Invalid.
Umherirrender closed subtask T312405: Migrate usage of Database::select to SelectQueryBuilder in DonationInterface as Invalid.Sat, Apr 20, 9:36 PM
Umherirrender closed subtask T312346: Migrate usage of Database::select to SelectQueryBuilder in MediaSearch as Resolved.Sat, Apr 20, 9:48 PM
Umherirrender closed subtask T312490: Migrate usage of Database::select to SelectQueryBuilder in WikimediaEvents as Invalid.Sat, Apr 20, 9:50 PM
Umherirrender closed subtask T312451: Migrate usage of Database::select to SelectQueryBuilder in Collection as Resolved.Sun, Apr 21, 9:53 AM
Umherirrender closed subtask T312442: Migrate usage of Database::select to SelectQueryBuilder in LdapAuthentication as Resolved.
Umherirrender closed subtask T312326: Migrate usage of Database::select to SelectQueryBuilder in CreditsSource as Resolved.
Umherirrender closed subtask T312410: Migrate usage of Database::select to SelectQueryBuilder in FileImporter as Resolved.
Umherirrender closed subtask T312409: Migrate usage of Database::select to SelectQueryBuilder in Disambiguator as Resolved.
Umherirrender closed subtask T312438: Migrate usage of Database::select to SelectQueryBuilder in SimilarEditors as Invalid.Sun, Apr 21, 7:42 PM
Umherirrender closed subtask T312352: Migrate usage of Database::select to SelectQueryBuilder in ImageSuggestions as Resolved.Sun, Apr 21, 9:59 PM
Umherirrender closed subtask T312423: Migrate usage of Database::select to SelectQueryBuilder in GlobalUserPage as Resolved.
Umherirrender closed subtask T312390: Migrate usage of Database::select to SelectQueryBuilder in GoogleNewsSitemap as Resolved.Mon, Apr 22, 5:37 PM
Umherirrender closed subtask T312380: Migrate usage of Database::select to SelectQueryBuilder in GlobalUsage as Resolved.
Umherirrender closed subtask T312329: Migrate usage of Database::select to SelectQueryBuilder in GlobalBlocking as Resolved.Mon, Apr 22, 5:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL