Tagging as Regression as I'm pretty sure this was implemented in T293316: Add an image: minimal quality gate, and probably broke during some refactorings since then.

We used to do the quality gate check just in the client in ext.growthExperiments.PostEdit.js#51. Seems that the logic was removed in gerrit 786403 but can't find the reason behind or any other refactored logic handling the quality gate check of the task feed elements (both in homepage and post edit dialog). @Etonkovidova do you remember having done a QA test for this scenario in the homepage feed?

I see three options, although trying to solve this in the server seems the most reasonable ones:

1. Do the check in the client like prior status quo
2. Filter the exceeded task type tasks after querying ES
3. Check the limit before querying ES, and exclude the exceeded task type if needed

Exploring option (3) because it makes sense to avoid requesting exceeded quota types beforehand, I come across this comment in SearchTaskSuggester.php#144:

// We generally don't try to handle task type filtering for the A/B test (T278123) here
// as it is already handled in NewcomerTasksUserOptionsLookup, but we make an exception
// for the case when $taskTypeFilter === [] which would be difficult to handle elsewhere.
if ( !$taskSetFilters->getTaskTypeFilters() ) {
    $taskSetFilters->setTaskTypeFilters(
        $this->newcomerTasksUserOptionsLookup
            ->filterTaskTypes( array_keys( $this->taskTypes ), $user )
    );
}

Since our SearchStrategy iterates over the provided task types, and the user will still have the exceeded quota task type on its preferences by the time of this check, it is impeding us to return 0 results for the scenario Only 1 task type selected, and the quota has been exceeded for it.

Can someone help to identify which scenario is that logic covering? We can also explore option (2) which does not have this problem. @kostajh @Tgr

Change 811944 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] [WIP] Newcomer tasks: avoid returning exceeded quota task types for the task feed

https://gerrit.wikimedia.org/r/811944

Change 811944 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Post edit dialog: avoid showing exceeded task daily limit task types

https://gerrit.wikimedia.org/r/811944