Page MenuHomePhabricator

[1.40] Remove the Group::insertAfter() function in Minerva
Closed, ResolvedPublic1 Estimated Story Points

Description

Based on the deprecation process:

Obsolete behavior MAY be removed after it has been hard deprecated for three months in the development version (the master branch) as well as in one major release, using either deprecation warnings or public announcement as described in the hard deprecation section.

Therefore, the Group::insertAfter() function should be removed 3 months after T311894 has been merged.

TODO

  • Remove the method.

Event Timeline

@Scardenasmolinar: Assuming this task is about the MinervaNeue code project, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. Please set appropriate project tags when possible. Thanks!

Samwalton9-WMF renamed this task from Remove the Group::insertAfter() function in Minerva to [1.40] Remove the Group::insertAfter() function in Minerva.Jul 19 2022, 6:24 PM
Samwalton9-WMF added a subscriber: Jdlrobson.
Jdlrobson triaged this task as Medium priority.Jan 31 2023, 12:50 AM
LGoto set the point value for this task to 1.Feb 6 2023, 6:29 PM

Change 886963 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/skins/MinervaNeue@master] [1.40] Remove the Group::insertAfter() function in Minerva

https://gerrit.wikimedia.org/r/886963

Change 887339 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/skins/MinervaNeue@master] Fix Unused use statement "SingleMenuEntry" error

https://gerrit.wikimedia.org/r/887339

Change 887366 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/skins/MinervaNeue@master] Removes unused use statement

https://gerrit.wikimedia.org/r/887366

Change 887339 abandoned by Jdrewniak:

[mediawiki/skins/MinervaNeue@master] Fix Unused use statement "SingleMenuEntry" error

Reason:

https://gerrit.wikimedia.org/r/887339

Change 886963 abandoned by Jdrewniak:

[mediawiki/skins/MinervaNeue@master] [1.40] Remove the Group::insertAfter() function in Minerva

Reason:

https://gerrit.wikimedia.org/r/886963

Change 887366 had a related patch set uploaded (by Jdrewniak; author: Kimberly Sarabia):

[mediawiki/skins/MinervaNeue@master] Remove the Group::insertAfter() function in Minerva

https://gerrit.wikimedia.org/r/887366

Change 887366 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove the Group::insertAfter() function in Minerva

https://gerrit.wikimedia.org/r/887366

Jdrewniak subscribed.
Jdlrobson claimed this task.

LGTM! Congrats on the first patch @KSarabia-WMF !