Page MenuHomePhabricator
Create Task
Maniphest T311903

Blue highlight for a formatting change is not visible when "computer code" formatting added
Closed, ResolvedPublic
Actions

Assigned To
• ppelberg
Authored By
Esanders
Jul 2 2022, 11:43 AM
Tags
Referenced Files
F35319789: Screenshot 2022-07-18 at 00.02.24.png
Jul 17 2022, 11:03 PM
F35319784: Screenshot 2022-07-18 at 00.00.43.png
Jul 17 2022, 11:03 PM
F35296489: image.png
Jul 2 2022, 11:43 AM
F35296487: image.png
Jul 2 2022, 11:43 AM
Subscribers
Aklapper
EAkinloose
Esanders
matmarex

Description

The grey background of the <code> block overrides the blue background of the diff. Compare with adding bold formatting which is clearly highlighted:

image.png (175×885 px, 54 KB)

When hovering the text:

image.png (176×873 px, 47 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (1800c35de)mediawiki/extensions/VisualEditormaster+1 -1
Visual diff: Use mix-blend-mode to improve opacity hacks for content in highlighted areasVisualEditor/VisualEditormaster+26 -19
Customize query in gerrit

Event Timeline

Esanders created this task.Jul 2 2022, 11:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2022, 11:43 AM
gerritbot added a comment.Jul 2 2022, 1:00 PM

Change 810457 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Visual diff: Use mix-blend-mode to improve opacity hacks for content in highlighted areas

https://gerrit.wikimedia.org/r/810457

gerritbot added a project: Patch-For-Review.Jul 2 2022, 1:00 PM
gerritbot added a comment.Jul 16 2022, 4:47 PM

Change 810457 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Visual diff: Use mix-blend-mode to improve opacity hacks for content in highlighted areas

https://gerrit.wikimedia.org/r/810457

gerritbot added a comment.Jul 16 2022, 5:18 PM

Change 814298 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1800c35de)

https://gerrit.wikimedia.org/r/814298

gerritbot added a comment.Jul 16 2022, 5:34 PM

Change 814298 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1800c35de)

https://gerrit.wikimedia.org/r/814298

matmarex added a project: Editing-team (Kanban Board).Jul 16 2022, 6:00 PM
matmarex removed a project: Patch-For-Review.
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.
matmarex subscribed.
EAkinloose edited projects, added Verified; removed Editing QA.Jul 17 2022, 11:03 PM
EAkinloose subscribed.

✅ Blue highlight for a formatting change is visible when "computer code" formatting added

Screenshot 2022-07-18 at 00.00.43.png (680×1 px, 225 KB)

Screenshot 2022-07-18 at 00.02.24.png (618×1 px, 217 KB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jul 17 2022, 11:03 PM
• ppelberg closed this task as Resolved.Jul 22 2022, 1:36 AM
• ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL