Find and replace input not focused when pressing ctrl+f a second time
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Jul 2 2022, 11:44 AM

Description

Open VE
Press Ctrl+F
Type, your text appears in the "find bar"
Focus the document
Press Ctrl+F again
The find bar appears focused, but your cursor is not placed in it, and typing does nothing.

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (0a909d09a)	mediawiki/extensions/VisualEditor	master	+1 -1
	Follow-up I61b477d1f: Only remove native ranges if the are inside the document	VisualEditor/VisualEditor	master	+1 -1

Mentioned Here: T293661: Clicking from text to a link in iOS Safari doesn't open the link context

Change 810455 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Follow-up I61b477d1f: Only remove native ranges if the are inside the document

Esanders moved this task from To Triage to Triaged on the VisualEditor board.

Testing should ensure there is no regression of T293661.

Change 810455 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Follow-up I61b477d1f: Only remove native ranges if the are inside the document

Change 810939 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0a909d09a)

Change 810939 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0a909d09a)

matmarex added a project: Editing QA.

Before Fix: Typing doesn't do anything in step 6. See https://photos.app.goo.gl/XSQiyu1gfaTESWbc9
After Fix:In step 6, typing replaces the existing text in the find bar with whatever the user is typing. See https://photos.app.goo.gl/xDTSswPkgTyKPLfH6

ppelberg closed this task as Resolved.Jul 8 2022, 12:46 AM