Page MenuHomePhabricator

Investigate if .mw-body-subheader must be in wikis without subheaders
Closed, ResolvedPublic

Description

I have seen that .mw-body-subheader has a

margin-top: 1em;

in it, but this creates a blank space that is not very aesthetic (check, for example eu:Paris).

Should it be there or would it be a good idea to get rid of it if we don't have subheaders below that?

presentproposed
Screen Shot 2022-07-08 at 11.13.43 AM.png (506×2 px, 187 KB)
Screen Shot 2022-07-08 at 11.14.16 AM.png (734×2 px, 414 KB)

Event Timeline

I think this is related to what we were working on in T311421: Restore styling of siteSub (aka site tagline) when article indicators are present. @bwang I think you learned that these two (often empty) <div> elements are necessary for some reason?

Screen Shot 2022-08-18 at 1.42.48 PM.png (1×3 px, 1 MB)

Jdlrobson claimed this task.
Jdlrobson added a subscriber: Jdlrobson.

This was resolved by T311421.

This article to my surprise had the same issue but on further inspection that was due to an empty p tag caused by Txantiloi:Argitzeko which I'm fixing as we speak.

Screen Shot 2022-09-02 at 8.16.11 AM.png (92×654 px, 15 KB)