Page MenuHomePhabricator

Meta talkpages for Central Notice banners turned into banner overview pages from the admin interface
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Log in with you Wikimedia account
  • Go to a page around central notice on Meta, for instance a banner request, but also the general information page on central notices
  • Try to go to the talkpages of this page, where it now says "banners"
  • ... and find yourself not ending up on a talkpage, but in the admin interface for banners.

What happens?:
People end up in the admin interface (per my sockpuppet: without editting access), instead of on the talkpage of the Meta page.

What should have happened instead?:
visiting the talkpage

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Firefox and Chrome both give this problem.
Happens logged in (with or without CN Admin rights on Meta), as well as not logged in.

Screenshot 2022-07-03 at 15-07-45 Manage banners - Meta.png (754×1 px, 122 KB)

Screenshot 2022-07-03 at 15-03-12 CentralNotice - Meta.png (504×1 px, 107 KB)

Screenshot 2022-07-03 at 15-03-34 CentralNotice_Request_Wikipedia Pages Wanting Photos Campaign 2022 - Meta.png (363×1 px, 64 KB)

Event Timeline

Ciell renamed this task from Talkpages for banners turned into banner overview pages from the admin interface? to Meta talkpages for Central Notice banners turned into banner overview pages from the admin interface.Jul 3 2022, 1:22 PM

Change 810544 had a related patch set uploaded (by AndyRussG; author: AndyRussG):

[mediawiki/extensions/CentralNotice@master] Only add tabs to special pages

https://gerrit.wikimedia.org/r/810544

AndyRussG added a subscriber: Jdlrobson.

Thanks so much for this report, @Ciell! The patch above fixes the issue. Hopefully we can get this deployed soon.

@Jdlrobson just flagging this in case a similar issue (unexpected behaviour on non-special pages following switch to SkinTemplateNavigation::Universal hook) crops up elsewhere... thx!!

Thanks for the quick response and the patch @AndyRussG !

Change 810544 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Only add tabs to special pages

https://gerrit.wikimedia.org/r/810544

Change 810985 had a related patch set uploaded (by AndyRussG; author: AndyRussG):

[mediawiki/extensions/CentralNotice@wmf/1.39.0-wmf.18] Only add tabs to special pages

https://gerrit.wikimedia.org/r/810985

Change 810985 abandoned by AndyRussG:

[mediawiki/extensions/CentralNotice@wmf/1.39.0-wmf.18] Only add tabs to special pages

Reason:

Change-Id weirdness and missing cherry-pick sha

https://gerrit.wikimedia.org/r/810985

Mentioned in SAL (#wikimedia-operations) [2022-07-05T07:17:02Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.18/extensions/CentralNotice/includes/specials/CentralNotice.php: 414b7b8a14b451f9bd0fb0c36d44fe6a9310102e: Only add tabs to special pages (T311944) (duration: 03m 30s)

This is deployed and seems to be successfully fixed now... thx again @Ciell!

Sorry about that @AndyRussG . Thanks for letting us know and fixing it so quickly. Pinging T255319 so the two tasks are linked on Phabricator.

Sorry about that @AndyRussG . Thanks for letting us know and fixing it so quickly. Pinging T255319 so the two tasks are linked on Phabricator.

Ah hehe no worries ofc!! Sorry I didn't think of this possible issue and thx for all the work on this! :)

This is deployed and seems to be successfully fixed now... thx again @Ciell!

Yes, it's fixed for me as well.
Thanks for the work!

XenoRyet set Final Story Points to 2.