Page MenuHomePhabricator
Create Task
Maniphest T311987

Cleanup: stateless `StackLayout`
Closed, ResolvedPublic
Actions

Description

Investigate whether we can simpify the content pane of the visual editor template dialog, by replacing the StackLayout container with a PanelLayout. This eliminates some state and side-effect events like set which are mismatched to our new sidebar.

  • Decouple from the StackLayout set event
  • Decouple from StackLayout currentItem state

Optional:

  • Replace StackLayout with PanelLayout

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Reuse hard and soft action handlersmediawiki/extensions/VisualEditormaster+37 -26
Rewrite handlers using canonical setPagemediawiki/extensions/VisualEditormaster+4 -41
Two-pane layout setPage has all the desired side-effectsmediawiki/extensions/VisualEditormaster+3 -2
Replace event wiring for stackLayout.set with explicit callmediawiki/extensions/VisualEditormaster+29 -14
Use local state rather than stackLayout.currentItemmediawiki/extensions/VisualEditormaster+1 -1
[WIP] Sidebar parameter events take "soft" modifiermediawiki/extensions/VisualEditormaster+44 -25
[WIP] Disconnect stackLayout "set" eventmediawiki/extensions/VisualEditormaster+3 -16
Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.Jul 4 2022, 8:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 4 2022, 8:32 AM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-06-22 board.Jul 4 2022, 8:32 AM
gerritbot added a comment.Jul 4 2022, 9:06 AM

Change 810326 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Disconnect stackLayout "set" event

https://gerrit.wikimedia.org/r/810326

gerritbot added a project: Patch-For-Review.Jul 4 2022, 9:06 AM

Change 810316 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Sidebar parameter events take "soft" modifier

https://gerrit.wikimedia.org/r/810316

gerritbot added a comment.Jul 4 2022, 9:06 AM

Change 810843 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Use local state rather than stackLayout.currentItem

https://gerrit.wikimedia.org/r/810843

gerritbot added a comment.Jul 4 2022, 9:06 AM

Change 810844 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Cleanup: setPage becomes the canonical way to select

https://gerrit.wikimedia.org/r/810844

gerritbot added a comment.Jul 4 2022, 9:11 AM

Change 810326 abandoned by Awight:

[mediawiki/extensions/VisualEditor@master] [WIP] Disconnect stackLayout "set" event

Reason:

squashed

https://gerrit.wikimedia.org/r/810326

gerritbot added a comment.Jul 4 2022, 9:12 AM

Change 810316 abandoned by Awight:

[mediawiki/extensions/VisualEditor@master] [WIP] Sidebar parameter events take "soft" modifier

Reason:

squashed

https://gerrit.wikimedia.org/r/810316

gerritbot added a comment.Jul 4 2022, 9:52 AM

Change 810853 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Replace event wiring for stackLayout.set with explicit call

https://gerrit.wikimedia.org/r/810853

gerritbot added a comment.Jul 4 2022, 11:44 AM

Change 810882 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Two-pane layout setPage has all the desired side-effects

https://gerrit.wikimedia.org/r/810882

gerritbot added a comment.Jul 4 2022, 11:44 AM

Change 810883 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Rewrite handlers using canonical setPage

https://gerrit.wikimedia.org/r/810883

awight mentioned this in T311711: Regression: spacebar in the sidebar to select a template or check a parameter should also scroll content pane.Jul 4 2022, 11:58 AM
gerritbot added a comment.Jul 4 2022, 12:07 PM

Change 810843 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use local state rather than stackLayout.currentItem

https://gerrit.wikimedia.org/r/810843

gerritbot added a comment.Jul 4 2022, 12:44 PM

Change 810853 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Replace event wiring for stackLayout.set with explicit call

https://gerrit.wikimedia.org/r/810853

gerritbot added a comment.Jul 4 2022, 12:49 PM

Change 810882 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Two-pane layout setPage has all the desired side-effects

https://gerrit.wikimedia.org/r/810882

gerritbot added a comment.Jul 4 2022, 1:08 PM

Change 810883 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Rewrite handlers using canonical setPage

https://gerrit.wikimedia.org/r/810883

awight removed awight as the assignee of this task.Jul 4 2022, 1:15 PM
awight updated the task description. (Show Details)
awight moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-06-22 board.
gerritbot added a comment.Jul 4 2022, 1:51 PM

Change 810844 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Reuse hard and soft action handlers

https://gerrit.wikimedia.org/r/810844

awight closed this task as Resolved.Jul 4 2022, 1:54 PM
awight claimed this task.
awight moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2022-06-22 board.
awight mentioned this in T312524: Cleanup: deprecate StackLayout.Jul 7 2022, 10:29 AM
awight added a parent task: T312524: Cleanup: deprecate StackLayout.
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 1:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits