Page MenuHomePhabricator
Create Task
Maniphest T312002

When pre-selecting the type of a key-value in the zobject editor, select the type of a type list
Closed, ResolvedPublic
Actions

Assigned To
• AdesojiThisDot
Authored By
gengh
Jul 4 2022, 11:27 AM
Tags
Referenced Files
F35330326: Screenshot from 2022-07-22 18-11-33.png
Jul 22 2022, 4:16 PM
F35330324: Screenshot from 2022-07-22 18-14-35.png
Jul 22 2022, 4:16 PM
F35330308: Screenshot from 2022-07-22 17-58-29.png
Jul 22 2022, 4:02 PM
F35330304: Screenshot from 2022-07-22 17-55-10.png
Jul 22 2022, 4:02 PM
Subscribers
Aklapper
gengh

Description

For example: When creating a type, the information of Z4 already knows that Z4K2 is a typed list of Z3, but it still asks us to select the type for each key that we add to the list. This could and should be restricted

Steps to reproduce:

  • Create a new ZObject from the Special:CreateZObject page
  • In Contents, select the type "Type"
  • The key "keys" is preloaded with a ZTypedList component

Observed behavior

  • The ZTypedList but it doesn't have a pre-selected type for the items.
  • When adding an item to the list by clicking the button [+], a new untyped item is added and the user will be asked to select the type.

Expected behavior

  • The ZTypedList should be a ZTypedList of Z3s
  • When adding an item to the list by clicking the button [+], the new item should be of type Z3

Details

SubjectRepoBranchLines +/-
When pre-selecting the type of a key-value in the zobject editor, select the type of a type listmediawiki/extensions/WikiLambdamaster+69 -34
Customize query in gerrit

Event Timeline

gengh created this task.Jul 4 2022, 11:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 4 2022, 11:27 AM
gengh moved this task from Ready: G1. Canonical form of Typed lists to Ready: G5. Fallback view on the Abstract Wikipedia team (Phase θ – Throttling) board.Jul 5 2022, 5:41 AM
• AdesojiThisDot claimed this task.Jul 5 2022, 12:10 PM
• AdesojiThisDot moved this task from Ready: G5. Fallback view to In progress on the Abstract Wikipedia team (Phase θ – Throttling) board.
MShilova_WMF moved this task from In progress to Ready: G5. Fallback view on the Abstract Wikipedia team (Phase θ – Throttling) board.Jul 11 2022, 4:07 PM
gerritbot added a comment.Jul 21 2022, 10:27 AM

Change 815918 had a related patch set uploaded (by AdesojiThisDot; author: AdesojiThisDot):

[mediawiki/extensions/WikiLambda@master] When pre-selecting the type of a key-value in the zobject editor, select the type of a type list

https://gerrit.wikimedia.org/r/815918

gerritbot added a project: Patch-For-Review.Jul 21 2022, 10:27 AM
gengh added a comment.Jul 22 2022, 4:02 PM

Here are some issues found while testing https://gerrit.wikimedia.org/g/mediawiki/extensions/WikiLambda/+/df4e61bb8419a19d50cc7ff7af4fe01f77af70bc

  1. On viewing a key with type Typed list, the key name and value are now empty. For example in the following image, Z4K2 should show a first item with "value type: Typed list (Key)" or "value type: Typed list --> Key" (not sure what will be the syntax for this). Currently it's empty, even the key label is not showing:

Screenshot from 2022-07-22 17-55-10.png (212×1 px, 16 KB)

  1. On editing an object with a key with type Typed list, the key name and values are also empty. For example, in the following image, the first key has the trash can, but it should contain the label "value type", and then "Typed list" and a ZTypeSelector component with the current type selected.

Screenshot from 2022-07-22 17-58-29.png (346×1 px, 29 KB)

gengh added a comment.Jul 22 2022, 4:16 PM

(Followup from previous comment)

  1. In console, multiple errors with description "TypeError: zListItem is undefined"
  1. When creating a list of elements, it's only possible to assign value to the first of those elements. Steps to reproduce:
    • Go to http://localhost:8080/wiki/Special:CreateZObject?view=zobject-editor
    • In Contents select type "Typed list"
    • In the type list type selector, select type "Boolean"
    • Add one element to the list
    • Select true
    • Add another element to the list
    • Select false
    • Observe the ZObject in the JSON textbox: second element doesn't have a value
    • Add a third element to the list
    • Observe the boolean components above: only the first boolean component has a value
    • Observe the ZObject in the JSON textbox: only the first boolean element has a value

Screenshot from 2022-07-22 18-14-35.png (707×1 px, 110 KB)

  • Replicate this same experiment with ZString: the elements are saved properly
  • Replicate this same experiment with ZKeyReference: same thing happens as with Boolean

Screenshot from 2022-07-22 18-11-33.png (863×1 px, 114 KB)

gerritbot added a comment.Aug 8 2022, 1:37 PM

Change 815918 had a related patch set uploaded (by Jforrester; author: AdesojiThisDot):

[mediawiki/extensions/WikiLambda@master] When pre-selecting the type of a key-value in the zobject editor, select the type of a type list

https://gerrit.wikimedia.org/r/815918

gerritbot added a comment.Aug 9 2022, 4:02 PM

Change 815918 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] When pre-selecting the type of a key-value in the zobject editor, select the type of a type list

https://gerrit.wikimedia.org/r/815918

• AdesojiThisDot moved this task from Ready: G5. Fallback view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Aug 15 2022, 9:31 AM
gengh closed this task as Resolved.Aug 22 2022, 4:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL