Page MenuHomePhabricator

Move classes under tag folder to namespace
Closed, ResolvedPublic4 Estimated Story Points

Description

Move the following classes to namespace:

In addition to moving the classes to namespace:

  • Add dependency injection
  • Remove usage of deprecated methods
  • Use strict types
  • Check for external users of the class / methods

Event Timeline

abi_ triaged this task as Medium priority.Jul 4 2022, 11:46 AM
abi_ set the point value for this task to 4.

Change 815297 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] MoveTranslatableBundleJob: Move to namespace

https://gerrit.wikimedia.org/r/815297

Change 815315 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] DeleteTranslatableBundleJob: Move to namespace

https://gerrit.wikimedia.org/r/815315

Change 816354 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] LogFormatter: Move to namespace and add strict types

https://gerrit.wikimedia.org/r/816354

Change 815297 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MoveTranslatableBundleJob: Move to namespace

https://gerrit.wikimedia.org/r/815297

Change 817697 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] TranslatablePageException: Move to namespace

https://gerrit.wikimedia.org/r/817697

Change 815315 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] DeleteTranslatableBundleJob: Move to namespace

https://gerrit.wikimedia.org/r/815315

Change 817705 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] DeleteTranslatableBundleJob: Use FuzzyBot to perform the deletion

https://gerrit.wikimedia.org/r/817705

Change 817705 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] DeleteTranslatableBundleJob: Use FuzzyBot to perform the deletion

https://gerrit.wikimedia.org/r/817705

Change 817770 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move TranslatablePage into PageTranslation namespace

https://gerrit.wikimedia.org/r/817770

Change 816354 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatableBundleLogFormatter: Move to namespace and add strict types

https://gerrit.wikimedia.org/r/816354

Change 820099 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] RenderTranslationPageJob: Move to namespace

https://gerrit.wikimedia.org/r/820099

Change 820114 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] UpdateTranslationsJob move to namespace

https://gerrit.wikimedia.org/r/820114

Change 817697 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Delete TPException and use Status object

https://gerrit.wikimedia.org/r/817697

For PageTranslationHooks we want to do the following:

  1. Move the class under the PageTranslation namespace and rename the class to Hooks. Remove use of any deprecated methods if possible.
  2. As part of another task(T314759), start implementing hook interfaces and injecting dependencies.

Change 817770 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move TranslatablePage into PageTranslation namespace

https://gerrit.wikimedia.org/r/817770

Change 823618 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Hooks: move to namespace

https://gerrit.wikimedia.org/r/823618

Change 820099 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] RenderTranslationPageJob: Move to namespace

https://gerrit.wikimedia.org/r/820099

Change 820114 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] UpdateTranslatablePageJob: move to namespace

https://gerrit.wikimedia.org/r/820114

Change 824711 had a related patch set uploaded (by Krinkle; author: Urbanecm):

[mediawiki/extensions/Translate@master] TranslatableBundleLogFormatter: Cast reason to string before passing it

https://gerrit.wikimedia.org/r/824711

Change 824711 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatableBundleLogFormatter: Cast reason to string before passing it

https://gerrit.wikimedia.org/r/824711

Change 824442 had a related patch set uploaded (by Jforrester; author: Urbanecm):

[mediawiki/extensions/Translate@wmf/1.39.0-wmf.25] TranslatableBundleLogFormatter: Cast reason to string before passing it

https://gerrit.wikimedia.org/r/824442

Change 824442 abandoned by Jforrester:

[mediawiki/extensions/Translate@wmf/1.39.0-wmf.25] TranslatableBundleLogFormatter: Cast reason to string before passing it

Reason:

https://gerrit.wikimedia.org/r/824442

Change 823618 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] PageTranslation/Hooks: move to namespace

https://gerrit.wikimedia.org/r/823618