Page MenuHomePhabricator

Remove the RevTag class
Closed, ResolvedPublic2 Estimated Story Points

Description

This class introduces unhelpful indirection.

Event Timeline

abi_ triaged this task as Medium priority.Jul 4 2022, 11:52 AM
abi_ set the point value for this task to 2.

Change 811320 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Simplify the RevTag table

https://gerrit.wikimedia.org/r/811320

Change 811580 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/CentralNotice@master] Remove usage of Translate RevTag class

https://gerrit.wikimedia.org/r/811580

Change 819005 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Remove RevTag class and add tag constants in RevTagStore

https://gerrit.wikimedia.org/r/819005

Change 811320 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] Simplify the RevTag class

Reason:

In favor of I45c22bc7622dc65455eec0ed4238b34b97c75693

https://gerrit.wikimedia.org/r/811320

Change 819005 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Replace usage of RevTag class with add tag constants in RevTagStore

https://gerrit.wikimedia.org/r/819005

Change 826127 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Remove RevTag class

https://gerrit.wikimedia.org/r/826127

We've added some constants to the RevTagStore class to remove usage of the RevTag class from the Translate extension. This patch has been deployed.

The RevTag class is still used on the CentralNotice extension, the patch for which needs to be reviewed, merged, and deployed.

I've also submitted a separate patch to remove the class once the CentralNotice patch is deployed.

Change 811580 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Remove usage of Translate RevTag class

https://gerrit.wikimedia.org/r/811580

Change 826127 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Remove RevTag class

https://gerrit.wikimedia.org/r/826127

Deployed and tested on translatewiki.net

Change 842900 had a related patch set uploaded (by MacFan4000; author: Abijeet Patro):

[mediawiki/extensions/CentralNotice@REL1_38] Remove usage of Translate RevTag class

https://gerrit.wikimedia.org/r/842900

Change 842900 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@REL1_38] Remove usage of Translate RevTag class

https://gerrit.wikimedia.org/r/842900