Page MenuHomePhabricator
Create Task
Maniphest T312016

Increase EditAttemptStep sampling rate(s) to 100%
Closed, ResolvedPublic
Actions

Description

@MNeisler, @nettrom_WMF, @cchen, and @Ottomata confirmed that increasing the sampling rate of the EditAttemptStep instrument (EAS) to 100% shouldn't be a problem.

However, we can't just add

$wgDTSchemaEditAttemptStepSamplingRate = $wgWMESchemaEditAttemptStepSamplingRate = 1; // 100%

to LocalSettings.php because the VisualEditorFeatureUse instrument (VEFU) also uses those variables. In order to be able to vary the sampling rates for EAS and VEFU independently, we'll have to:

  1. Add new sample rate variables to VEFU
  2. Set EAS sample rate variables to 100%
  3. Remove $wgDTSchemaEditAttemptStepOversample (which is always true in production) and $wgDTSchemaEditAttemptSamplingRate (which is always 0 in production)
    • This is optional but would simplify the answer to the question "How is VEFU sampled?"

We should keep $wgWMESchemaEditAttemptStepSamplingRate (set to 1 in step 2 above) as it can be used as an on/off switch for EAS. It can be removed after EAS is migrated to Metrics Platform.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
EditAttemptStep sampling rate to 1 everywhereoperations/mediawiki-configmaster+3 -56
wgWMESchemaEditAttemptStepSamplingRate to 1 everywhereoperations/mediawiki-configmaster+2 -13
EditAttemptStep sampling rate to 1 for group1 wikisoperations/mediawiki-configmaster+17 -1
EditAttemptStep sampling rate to 1 for group1 wikisoperations/mediawiki-configmaster+9 -5
Update Edit Attempt Step sampling rate to 1 for group 0 wikisoperations/mediawiki-configmaster+2 -0
Update sample rate for edit attempt stream to 1 for group 0.operations/mediawiki-configmaster+1 -1
EventDispatcher: Remove reference to $wgWMESchemaEditAttemptStepOversamplemediawiki/extensions/DiscussionToolsmaster+2 -3
Use wgWMESchemaVisualEditorFeatureUseSamplingRate config variablemediawiki/extensions/VisualEditormaster+20 -8
logger: Use wgWMESchemaVisualEditorFeatureUseSamplingRate config variablemediawiki/extensions/DiscussionToolsmaster+7 -6
Add WMESchemaVisualEditorFeatureUseSamplingRate config variablemediawiki/extensions/WikimediaEventsmaster+13 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ppelberg moved this task from Backlog to External on the Editing-team (Tracking) board.Jul 7 2022, 12:18 AM
VPuffetMichel moved this task from Backlog to Triaged on the DiscussionTools board.Jul 18 2022, 4:52 PM
VPuffetMichel moved this task from To Triage to Triaged on the VisualEditor board.Jul 18 2022, 4:57 PM
gerritbot added a comment.Aug 4 2022, 10:58 AM

Change 820412 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/WikimediaEvents@master] Add WMESchemaVisualEditorFeatureUseSamplingRate config variable

https://gerrit.wikimedia.org/r/820412

gerritbot added a project: Patch-For-Review.Aug 4 2022, 10:58 AM

Change 820413 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/DiscussionTools@master] logger: Use wgWMESchemaVisualEditorFeatureUseSamplingRate config variable

https://gerrit.wikimedia.org/r/820413

gerritbot added a comment.Aug 4 2022, 10:58 AM

Change 820414 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/DiscussionTools@master] EventDispatcher: Remove reference to $wgWMESchemaEditAttemptStepOversample

https://gerrit.wikimedia.org/r/820414

gerritbot added a comment.Aug 4 2022, 10:59 AM

Change 820415 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/VisualEditor@master] Use wgWMESchemaVisualEditorFeatureUseSamplingRate config variable

https://gerrit.wikimedia.org/r/820415

gerritbot added a comment.Aug 29 2022, 1:10 PM

Change 820412 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Add WMESchemaVisualEditorFeatureUseSamplingRate config variable

https://gerrit.wikimedia.org/r/820412

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Aug 29 2022, 2:00 PM
phuedx claimed this task.Oct 3 2022, 10:43 AM
phuedx added a project: Metrics Platform (Metrics Platform Kanban).
phuedx moved this task from Ready to In Progress on the Metrics Platform (Metrics Platform Kanban) board.
phuedx moved this task from In Progress to In Review on the Metrics Platform (Metrics Platform Kanban) board.Oct 3 2022, 4:33 PM
phuedx reassigned this task from phuedx to cjming.Oct 5 2022, 3:02 PM
cjming added a comment.Oct 19 2022, 5:20 PM

Reached out to Editing team in #humansoftheweb channel (is there a better place than this?) for their feedback before merging associated patches in DiscussionTools + VisualEditor.

Tested aforementioned patches and all lgtm so I will merge shortly hopefully with Editing team's blessing. Though I don't subscribe to silence === consent, in this case since the patches have been languishing in review, I will be bold if crickets ensue.

gerritbot added a comment.Oct 19 2022, 7:09 PM

Change 820413 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] logger: Use wgWMESchemaVisualEditorFeatureUseSamplingRate config variable

https://gerrit.wikimedia.org/r/820413

gerritbot added a comment.Oct 19 2022, 7:35 PM

Change 820415 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use wgWMESchemaVisualEditorFeatureUseSamplingRate config variable

https://gerrit.wikimedia.org/r/820415

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 19 2022, 8:00 PM
phuedx moved this task from In Review to Ready to Deploy on the Metrics Platform (Metrics Platform Kanban) board.Oct 20 2022, 9:12 AM
gerritbot added a comment.Oct 24 2022, 12:48 PM

Change 820414 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] EventDispatcher: Remove reference to $wgWMESchemaEditAttemptStepOversample

https://gerrit.wikimedia.org/r/820414

cjming moved this task from Ready to Deploy to Sign Off on the Metrics Platform (Metrics Platform Kanban) board.Oct 24 2022, 1:23 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 24 2022, 1:30 PM
cjming added a comment.Oct 31 2022, 1:38 PM

Ran the following query in Hue since the last DT patch was merged on 10/24:

SELECT * FROM mediawiki_edit_attempt WHERE custom_data IS NOT NULL AND year=2022 AND month=10 AND day > 24 AND day < 31;

Query returned 159 rows. Not sure if this is within reasonable ballpark of expected results. The EAS sampling rate in config $wgWMESchemaEditAttemptStepSamplingRate is set to 0.06 for default and 0.2 for a handful of pilot wikis.

Also, seems like _schema should not be null which is the case for all rows.

Here's a slice of the query results (happy to attach full CSV but unsure if i have to redact some data):

_schemaagentcustom_datadt
NULL{"app_install_id":null,"client_platform":"mediawiki_js","client_platform_family":"desktop_browser"}{"integration":{"data_type":"string","value":"discussiontools"},"loaded_timing":{"data_type":"number","value":"163"},"editing_session_id":{"data_type":"string","value":"671c83c5e7a71d17f0df"},"editor_interface":{"data_type":"string","value":"visualeditor"}}2022-10-25T02:02:04.592Z
NULL{"app_install_id":null,"client_platform":"mediawiki_js","client_platform_family":"desktop_browser"}{"integration":{"data_type":"string","value":"discussiontools"},"ready_timing":{"data_type":"number","value":"160"},"editing_session_id":{"data_type":"string","value":"0ace15ce513c7e780671"},"editor_interface":{"data_type":"string","value":"visualeditor"}}2022-10-25T02:03:59.389Z
NULL{"app_install_id":null,"client_platform":"mediawiki_js","client_platform_family":"desktop_browser"}{"integration":{"data_type":"string","value":"discussiontools"},"loaded_timing":{"data_type":"number","value":"95"},"editing_session_id":{"data_type":"string","value":"76e8013eb8c5d1524307"},"editor_interface":{"data_type":"string","value":"visualeditor"}}2022-10-25T02:07:19.803Z
NULL{"app_install_id":null,"client_platform":"mediawiki_js","client_platform_family":"desktop_browser"}{"integration":{"data_type":"string","value":"discussiontools"},"loaded_timing":{"data_type":"number","value":"85"},"editing_session_id":{"data_type":"string","value":"0c8b6f7f5bc9e3e5b254"},"editor_interface":{"data_type":"string","value":"visualeditor"}}2022-10-25T02:02:50.112Z
NULL{"app_install_id":null,"client_platform":"mediawiki_js","client_platform_family":"desktop_browser"}{"integration":{"data_type":"string","value":"discussiontools"},"loaded_timing":{"data_type":"number","value":"86"},"editing_session_id":{"data_type":"string","value":"10e7f04fb5e532e32d3c"},"editor_interface":{"data_type":"string","value":"visualeditor"}}2022-10-25T02:08:39.396Z
NULL{"app_install_id":null,"client_platform":"mediawiki_js","client_platform_family":"desktop_browser"}{"integration":{"data_type":"string","value":"discussiontools"},"init_mechanism":{"data_type":"string","value":"click"},"editing_session_id":{"data_type":"string","value":"0c8b6f7f5bc9e3e5b254"},"editor_interface":{"data_type":"string","value":"visualeditor"},"init_type":{"data_type":"string","value":"page"}}2022-10-25T02:02:50.028Z
NULL{"app_install_id":null,"client_platform":"mediawiki_js","client_platform_family":"desktop_browser"}{"integration":{"data_type":"string","value":"discussiontools"},"loaded_timing":{"data_type":"number","value":"1930"},"editing_session_id":{"data_type":"string","value":"0c59f30f2db47cf46809"},"editor_interface":{"data_type":"string","value":"wikitext-2017"}}2022-10-25T02:01:13.812Z
NULL{"app_install_id":null,"client_platform":"mediawiki_js","client_platform_family":"desktop_browser"}{"integration":{"data_type":"string","value":"discussiontools"},"ready_timing":{"data_type":"number","value":"86"},"editing_session_id":{"data_type":"string","value":"10e7f04fb5e532e32d3c"},"editor_interface":{"data_type":"string","value":"visualeditor"}}2022-10-25T02:08:39.396Z
NULL{"app_install_id":null,"client_platform":"mediawiki_js","client_platform_family":"desktop_browser"}{"integration":{"data_type":"string","value":"discussiontools"},"loaded_timing":{"data_type":"number","value":"93"},"editing_session_id":{"data_type":"string","value":"74b123d2290014ae69d5"},"editor_interface":{"data_type":"string","value":"visualeditor"}}2022-10-25T02:04:26.004Z
NULL{"app_install_id":null,"client_platform":"mediawiki_js","client_platform_family":"desktop_browser"}{"integration":{"data_type":"string","value":"discussiontools"},"init_mechanism":{"data_type":"string","value":"click"},"editing_session_id":{"data_type":"string","value":"76c323bb5d553793e6d4"},"editor_interface":{"data_type":"string","value":"visualeditor"},"init_type":{"data_type":"string","value":"page"}}2022-10-25T02:04:03.989Z
NULL{"app_install_id":null,"client_platform":"mediawiki_js","client_platform_family":"desktop_browser"}{"integration":{"data_type":"string","value":"discussiontools"},"loaded_timing":{"data_type":"number","value":"160"},"editing_session_id":{"data_type":"string","value":"0ace15ce513c7e780671"},"editor_interface":{"data_type":"string","value":"visualeditor"}}2022-10-25T02:03:59.390Z

Fwiw extending the query to year=2022 AND month=10 AND day > 20 AND day < 31 only returned 323 rows.

And the values for integration vary from discussiontools, page while for editor_interface, it's visualeditor, wikitext.

DLynch added a comment.Oct 31 2022, 1:49 PM

For what it's worth, with the deployment train, any changes made from the last few patches wouldn't have actually taken effect until October 27th.

I suppose that works out to ~5.2k edit attempts if we unsample it, or ~15k for the whole month. If that's across all projects and all edit methods, that seems much lower than expected.

Ottomata added a comment.Oct 31 2022, 1:55 PM

Also, seems like _schema should not be null which is the case for all rows.

T255818: Refine drops $schema field values

cjming added a comment.Oct 31 2022, 5:19 PM

ok - so turns out the edit_attempt stream sample rate is configured to 1 for testwiki only which explains why we have so few query results. We'll apply that sampling rate for all group0 wikis and expect to see an increase in rows returned starting tomorrow if I can get the config deployed this afternoon.

gerritbot added a comment.Oct 31 2022, 5:20 PM

Change 851109 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/mediawiki-config@master] Update sample rate for edit attempt stream to 1 for group 0.

https://gerrit.wikimedia.org/r/851109

gerritbot added a project: Patch-For-Review.Oct 31 2022, 5:20 PM
cjming reassigned this task from cjming to phuedx.Oct 31 2022, 5:21 PM
cjming moved this task from Sign Off to In Review on the Metrics Platform (Metrics Platform Kanban) board.
cjming subscribed.
cjming claimed this task.Oct 31 2022, 6:51 PM
cjming moved this task from In Review to Ready to Deploy on the Metrics Platform (Metrics Platform Kanban) board.
gerritbot added a comment.Oct 31 2022, 8:12 PM

Change 851109 merged by jenkins-bot:

[operations/mediawiki-config@master] Update sample rate for edit attempt stream to 1 for group 0.

https://gerrit.wikimedia.org/r/851109

Stashbot added a comment.Oct 31 2022, 8:12 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-31T20:12:44Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:851109|Update sample rate for edit attempt stream to 1 for group 0. (T312016)]]

Stashbot added a comment.Oct 31 2022, 8:13 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-31T20:13:03Z] <cjming@deploy1002> cjming and cjming: Backport for [[gerrit:851109|Update sample rate for edit attempt stream to 1 for group 0. (T312016)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Oct 31 2022, 8:17 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-31T20:17:01Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:851109|Update sample rate for edit attempt stream to 1 for group 0. (T312016)]] (duration: 04m 17s)

Maintenance_bot removed a project: Patch-For-Review.Oct 31 2022, 8:30 PM
cjming moved this task from Ready to Deploy to Sign Off on the Metrics Platform (Metrics Platform Kanban) board.Oct 31 2022, 8:34 PM
cjming added a comment.Oct 31 2022, 8:36 PM

Will verify data tomorrow since edit_attempt_step sample rate was bumped up to 1 for group0 wikis this afternoon.

phuedx added a comment.Nov 1 2022, 10:23 AM

We're also monitoring the event rate for the VEFU stream (eventlogging_VisualEditorFeatureUse). With that in mind, I don't see any discernable change in the event rate since last Thursday: https://grafana.wikimedia.org/d/000000018/eventlogging-schema?orgId=1&var-schema=VisualEditorFeatureUse&from=1666742400000&to=1667260799000

🎉

phuedx claimed this task.Nov 1 2022, 2:37 PM
phuedx moved this task from Sign Off to In Progress on the Metrics Platform (Metrics Platform Kanban) board.
gerritbot added a comment.Nov 1 2022, 3:21 PM

Change 851652 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/mediawiki-config@master] Update Edit Attempt Step sampling rate to 1 for group 0 wikis

https://gerrit.wikimedia.org/r/851652

gerritbot added a project: Patch-For-Review.Nov 1 2022, 3:21 PM
phuedx added a comment.Nov 1 2022, 3:38 PM

☝️ @cjming and I discussed this out of band but it's worth mentioning it here too for posterity: $wgWMESchemaEditAttemptStepSamplingRate will also need to be set to 1 on group0 wikis as well.

cjming claimed this task.Nov 1 2022, 3:40 PM
cjming moved this task from In Progress to Ready to Deploy on the Metrics Platform (Metrics Platform Kanban) board.
gerritbot added a comment.Nov 1 2022, 8:28 PM

Change 851652 merged by jenkins-bot:

[operations/mediawiki-config@master] Update Edit Attempt Step sampling rate to 1 for group 0 wikis

https://gerrit.wikimedia.org/r/851652

Stashbot added a comment.Nov 1 2022, 8:29 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-01T20:29:44Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:851652|Update Edit Attempt Step sampling rate to 1 for group 0 wikis (T312016)]]

Stashbot added a comment.Nov 1 2022, 8:29 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-01T20:29:53Z] <cjming@deploy1002> cjming and cjming: Backport for [[gerrit:851652|Update Edit Attempt Step sampling rate to 1 for group 0 wikis (T312016)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Nov 1 2022, 8:33 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-01T20:33:24Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:851652|Update Edit Attempt Step sampling rate to 1 for group 0 wikis (T312016)]] (duration: 04m 29s)

cjming moved this task from Ready to Deploy to Sign Off on the Metrics Platform (Metrics Platform Kanban) board.Nov 1 2022, 9:34 PM
Mayakp.wiki subscribed.Nov 2 2022, 7:59 PM
gerritbot added a comment.Nov 7 2022, 2:03 PM

Change 854005 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] wgWMESchemaEditAttemptStepSamplingRate to 1 on group1 wikis

https://gerrit.wikimedia.org/r/854005

gerritbot added a comment.Nov 7 2022, 2:03 PM

Change 854006 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] wgWMESchemaEditAttemptStepSamplingRate to 1 everywhere

https://gerrit.wikimedia.org/r/854006

phuedx moved this task from Sign Off to Ready to Deploy on the Metrics Platform (Metrics Platform Kanban) board.Nov 7 2022, 2:04 PM
gerritbot added a comment.Nov 8 2022, 8:30 AM

Change 854005 merged by jenkins-bot:

[operations/mediawiki-config@master] EditAttemptStep sampling rate to 1 for group1 wikis

https://gerrit.wikimedia.org/r/854005

Stashbot added a comment.Nov 8 2022, 8:30 AM

Mentioned in SAL (#wikimedia-operations) [2022-11-08T08:30:13Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:854005|EditAttemptStep sampling rate to 1 for group1 wikis (T312016)]]

Stashbot added a comment.Nov 8 2022, 8:30 AM

Mentioned in SAL (#wikimedia-operations) [2022-11-08T08:30:33Z] <kartik@deploy1002> kartik and phuedx: Backport for [[gerrit:854005|EditAttemptStep sampling rate to 1 for group1 wikis (T312016)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

gerritbot added a comment.Nov 8 2022, 9:40 AM

Change 854475 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] EditAttemptStep sampling rate to 1 for group1 wikis

https://gerrit.wikimedia.org/r/854475

gerritbot added a comment.Nov 8 2022, 6:06 PM

Change 854570 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] EditAttemptStep sampling rate to 1 everywhere

https://gerrit.wikimedia.org/r/854570

gerritbot added a comment.Nov 9 2022, 8:12 AM

Change 854475 merged by jenkins-bot:

[operations/mediawiki-config@master] EditAttemptStep sampling rate to 1 for group1 wikis

https://gerrit.wikimedia.org/r/854475

Stashbot added a comment.Nov 9 2022, 8:12 AM

Mentioned in SAL (#wikimedia-operations) [2022-11-09T08:12:56Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:854475|EditAttemptStep sampling rate to 1 for group1 wikis (T312016)]]

Stashbot added a comment.Nov 9 2022, 8:13 AM

Mentioned in SAL (#wikimedia-operations) [2022-11-09T08:13:18Z] <kartik@deploy1002> kartik and phuedx: Backport for [[gerrit:854475|EditAttemptStep sampling rate to 1 for group1 wikis (T312016)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Nov 9 2022, 8:21 AM

Mentioned in SAL (#wikimedia-operations) [2022-11-09T08:21:07Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:854475|EditAttemptStep sampling rate to 1 for group1 wikis (T312016)]] (duration: 08m 10s)

phuedx added a subtask: T322758: '.custom_data['mode'].data_type' should be equal to one of the allowed values.Nov 9 2022, 3:58 PM
Mayakp.wiki mentioned this in T320281: Instrumentation Data-QA for event.mediawiki_edit_attempt.Nov 9 2022, 7:36 PM
gerritbot added a comment.Nov 11 2022, 9:41 AM

Change 854006 abandoned by Phuedx:

[operations/mediawiki-config@master] wgWMESchemaEditAttemptStepSamplingRate to 1 everywhere

Reason:

I373b741156939c4e2c820ba0bd538c40a1ec45fb

https://gerrit.wikimedia.org/r/854006

gerritbot added a comment.Nov 15 2022, 9:03 PM

Change 854570 merged by jenkins-bot:

[operations/mediawiki-config@master] EditAttemptStep sampling rate to 1 everywhere

https://gerrit.wikimedia.org/r/854570

Stashbot added a comment.Nov 15 2022, 9:03 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-15T21:03:54Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:854570|EditAttemptStep sampling rate to 1 everywhere (T312016)]]

Stashbot added a comment.Nov 15 2022, 9:04 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-15T21:04:18Z] <cjming@deploy1002> cjming and phuedx: Backport for [[gerrit:854570|EditAttemptStep sampling rate to 1 everywhere (T312016)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Nov 15 2022, 9:08 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-15T21:08:40Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:854570|EditAttemptStep sampling rate to 1 everywhere (T312016)]] (duration: 04m 45s)

cjming moved this task from Ready to Deploy to Sign Off on the Metrics Platform (Metrics Platform Kanban) board.Nov 15 2022, 9:34 PM
phuedx added a comment.EditedNov 16 2022, 10:33 AM

There's been a significant in the number of events flowing on the mediawiki.edit_attempt and eventlogging_EditAttemptStep streams (see https://grafana.wikimedia.org/d/ZB39Izmnz/eventgate?orgId=1&viewPanel=74&from=1668542400000&to=1668643199000) with no corresponding increase in the number of validation errors (see https://logstash.wikimedia.org/goto/66b8b50eba0db999c6843b5594635a1e) 🎉🎉🎉

phuedx reassigned this task from cjming to • EChetty.Nov 16 2022, 10:33 AM
phuedx added a comment.Nov 17 2022, 8:29 AM

Note well that the flow rate on the mediawiki.edit_attempt stream will match that of the eventlogging_EditAttemptStep after T309985: Migrate WikiEditor EditAttemptStep instrument to Metrics Platform is resolved and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiEditor/+/855990/ has been merged.

• EChetty moved this task from Sign Off to Done on the Metrics Platform (Metrics Platform Kanban) board.Nov 17 2022, 3:38 PM
Aklapper removed • EChetty as the assignee of this task.Mar 6 2023, 6:29 AM

Removing inactive assignee (please do so as part of team offboarding!).

Maintenance_bot removed a project: Patch-For-Review.Mar 6 2023, 6:31 AM
phuedx mentioned this in T332438: Centralize EditAttemptStep logging code in WikimediaEvents.Mar 20 2023, 2:09 PM
• nettrom_WMF mentioned this in T325117: Personalized Praise: Instrumentation.Mar 21 2023, 11:03 PM
phuedx closed this task as Resolved.Mar 22 2023, 2:14 PM
phuedx claimed this task.

Being bold.

phuedx added a comment.EditedMar 22 2023, 2:16 PM

https://grafana.wikimedia.org/d/000000018/eventlogging-schema?orgId=1&var-schema=EditAttemptStep&from=1667606400000&to=now

phuedx mentioned this in T333168: Increase VisualEditorFeatureUse sampling rate to 100%.Mar 27 2023, 2:03 PM
MNeisler mentioned this in T330938: Ensure the sampling rates of the DesktopWebUIActions and EditAttemptStep schemas are synchronized.Apr 20 2023, 3:01 PM
phuedx closed subtask T322758: '.custom_data['mode'].data_type' should be equal to one of the allowed values as Resolved.Apr 24 2023, 12:35 PM
mpopov subscribed.Jun 27 2023, 4:09 PM

So is sampling rate 100% everywhere, then? Can someone please confirm and update event.editattemptstep documentation on DataHub? Because that page still says it's 6.25% of all editing sessions by default and 20% on some wikis.

cjming added a comment.EditedJun 27 2023, 4:29 PM

hi @mpopov -- I believe this is true based on prod config:
https://gerrit.wikimedia.org/r/plugins/gitiles/operations/mediawiki-config/+/refs/heads/master/wmf-config/ext-EventStreamConfig.php#1036

I'm happy to update that page on DataHub - will follow up shortly with edits -- turns out I don't have edit rights

phuedx added a comment.Jul 6 2023, 10:43 AM
In T312016#8968740, @mpopov wrote:

So is sampling rate 100% everywhere, then? Can someone please confirm and update event.editattemptstep documentation on DataHub?

Done™. I've kept the information about the complex sampling rates and oversampling mechanisms and also added a link to where I also documented it on Phab.

mpopov added a comment.Jul 6 2023, 2:28 PM

Thank you, @phuedx! (And welcome back!)

@cjming Aw! :( I've asked in #data-catalog for DE to hook you up with proper permissions.

cjming added a comment.Jul 6 2023, 6:36 PM
In T312016#8994145, @mpopov wrote:

I've asked in #data-catalog for DE to hook you up with proper permissions.

thanks @mpopov - i can edit now \o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits