Page MenuHomePhabricator

Fix "drag and drop" functionality in LiquidThreads (it does not work in all cases of possible moves)
Closed, ResolvedPublic

Description

Hello,

I found a bug in Lqt which broke the "Drag to new location" function.

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89121

The patch has been already applied in http://www.translatewiki.net so
that you can check and confirm that the functionality - which was broken for
a while - is indeed restored.

Tom

The patch is so simple

Index: trunk/extensions/LiquidThreads/LiquidThreads.php

  • trunk/extensions/LiquidThreads/LiquidThreads.php (revision 89120)

+++ trunk/extensions/LiquidThreads/LiquidThreads.php (revision 89121)
@@ -71,7 +71,7 @@
$wgResourceModules['ext.liquidThreads'] = $lqtResourceTemplate + array(

	'styles' => array( 'lqt.css', 'jquery/jquery.thread_collapse.css', 'lqt.dialogs.css' ),
	'scripts' => array( 'lqt.js', 'js/lqt.toolbar.js', 'jquery/jquery.thread_collapse.js', 'jquery/jquery.autogrow.js' ),
  • 'dependencies' => array( 'jquery.ui.dialog' ),

+ 'dependencies' => array( 'jquery.ui.dialog', 'jquery.ui.droppable' ),

	'messages' => $lqtMessages

);

I suggest those of you who run LiquidThreads extension to check this in.

As mentioned above, http://www.translatewiki.net runs the latest code (but on MediaWiki trunk version)


Version: unspecified
Severity: normal

Details

Reference
bz29205

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:34 PM
bzimport set Reference to bz29205.
bzimport added a subscriber: Unknown Object (MLST).

Deployed equivalent fix from r89136.

  • This bug has been marked as a duplicate of bug 28407 ***

Reopenend, because this functionality is broken again r97983 .

(In reply to comment #3)

Reopenend, because this functionality is broken again r97983 .

To be more precise: the drag and drop does not work in all cases.

Re-duping to bug 28407.

The new breakage is due a "TypeError: Cannot read property 'length' of undefined " exception, which has broken the "Drag to new location" feature for a few months now.
Reported as bug 37085.

  • This bug has been marked as a duplicate of bug 28407 ***