Page MenuHomePhabricator

Make sorting by participants on Special:MyEvents work on SQLite
Open, Needs TriagePublic

Description

Acceptance criteria

  • Sorting Special:MyEvents by number of participants works in SQLite (which includes navigating result pages)
  • The custom subquery approach is dropped in favour of the new functionality introduced in T308694 and T315465

Event Timeline

ifried renamed this task from Make sorting by participants on Special:MyEvents work on SQLite to Make sorting by participants on Special:MyEvents work on SQLite [not V0].Jul 11 2022, 2:28 PM
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)

a note on this ticket - am also unable to reproduce it on betacluster, but the bug persists on local env.

a note on this ticket - am also unable to reproduce it on betacluster, but the bug persists on local env.

Beta uses MariaDB, like patchdemo and prod; only mw-docker uses SQLite (by default).

I've been thinking about this issue, but I'm not sure how to proceed. IndexPager extracts the offsets from the query string and simply treats them as strings. This makes sense for actual strings and for some numeric strings (most notably, timestamps), but not for other things, like in this case. I'm not sure how to fix this properly; the quickest fix that I can think of is to cast num_participants to string in the SELECT.

Hey @Daimona @vyuen, do you all think this is required for V1 (general availability) release? If not, I wonder if we should marked it as stalled and/or remove from the sprint. cc @ifried

Hey @Daimona @vyuen, do you all think this is required for V1 (general availability) release? If not, I wonder if we should marked it as stalled and/or remove from the sprint. cc @ifried

I personally don't think this is needed, because prod does not use SQLite. The main reason for fixing this now would be so that sorting works when testing locally in Mediawiki-Docker. We will also need to do something about it when we mark the extension as stable (something that's not on our radar yet), either fix this bug or disable sorting by participants on SQLite.

ifried renamed this task from Make sorting by participants on Special:MyEvents work on SQLite [not V0] to Make sorting by participants on Special:MyEvents work on SQLite.Aug 31 2022, 3:52 PM
vyuen changed the task status from Open to Stalled.Sep 13 2022, 6:39 PM
vyuen changed the task status from Open to Stalled.

@vyuen: Could you please explain who or what (task?) exactly this task is stalled on ("If a report is waiting for further input (e.g. from its reporter or a third party) and can currently not be acted on")? Thanks.

This is currently blocked on receiving some input/feedback in the subtask. (I guess the "stalled" status could be somewhat redundant since it has a subtask, but it makes it easier to see that this task is blocked when looking at ensemble views like workboards).

Daimona changed the task status from Stalled to Open.Apr 9 2026, 3:19 PM
Daimona updated the task description. (Show Details)
Daimona moved this task from Backlog to Small Items Backlog on the Connection-Team board.