Maniphest T312073

Add payment type to membership application list entries in Fundraising Operation Center
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

None

Authored By

	kai.nissen
	Jul 5 2022, 8:34 AM

Description

The Fundraising Operation Center should show the payment type in the list of membership applications.

Acceptance Criteria

The payment type is shown in the payment detail column ("Zahlung") in the list of membership applications.
The detail view of a list entry shows payment data
- Payment type
- IBAN and BIC for direct debit
- Reference code for bank transfer
The detail view window title is changed to "Mitgliedschaftsantrag".
The obsolete fields "Geldinstitut", "Konto" and "Bankleitzahl" are removed from the detail view.

Mockups

List view
Detail view for direct debit
Detail view for bank transfer

Implementation details

Switch querying to use the payment tables.
Replace the controller code for the list and detail view.
See T313315: Refactor Membership Detail view in Fundraising Operation Center and T313314: Refactor Membership Overview in Fundraising Operation Center for more detailed refactoring steps and how to do the refactoring in a safe, tested manner

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T312070 Let members pay their fee by bank transfer
		Resolved		None	T312073 Add payment type to membership application list entries in Fundraising Operation Center

Event Timeline

kai.nissen created this task.Jul 5 2022, 8:34 AM

kai.nissen moved this task from Backlog to Ready for estimation on the WMDE-Fundraising-Tech board.Jul 5 2022, 9:01 AM

kai.nissen updated the task description. (Show Details)Jul 5 2022, 10:51 AM

kai.nissen set the point value for this task to 8.

kai.nissen moved this task from Ready for estimation to Sprint ready on the WMDE-Fundraising-Tech board.Jul 5 2022, 11:07 AM

gabriel-wmde updated the task description. (Show Details)Jul 22 2022, 1:36 PM

gabriel-wmde updated the task description. (Show Details)

AbbanWMDE claimed this task.Jan 30 2023, 9:38 AM

AbbanWMDE added a project: WMDE-FUN-Sprint-2023-01-23.

AbbanWMDE moved this task from Sprint ready to Current Sprint on the WMDE-Fundraising-Tech board.

AbbanWMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2023-01-23 board.

gabriel-wmde added a project: WMDE-FUN-Sprint-2023-02-06.Feb 6 2023, 11:05 AM

gabriel-wmde moved this task from Todo to Doing on the WMDE-FUN-Sprint-2023-02-06 board.Feb 6 2023, 11:09 AM

AbbanWMDE removed AbbanWMDE as the assignee of this task.Feb 16 2023, 8:19 AM

AbbanWMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2023-02-06 board.

AbbanWMDE subscribed.

kai.nissen added a project: WMDE-FUN-Sprint-2023-02-20.Feb 20 2023, 11:02 AM

kai.nissen changed the point value for this task from 8 to 3.

AbbanWMDE moved this task from Todo to Review on the WMDE-FUN-Sprint-2023-02-20 board.Feb 20 2023, 12:58 PM

AbbanWMDE moved this task from Review to Deploy on the WMDE-FUN-Sprint-2023-02-20 board.Mar 6 2023, 10:08 AM

AbbanWMDE moved this task from Deploy to Deploy to Test on the WMDE-FUN-Sprint-2023-02-20 board.

AbbanWMDE changed the point value for this task from 3 to 1.Mar 6 2023, 10:13 AM

AbbanWMDE added a project: WMDE-FUN-Sprint-2023-03-06.

AbbanWMDE moved this task from Todo to Deploy to Test on the WMDE-FUN-Sprint-2023-03-06 board.

not sure what the PR for this is but it seems already merged, I deployed the main branch to test-backend

CorinnaHillebrand_WMDE moved this task from Deploy to Test to Test on the WMDE-FUN-Sprint-2023-03-06 board.Mar 9 2023, 9:57 AM

@AbbanWMDE When clicking the 👁 to see the membership application details the server returns an error message and the client does not display the overlay window.

<br />
<b>Fatal error</b>:  Uncaught Error: Call to a member function getPaymentId() on null in /local/sites/test-backend.wikimedia.de/release-202303091055/src/DataAccess/DatabaseMembershipQueries.php:54
Stack trace:
#0 /local/sites/test-backend.wikimedia.de/release-202303091055/app/RouteHandlers/MembershipHandler.php(36): WMDE\Fundraising\Backend\DataAccess\DatabaseMembershipQueries-&gt;getMembershipById()
#1 /local/sites/test-backend.wikimedia.de/release-202303091055/app/RouteFactory.php(186): WMDE\Fundraising\Backend\App\RouteHandlers\MembershipHandler-&gt;memberDetails()
#2 /local/sites/test-backend.wikimedia.de/release-202303091055/vendor/symfony/http-kernel/HttpKernel.php(163): WMDE\Fundraising\Backend\App\RouteFactory-&gt;WMDE\Fundraising\Backend\App\{closure}()
#3 /local/sites/test-backend.wikimedia.de/release-202303091055/vendor/symfony/http-kernel/HttpKernel.php(74): Symfony\Component\HttpKernel\HttpKernel-&gt;handleRaw()
#4 /local/sites/test-backend.wikimedia.de/release-202303091055/app/Application.php(54): Symfony\Component\HttpKernel\HttpKernel-&gt;handle()
#5 /local/sites/test-backend.wikimedia.de/release-202303091055/app/Application.php(59): WMDE\Fundraising\Backend\App\Application-&gt;handle()
#6 /local/sites/test-backend.wikimedia.de/release-202303091055/index.php(20): WMDE\Fundraising\Backend\App\Application-&gt;run()
#7 {main}
  thrown in <b>/local/sites/test-backend.wikimedia.de/release-202303091055/src/DataAccess/DatabaseMembershipQueries.php</b> on line <b>54</b><br />

kai.nissen assigned this task to AbbanWMDE.Mar 10 2023, 9:09 AM

kai.nissen moved this task from Test to Todo on the WMDE-FUN-Sprint-2023-03-06 board.

I've created a fix for the error and also fixed the membership fee display (that previously was in Euro-Cents): https://github.com/wmde/fundraising-backend/pull/818

gabriel-wmde moved this task from Todo to Review on the WMDE-FUN-Sprint-2023-03-06 board.Mar 14 2023, 2:38 PM

CorinnaHillebrand_WMDE removed AbbanWMDE as the assignee of this task.Mar 14 2023, 4:03 PM

CorinnaHillebrand_WMDE moved this task from Review to Test on the WMDE-FUN-Sprint-2023-03-06 board.

Looks good to go.

CorinnaHillebrand_WMDE moved this task from Deploy to Done on the WMDE-FUN-Sprint-2023-03-06 board.Mar 16 2023, 1:41 PM

kai.nissen closed this task as Resolved.Mar 24 2023, 2:03 PM

	F35305384: Screenshot from 2022-07-05 10-17-52.png
	Jul 5 2022, 8:34 AM

	F35305381: Screenshot from 2022-07-05 10-17-06.png
	Jul 5 2022, 8:34 AM

	F35305376: Screenshot from 2022-07-05 09-52-18.png
	Jul 5 2022, 8:34 AM

Add payment type to membership application list entries in Fundraising Operation CenterClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Related ObjectsSearch...

Event Timeline

Add payment type to membership application list entries in Fundraising Operation Center
Closed, ResolvedPublic1 Estimated Story Points
Actions

Related Objects
Search...