Page MenuHomePhabricator
Create Task
Maniphest T312079

🎬️ mobile-de-02 | Hi | ⏰ July 25th
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

We want to slightly change the banner copy.

Acceptance Criteria

  • The banners are based on the control banner of mobile-de-01.
  • The sentence "An alle, die Wikipedia in Deutschland lesen" is changed to "Hi," and a line break in the first slide and in the expanded banner.
  • Clicking the close button of the expanded banner should only hide the banner and not set the cookie for preventing banner display for 7 days (both banners).
  • Banner screenshots are published on Shutterbug.

Related Objects
Search...

Event Timeline

kai.nissen created this task.Jul 5 2022, 8:48 AM
kai.nissen moved this task from Backlog to Ready for estimation on the WMDE-Fundraising-Tech board.Jul 5 2022, 9:01 AM
Maintenance_bot added a project: WMDE-FUN-Team.Jul 5 2022, 9:30 AM
kai.nissen renamed this task from 🎬️ mobile-de-01 | Hi | ⏰ July 25th to 🎬️ mobile-de-02 | Hi | ⏰ July 25th.Jul 5 2022, 9:35 AM
kai.nissen set the point value for this task to 2.
kai.nissen moved this task from Ready for estimation to Sprint ready on the WMDE-Fundraising-Tech board.Jul 5 2022, 11:06 AM
kai.nissen updated the task description. (Show Details)Jul 11 2022, 10:38 AM
kai.nissen updated the task description. (Show Details)Jul 11 2022, 10:43 AM
kai.nissen changed the point value for this task from 2 to 3.
kai.nissen added a project: WMDE-FUN-Sprint-2022-07-11.
CorinnaHillebrand_WMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2022-07-11 board.Jul 13 2022, 10:41 AM
CorinnaHillebrand_WMDE claimed this task.Jul 13 2022, 2:25 PM
CorinnaHillebrand_WMDE added a comment.Jul 13 2022, 4:20 PM

https://github.com/wmde/fundraising-banners/pull/967

CorinnaHillebrand_WMDE added a comment.EditedJul 14 2022, 11:18 AM

"both banners" means ctrl and var, right?
no cookie on fullpagebanner close button for ctrl and var.

I assume there also will be no "banner-closed" tracking for closing the fullpage banners

kai.nissen updated the task description. (Show Details)Jul 14 2022, 12:59 PM
kai.nissen added a comment.Jul 14 2022, 1:55 PM

Yes, control and variant banner. Keeping the close button click logging would be good, probably better to use a different action name for the expanded banner close button click.

CorinnaHillebrand_WMDE added a comment.Jul 14 2022, 2:21 PM

I gave the expanded banner a 'banner-closed-maybelater' tracking code now,
the mini banner will continue to use 'banner-closed'

gabriel-wmde moved this task from Doing to Review on the WMDE-FUN-Sprint-2022-07-11 board.Jul 19 2022, 9:08 AM
AbbanWMDE moved this task from Review to Test on the WMDE-FUN-Sprint-2022-07-11 board.Jul 22 2022, 4:42 AM
gabriel-wmde moved this task from Sprint ready to Current Sprint on the WMDE-Fundraising-Tech board.Jul 22 2022, 1:32 PM
kai.nissen moved this task from Test to Done on the WMDE-FUN-Sprint-2022-07-11 board.Jul 25 2022, 1:04 PM
kai.nissen removed CorinnaHillebrand_WMDE as the assignee of this task.Jul 25 2022, 1:09 PM
kai.nissen added a subscriber: CorinnaHillebrand_WMDE.
kai.nissen closed this task as Resolved.Aug 31 2022, 7:22 AM
kai.nissen claimed this task.
kai.nissen mentioned this in W2044 Welcome.Dec 5 2022, 12:23 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL