For example the first discussion here gets no counters:
https://www.mediawiki.org/wiki/Talk:Typography_refresh
It also can't be subscribed to, even with topic containers disabled (T298617)
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Show topic container even if heading is unsubscribable | mediawiki/extensions/DiscussionTools | master | +10 -6 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 811348 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/DiscussionTools@master] Fix fetching of oldest comment in a thread
Comment Actions
The subscription part of this is T298617, so I'll limit this task to the topic containers part.
Comment Actions
From the patch:
Bartosz Dziewoński
This actually fixes T298617 as well, but I am not sure if that isn't too much. I wrote a longer comment on that task, but in short, I'm concerned that "merging in" a subsection into a topic can now change its name and break the subscriptions (as seen in several of the tests). I'd like us to do something smart about this situation first (e.g. notify subscribers when it happens).
Esanders
I think there are always going to be cases where people splice bits of threads together and/or add introductory comments which break subscriptions. I would be nice if we could resolve that, maybe with the comment metadata database, but for now I think this is at least consistent and understandable logic, and probably fixes more cases than it breaks.
Comment Actions
Change 816226 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/DiscussionTools@master] Show topic container even if heading is unsubscribable
Comment Actions
Change 816226 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Show topic container even if heading is unsubscribable
Comment Actions
@Esanders would it be accurate for me to think the reason that the first section on this page (== New font stack breakdown ==) does not get the Topic Container counters/metadata because the signature ( Edokter (talk) — 12:36, 12 April 2014 (UTC)) appears within an H4, in this case ====Helvetica====?
Comment Actions
This looks fixed now. Probably the page's parser cache had to expire (or be purged).