Avoid duplicate PHP logic between ZObjectEditAction, ZObjectContentHandler, and SpecialCreateZObject
Open, MediumPublic
Actions

Assigned To

None

Authored By

	• JKieserman
	Jul 5 2022, 8:24 PM

Description

I noticed there's a lot of duplicate lines of code across

ZObjectEditAction.php
ZObjectContentHandler.php
SpecialCreateZObject.php

...should we find a way to deduplicate?

The code to generate the placeholder for the Vue app to load and to configure it
The code to generate the language ISO code shown next to labels of ZTypes and ZObjects
Others?

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Deduplicate code between ZObjectContentHandler and ZObjectEditAction	mediawiki/extensions/WikiLambda	master	+81 -53
A bit more of cleanup and factorizations	mediawiki/extensions/WikiLambda	master	+69 -53
Deduplicate code between SpecialCreateZObject and ZObjectEditAction	mediawiki/extensions/WikiLambda	master	+68 -58

Customize query in gerrit

Event Timeline

• JKieserman created this task.Jul 5 2022, 8:24 PM

• JKieserman moved this task from No current plans / External to To Triage on the Abstract Wikipedia team board.Jul 6 2022, 5:34 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia Fix-It tasks, WikiLambda, Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.Jul 19 2022, 6:38 PM

Teleosteen claimed this task.Aug 24 2022, 1:29 PM

Currently working on it (I'll try to push my work in progress ASAP)

I could quite easily factorize code between ZObjectEditAction.php and SpecialCreateZObject.php in a mixin I declared

I encounter more difficulties about factorizing content in ZObjectContentHandler.php. I think I don't understand yet the role of the fillParserOutput function and the role of some variables (and what they represent).

I'll try to figure out how to trigger the fillParserOutput by myself (so I can step-debug it), but if you have time to help me on it, that would be much appreciated! :)

Change 826984 had a related patch set uploaded (by Teleosteen; author: Teleosteen):

[mediawiki/extensions/WikiLambda@master] Deduplicate code between SpecialCreateZObject and ZObjectEditAction

https://gerrit.wikimedia.org/r/826984

gerritbot added a project: Patch-For-Review.Aug 28 2022, 8:06 AM

(I pushed my work in progress as promised)

Change 827563 had a related patch set uploaded (by Teleosteen; author: Teleosteen):

[mediawiki/extensions/WikiLambda@master] Factorize iso code getArgumentDeclarations

https://gerrit.wikimedia.org/r/827563

gerritbot added a project: Patch-For-Review.Aug 29 2022, 8:34 PM

Jdforrester-WMF renamed this task from PHP duplication to Avoid duplicate PHP logic between ZObjectEditAction, ZObjectContentHandler, and SpecialCreateZObject.Aug 29 2022, 9:25 PM

Jdforrester-WMF updated the task description. (Show Details)

Change 827990 had a related patch set uploaded (by Teleosteen; author: Teleosteen):

[mediawiki/extensions/WikiLambda@master] A bit more of cleanup and factorizations

https://gerrit.wikimedia.org/r/827990

I guess we could do more, but it would probably take time for me (maybe more functional and technical background on WikiLambda can help doing more).

Review welcome! :)

Also I can squash the commits, I don't think it is worth to keep 3 commits for this ticket.

Change 826984 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Deduplicate code between SpecialCreateZObject and ZObjectEditAction

https://gerrit.wikimedia.org/r/826984

Jdforrester-WMF updated the task description. (Show Details)Aug 31 2022, 2:16 PM

Change 827990 abandoned by Teleosteen:

[mediawiki/extensions/WikiLambda@master] A bit more of cleanup and factorizations

Reason:

Commit squashed into b95710285e

https://gerrit.wikimedia.org/r/827990

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.28; 2022-09-05).Aug 31 2022, 3:00 PM

Change 827563 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Deduplicate code between ZObjectContentHandler and ZObjectEditAction

https://gerrit.wikimedia.org/r/827563

Maintenance_bot removed a project: Patch-For-Review.Sep 9 2022, 4:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 9 2022, 5:00 PM

Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:27 PM

Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:45 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).

DVrandecic moved this task to Phase κ – Clean-up on the Abstract Wikipedia team board.Nov 15 2022, 7:41 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

DVrandecic moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.

DVrandecic edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).

Jdforrester-WMF triaged this task as Medium priority.Mar 24 2023, 1:07 AM

Jdforrester-WMF removed Teleosteen as the assignee of this task.Oct 26 2023, 4:54 PM

Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.

Jdforrester-WMF added a subscriber: Teleosteen.

Jdforrester-WMF moved this task from Backlog to Engineering Backlog on the Abstract Wikipedia team board.Nov 20 2024, 5:56 PM

Avoid duplicate PHP logic between ZObjectEditAction, ZObjectContentHandler, and SpecialCreateZObjectOpen, MediumPublicActions

Description

Details

Event Timeline

Avoid duplicate PHP logic between ZObjectEditAction, ZObjectContentHandler, and SpecialCreateZObject
Open, MediumPublic
Actions