Page MenuHomePhabricator

Test 'map "echo" function to a list of items' is incorrect
Closed, ResolvedPublicBUG REPORT

Description

In the test the argument reference "Z10043K1" refers to itself: https://github.com/wikimedia/mediawiki-services-function-orchestrator/blob/1493b87952b0dad72426c80026ce8e9d091abdae/test/features/v1/test_data/map-Z10043.json#L132.

This should normally not be allowed. Currently passes because of dynamic scoping (https://phabricator.wikimedia.org/T309038), and so blocks the fix for that bug.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 811977 had a related patch set uploaded (by AAssaf; author: AAssaf):

[mediawiki/services/function-orchestrator@master] Fix the 'map "echo" function to a list of items' test to not use dynamic scoping.

https://gerrit.wikimedia.org/r/811977

Change 811977 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Fix the 'map "echo" function to a list of items' test to not use dynamic scoping.

https://gerrit.wikimedia.org/r/811977