Page MenuHomePhabricator
Create Task
Maniphest T312212

Variant tab in Vector 2022 is too close to the tab on its left
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Diskdance
Jul 6 2022, 12:54 PM
Tags
Referenced Files
Restricted File
Jul 31 2022, 8:34 PM
Restricted File
Jul 31 2022, 8:34 PM
F35371571: Screen Shot 2022-07-31 at 1.31.01 PM.png
Jul 31 2022, 8:32 PM
F35371570: Screen Shot 2022-07-31 at 1.31.24 PM.png
Jul 31 2022, 8:32 PM
F35349694: Screen Shot 2022-07-27 at 6.34.18 PM.png
Jul 28 2022, 1:35 AM
F35312555: image.png
Jul 9 2022, 4:59 AM
F35312289: Screen Shot 2022-07-08 at 3.07.11 PM.png
Jul 8 2022, 7:07 PM
F35309666: image.png
Jul 6 2022, 12:54 PM
View All 9 Files
Subscribers
Aklapper
• alexhollender_WMF
Diskdance
Edtadros
Ericliu1912
Jdlrobson
Jdrewniak
TheresNoTime

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
The variant tab doesn't have correct margin. It's too close to the tab on its left.

image.png (153×468 px, 8 KB)

What should have happened instead?:
It should have correct margin, like that in the legacy vector:

image.png (163×534 px, 15 KB)

QA Results - Beta

ACStatusDetails
1✅T312212#8110711

QA Results - Prod

ACStatusDetails
1✅T312212#8118108

Details

SubjectRepoBranchLines +/-
Refactor Vector tabs layout for reduced size & complexitymediawiki/skins/Vectormaster+57 -100
Refactor Vector tabs layout for reduced size & complexitymediawiki/skins/Vectormaster+55 -99
Customize query in gerrit

Related Objects
Search...

Event Timeline

Diskdance created this task.Jul 6 2022, 12:54 PM
Restricted Application added subscribers: Ericliu1912, Stang, Aklapper. · View Herald TranscriptJul 6 2022, 12:54 PM
TheresNoTime subscribed.Jul 7 2022, 3:45 PM
Shizhao moved this task from Backlog to Extensions/Skins on the Chinese-Sites board.Jul 8 2022, 3:52 AM
Jdlrobson moved this task from Incoming to Layout on the Desktop Improvements (Vector 2022) board.Jul 8 2022, 6:12 PM
Jdlrobson added a project: Web-Team-Backlog.Jul 8 2022, 6:56 PM
Jdlrobson added subscribers: Jdrewniak, Jdlrobson.

@Jdrewniak are you aware of this issue and what might have caused it?

Jdlrobson added a subscriber: • alexhollender_WMF.Jul 8 2022, 6:57 PM

I'm not 100% sure this is a regression though -it looks more like a case of we removed the backgrounds and borders and didn't consider how this would look.

• alexhollender_WMF added a comment.Jul 8 2022, 7:07 PM

@Diskdance thank you for reporting this issue.

@Jdlrobson looking at the screenshots it seems like we lost ~25px of spacing.

Screen Shot 2022-07-08 at 3.07.11 PM.png (470×1 px, 63 KB)

Diskdance added a comment.Jul 9 2022, 4:59 AM
In T312212#8066295, @alexhollender_WMF wrote:

@Diskdance thank you for reporting this issue.

@Jdlrobson looking at the screenshots it seems like we lost ~25px of spacing.

Screen Shot 2022-07-08 at 3.07.11 PM.png (470×1 px, 63 KB)

Thank you, and I would like to provide another screenshot with variant tab focused, which may help you identify this issue:

image.png (228×563 px, 10 KB)

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Jul 11 2022, 9:44 PM
ovasileva triaged this task as Medium priority.Jul 12 2022, 8:44 AM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q1); removed Web-Team-Backlog.
ovasileva added a parent task: T301780: [Epic] Visual design & layout refinements.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 12 2022, 3:13 PM
gerritbot added a comment.Jul 18 2022, 9:23 PM

Change 810968 had a related patch set uploaded (by Jdlrobson; author: Jdrewniak):

[mediawiki/skins/Vector@master] Refactor Vector tabs layout for reduced size & complexity

https://gerrit.wikimedia.org/r/810968

gerritbot added a project: Patch-For-Review.Jul 18 2022, 9:23 PM
Jdlrobson assigned this task to Edtadros.Jul 18 2022, 10:42 PM
Jdlrobson moved this task from Upcoming to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
gerritbot added a comment.Jul 18 2022, 11:01 PM

Change 810968 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Refactor Vector tabs layout for reduced size & complexity

https://gerrit.wikimedia.org/r/810968

Maintenance_bot removed a project: Patch-For-Review.Jul 18 2022, 11:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 19 2022, 12:00 AM
gerritbot added a comment.Jul 19 2022, 4:17 PM

Change 815323 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Refactor Vector tabs layout for reduced size & complexity

https://gerrit.wikimedia.org/r/815323

gerritbot added a project: Patch-For-Review.Jul 19 2022, 4:17 PM
gerritbot added a comment.Jul 19 2022, 6:03 PM

Change 815323 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Refactor Vector tabs layout for reduced size & complexity

https://gerrit.wikimedia.org/r/815323

Maintenance_bot removed a project: Patch-For-Review.Jul 19 2022, 6:29 PM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.22; 2022-07-25); removed MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 19 2022, 7:00 PM
Jdlrobson mentioned this in T313562: Design review the visual enhancement and layout changes.Jul 21 2022, 10:54 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 28 2022, 1:35 AM

Test Result - Beta

Status: ✅ PASS
Environment: zhwiki beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Variant tab should be evenly spaced in zhwiki

Screen Shot 2022-07-27 at 6.34.18 PM.png (443×1 px, 102 KB)

Edtadros reassigned this task from Edtadros to ovasileva.EditedJul 31 2022, 8:32 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: zhwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Variant tab should be evenly spaced in zhwiki

Screen Shot 2022-07-31 at 1.31.24 PM.png (386×1 px, 103 KB)

Screen Shot 2022-07-31 at 1.31.01 PM.png (350×1 px, 46 KB)

{F35371592}

{F35371593}

Edtadros updated the task description. (Show Details)Jul 31 2022, 8:33 PM
ovasileva closed this task as Resolved.Aug 1 2022, 12:45 PM

Looks good, resolving!

Stang moved this task from Extensions/Skins to Closed on the Chinese-Sites board.Aug 1 2022, 1:01 PM
Stang unsubscribed.Aug 4 2022, 1:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL