Page MenuHomePhabricator
Create Task
Maniphest T312222

Create FallbackLabelDescriptionLookupFactory
Closed, ResolvedPublic
Actions

Description

Create a new class and service, FallbackLabelDescriptionLookupFactory. It is similar to LanguageFallbackLabelDescriptionLookupFactory, but doesn’t promise to return any particular implementation of the FallbackLabelDescriptionLookup interface. In practice, it should return a CachingFallbackLabelDescriptionLookup wrapping a LanguageFallbackLabelDescriptionLookup; the required services (other than the user language) should be part of the factory.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Inject RedirectResolvingLatestRevisionLookup into WikibaseValueFormatterBuildersmediawiki/extensions/Wikibasemaster+12 -22
Deprecate LanguageFallbackLabelDescriptionLookupFactorymediawiki/extensions/Wikibasemaster+9 -0
Create FallbackLabelDescriptionLookupFactory servicemediawiki/extensions/Wikibasemaster+383 -0
Extract RedirectResolvingLatestRevisionLookup servicemediawiki/extensions/Wikibasemaster+105 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 6 2022, 1:31 PM
Lucas_Werkmeister_WMDE mentioned this in T312223: Use FallbackLabelDescriptionLookupFactory in code.
Lucas_Werkmeister_WMDE mentioned this in T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages).
Lucas_Werkmeister_WMDE claimed this task.Jul 6 2022, 3:05 PM
Lucas_Werkmeister_WMDE moved this task from To Do to Doing on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
gerritbot added a comment.Jul 6 2022, 5:04 PM

Change 811753 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Extract RedirectResolvingLatestRevisionLookup service

https://gerrit.wikimedia.org/r/811753

gerritbot added a project: Patch-For-Review.Jul 6 2022, 5:04 PM

Change 811754 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Create FallbackLabelDescriptionLookupFactory service

https://gerrit.wikimedia.org/r/811754

gerritbot added a comment.Jul 6 2022, 5:05 PM

Change 811755 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Inject RedirectResolvingLatestRevisionLookup into WikibaseValueFormatterBuilders

https://gerrit.wikimedia.org/r/811755

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.Jul 6 2022, 5:06 PM
gerritbot added a comment.Jul 8 2022, 8:28 AM

Change 812240 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Deprecate LanguageFallbackLabelDescriptionLookupFactory

https://gerrit.wikimedia.org/r/812240

gerritbot added a comment.Jul 8 2022, 10:26 AM

Change 811753 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Extract RedirectResolvingLatestRevisionLookup service

https://gerrit.wikimedia.org/r/811753

gerritbot added a comment.Jul 8 2022, 1:48 PM

Change 811754 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Create FallbackLabelDescriptionLookupFactory service

https://gerrit.wikimedia.org/r/811754

gerritbot added a comment.Jul 11 2022, 10:37 AM

Change 812240 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Deprecate LanguageFallbackLabelDescriptionLookupFactory

https://gerrit.wikimedia.org/r/812240

gerritbot added a comment.Jul 11 2022, 11:43 AM

Change 811755 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Inject RedirectResolvingLatestRevisionLookup into WikibaseValueFormatterBuilders

https://gerrit.wikimedia.org/r/811755

Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 11 2022, 12:05 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
Maintenance_bot removed a project: Patch-For-Review.Jul 11 2022, 12:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 5:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits